Re: [sage-devel] Re: code review tools

2010-04-14 Thread Tim Daly
Speaking of that, why not institute a "program committee" where people volunteer to do reviews before your Sage days? I do a lot of program committee work, which is painful but is a professional "giving back to the community" task. It is always done against a deadline which is a great motivation.

Re: [sage-devel] Re: code review tools

2010-04-14 Thread William Stein
On Wed, Apr 14, 2010 at 12:43 PM, John Cremona wrote: > I have been strongly encouraging new students starting out with Sage > to make small (initially) patches  on their very own ticket, so that > they can feel good when these get reviewed positively and then merged. >  But those same people migh

Re: [sage-devel] Re: code review tools

2010-04-14 Thread John Cremona
I have been strongly encouraging new students starting out with Sage to make small (initially) patches on their very own ticket, so that they can feel good when these get reviewed positively and then merged. But those same people might take quite a while longer before they feel confident about re

Re: [sage-devel] Re: code review tools

2010-04-14 Thread Robert Bradshaw
On Apr 14, 2010, at 11:09 AM, Robert Miller wrote: That could backfire - people may decide to review tickets they might not otherwise feel confident about reviewing. If I don't feel like reviewing a ticket with high "karma" but I do care about one with low karma, then I would review zero tic

Re: [sage-devel] Re: code review tools

2010-04-14 Thread William Stein
On Wed, Apr 14, 2010 at 11:08 AM, Robert Bradshaw wrote: > On Apr 14, 2010, at 10:52 AM, Harald Schilly wrote: > >> On Apr 14, 6:23 pm, "Dr. David Kirkby" >> wrote: >>> >>> That could backfire - people may decide to review tickets they might not >>> otherwise feel confident about reviewing. > > T

Re: [sage-devel] Re: code review tools

2010-04-14 Thread Robert Bradshaw
On Apr 14, 2010, at 10:52 AM, Harald Schilly wrote: On Apr 14, 6:23 pm, "Dr. David Kirkby" wrote: That could backfire - people may decide to review tickets they might not otherwise feel confident about reviewing. That's a good point. Fortunately, all the people I've met in the Sage commu

Re: [sage-devel] Re: code review tools

2010-04-14 Thread Robert Miller
>> That could backfire - people may decide to review tickets they might not >> otherwise feel confident about reviewing. If I don't feel like reviewing a ticket with high "karma" but I do care about one with low karma, then I would review zero tickets instead of one, and be irritated that I could