Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-06-11 Thread Travis Scrimshaw
Or instead you have a whitelist for those that want it. I think at least one of these changes (whitelist or blacklist) should just be done in the same general way that these labels were introduced: no vote and just do it. This really should have had a vote, or at least a notification on sage-de

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-06-07 Thread seb....@gmail.com
*> How about having a voting for this issue? * Another possibility would be to have a blacklist (but I don't know where) that developers can sign up to if they want to be excluded from automations that apply to PRs. In this thread's example, a developer would exclude PRs that he himself author

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-31 Thread Matthias Koeppe
On Tuesday, May 28, 2024 at 12:19:42 PM UTC-7 Matthias Koeppe wrote: On Tuesday, May 28, 2024 at 1:24:17 AM UTC-7 Travis Scrimshaw wrote: Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 Thanks, I've let the author know in https://github.c

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-28 Thread Matthias Koeppe
On Tuesday, May 28, 2024 at 1:24:17 AM UTC-7 Travis Scrimshaw wrote: Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 Thanks, I've let the author know in https://github.com/sagemath/sage/pull/37262#issuecomment-2135699139 -- You receive

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-28 Thread Kwankyu Lee
I *very* strongly believe we should disable this automatically being added to PRs. How about having a voting for this issue? -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, s

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-28 Thread Travis Scrimshaw
Another data point: the bot is getting the size wrong too: https://github.com/sagemath/sage/pull/38105 I *very* strongly believe we should disable this automatically being added to PRs. Travis On Friday, May 10, 2024 at 3:21:57 PM UTC+9 seb@gmail.com wrote: > I must confess that I have no

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-16 Thread Matthias Koeppe
On Friday, May 10, 2024 at 7:01:43 AM UTC-7 Dima Pasechnik wrote: It's also discouraging word, "minimal" I'm also not happy about the word "minimal", but simply because it's too close to "minor", which appears in priority labels. -- You received this message because you are subscribed to the

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-14 Thread Dima Pasechnik
On Tue, May 14, 2024 at 1:48 AM Matthias Koeppe wrote: > > On Sunday, May 12, 2024 at 6:50:05 PM UTC-7 Travis Scrimshaw wrote: > > That model is not how we have worked as a community, nor do I think it is a > productive way to run a smaller developer community such as ours. > > > I'm not sure wha

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-10 Thread Dima Pasechnik
On 9 May 2024 22:46:17 BST, Travis Scrimshaw wrote: >I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor >they serve no useful purpose as far as I can tell. To this point, they do >not reflect the difficulty of a review; in fact, they are at best >counterproductive to

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-09 Thread seb....@gmail.com
I must confess that I have not thought about the aspects of these labels that Travis points out, but I fully understand these concerns. If they are annoying for many developers, the feature can be easily disabled by removing corresponding variables from the repository. Vincent Delecroix schrie

Re: [sage-devel] Re: New labels v: mimimal, v: small ... on pull requests

2024-05-09 Thread Vincent Delecroix
I fully agree with Travis. I do not see the added value of these additional tags. On Thu, 9 May 2024 at 23:46, Travis Scrimshaw wrote: > > I am *very* strongly opposed to these tags. Their cutoffs are arbitrary nor > they serve no useful purpose as far as I can tell. To this point, they do not