Re: [sage-devel] code review tools

2010-04-14 Thread Dr. David Kirkby
William Stein wrote: I've also been thinking of instituting a "karma system", where you get Karma for doing reviews. Moreover, people who submit a lot of code for inclusion and don't do reviews... will have the lowest priority for getting their code reviewed. -- William That could backfire

Re: [sage-devel] code review tools

2010-04-13 Thread William Stein
On Tue, Apr 13, 2010 at 11:28 AM, Jason Grout wrote: > A while ago, some people pointed out the benefits of using something like > Rietveld [1] to do code review, which is a web-based code review tool that > allows people to comment (inline) on specific lines in a diff, I think > supports iterated

[sage-devel] code review tools

2010-04-13 Thread Jason Grout
A while ago, some people pointed out the benefits of using something like Rietveld [1] to do code review, which is a web-based code review tool that allows people to comment (inline) on specific lines in a diff, I think supports iterated patches, etc. I ran across ReviewBoard today [2] which s