Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Vincent Delecroix
Already with #18411 it gets better sage: %time TestSuite(TransitiveGroups()).run() CPU times: user 27.9 s, sys: 1.83 s, total: 29.8 s Wall time: 32 s against sage: %time TestSuite(TransitiveGroups()).run() CPU times: user 47.3 s, sys: 3.1 s, total: 50.4 s Wall time: 52.9 s There are indeed som

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Travis Scrimshaw
You can specify the number of trials with "max_runs=100" or explicitly specify the elements to test with "elements=[a, list, of, elements]". Best, Travis On Tuesday, September 15, 2015 at 6:57:11 AM UTC-5, Nathann Cohen wrote: > > > Doesn't TestSuite().run() have an option to limit the number o

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Nathann Cohen
> Doesn't TestSuite().run() have an option to limit the number of tests? I > would use that to reduce the time taken. I do not think that I can be of any help with TestSuite. Never used it. Nathann -- You received this message because you are subscribed to the Google Groups "sage-devel" group.

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Nathann Cohen
Hellooo, > That is an interesting idea, as a way to get good illustrative > examples into the manual without slowing down the testing process. > But of course it would be better to have a set-up where I could (at > least temprarily) turn back on the testing of these, since if they are > not ev

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Jeroen Demeyer
On 2015-09-15 13:28, Nathann Cohen wrote: I would say that "long time" tests should be less than 30 seconds, unless there is some exceptional justification. In some cases, I also skip shorter tests as *many* 10-seconds tests are not much better than a 2 minutes test :-/ In the case at hand, i.

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread John Cremona
On 15 September 2015 at 12:42, Nathann Cohen wrote: > John, > > I do not follow you in your message. Surely the doctests have a double > purpose (documentation+test), but nothing prevents you from writing a > good documentation on one side with "# not tested" flags (so that the That is an interes

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Nathann Cohen
John, I do not follow you in your message. Surely the doctests have a double purpose (documentation+test), but nothing prevents you from writing a good documentation on one side with "# not tested" flags (so that the tests are informative to the users) while keeping in a 'TEST' sections some docte

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread John Cremona
On 15 September 2015 at 12:28, Nathann Cohen wrote: >> I would say that "long time" tests should be less than 30 seconds, unless >> there is some exceptional justification. > > In some cases, I also skip shorter tests as *many* 10-seconds tests > are not much better than a 2 minutes test :-/ > > I

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Nathann Cohen
> I would say that "long time" tests should be less than 30 seconds, unless > there is some exceptional justification. In some cases, I also skip shorter tests as *many* 10-seconds tests are not much better than a 2 minutes test :-/ In the case at hand, i.e. the 50 seconds doctest I reported that

Re: [sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Jeroen Demeyer
I would say that "long time" tests should be less than 30 seconds, unless there is some exceptional justification. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to

[sage-devel] What is "long time", what should not be tested

2015-09-15 Thread Nathann Cohen
Hello everybody, In my current patches I often meet some threshold in the doctests I add. Instantaneous doctests are okay, doctests which last a few seconds are "# long time", but because I add many 'long' doctests in the same files I sometimes flag them as 'not tested' lest it take minutes to doc