On 15 September 2015 at 12:28, Nathann Cohen <nathann.co...@gmail.com> wrote: >> I would say that "long time" tests should be less than 30 seconds, unless >> there is some exceptional justification. > > In some cases, I also skip shorter tests as *many* 10-seconds tests > are not much better than a 2 minutes test :-/ > > In the case at hand, i.e. the 50 seconds doctest I reported that > appears in the group code: what do you think of it ? Is it justified > to keep it, or should we remove it, or only test the smaller of those > groups if they are not already tested elsewhere ?
I am also responsible for some longer doctests, and have the additional problem that some of these occur in a file which is very long (sage/schemes/elliptic_curves/ell_number_field) and hard to split since almost everything in there is methods for a single class. Even if some functionality is implemented outside the class, there will still be class method to call upon that, which *should* have many doctests so that the reference manual is actually useful. And examples with are useful or interesting to have in the reference manual are not always very quick. John > > Nathann > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
