Re: [sage-devel] Trac workflow and needs_review

2016-06-30 Thread Erik Bray
On Tue, Jun 28, 2016 at 10:20 PM, Volker Braun wrote: > On Tuesday, June 28, 2016 at 6:23:18 PM UTC+2, Erik Bray wrote: >> >> Currently the release manager *closes* a ticket and marks it as >> "fixed" when merging the change for testing. > > > No. Tickets are closed *after* tests succeed. I'm jus

Re: [sage-devel] Trac workflow and needs_review

2016-06-28 Thread Volker Braun
On Tuesday, June 28, 2016 at 6:23:18 PM UTC+2, Erik Bray wrote: > > Currently the release manager *closes* a ticket and marks it as > "fixed" when merging the change for testing. No. Tickets are closed *after* tests succeed. The only race condition is if somebody else reopens positively review

Re: [sage-devel] Trac workflow and needs_review

2016-06-28 Thread Erik Bray
On Tue, Jun 28, 2016 at 4:06 PM, Vincent Delecroix <20100.delecr...@gmail.com> wrote: > On 28/06/16 16:04, Erik Bray wrote: >> >> Hi all, >> >> The current ticket workflow in Trac only allows creating new tickets >> with a status 'new'. So when posting a branch with proposed changes, >> for exampl

[sage-devel] Trac workflow and needs_review

2016-06-28 Thread Erik Bray
Hi all, The current ticket workflow in Trac only allows creating new tickets with a status 'new'. So when posting a branch with proposed changes, for example it is necessary to create the ticket, and then immediately update it to needs_review. This is fine for tickets that don't immediately have

Re: [sage-devel] Trac workflow and needs_review

2016-06-28 Thread Vincent Delecroix
On 28/06/16 16:04, Erik Bray wrote: Hi all, The current ticket workflow in Trac only allows creating new tickets with a status 'new'. So when posting a branch with proposed changes, for example it is necessary to create the ticket, and then immediately update it to needs_review. This is fine f