On Tue, Jun 28, 2016 at 10:20 PM, Volker Braun <vbraun.n...@gmail.com> wrote: > On Tuesday, June 28, 2016 at 6:23:18 PM UTC+2, Erik Bray wrote: >> >> Currently the release manager *closes* a ticket and marks it as >> "fixed" when merging the change for testing. > > > No. Tickets are closed *after* tests succeed.
I'm just going by what Jeroen told me here: https://trac.sagemath.org/ticket/20423#comment:12 I feel like I've also seen a ticket of mine closed and reopened again for exactly this reason, unless that's changed. > The only race condition is if somebody else reopens positively reviewed > tickets whose tests pass. Arguably that shouldn't be done, since that ticket > is complete. There is always something else to do, just open a new ticket. > Instead of reopening an old ticket to pile on more commits. Agreed here. If it's closed+merged it should remain closed, unless it was just closed by accident. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
