+1 for lint; adding a suitable set of linting rules to the testsuite would
have a much greater impact on code quality than enforcing a trailing
whitespace policy will ever have.
On Wednesday, February 21, 2018 at 1:21:36 PM UTC+1, John Cremona wrote:
>
> A simpler, similar example is with the l
A simpler, similar example is with the lmfdb (https://github.com/LMFDB/lmfdb)
where no pull request is merged unless pyflakes gives no errors or
warnings. I am not suggesting that Sage does the same, but there were
rather a lot of bugs discovered when we first started using pyflakes this
way!
Joh
On Wed, Feb 21, 2018 at 12:01 PM, Erik Bray wrote:
> On Wed, Feb 21, 2018 at 1:25 AM, Volker Braun wrote:
>> IMHO the evils of trailing whitespace are greatly exagerrated.
>>
>> The eaisest solution is to just fix your editor to not introduce changes
>> that you did not make yourself.
>>
>> If yo
On Wed, Feb 21, 2018 at 1:25 AM, Volker Braun wrote:
> IMHO the evils of trailing whitespace are greatly exagerrated.
>
> The eaisest solution is to just fix your editor to not introduce changes
> that you did not make yourself.
>
> If you think fighting the windmills of trailing whitespace is a w
IMHO the evils of trailing whitespace are greatly exagerrated.
The eaisest solution is to just fix your editor to not introduce changes
that you did not make yourself.
If you think fighting the windmills of trailing whitespace is a worthwhile
use of your time, be my guest. But I want a workflow
On 2018-02-20 14:16, Erik Bray wrote:
I'd be completely fine with that so long as no one complains about
otherwise irrelevant whitespace cleanup coming along for the ride in
my tickets.
To clarify, I'm fine with this too if it's not too much in one branch
(this is of course very subjective).
On Tue, Feb 20, 2018 at 1:58 PM, Travis Scrimshaw wrote:
>
>
> On Tuesday, February 20, 2018 at 5:04:26 AM UTC-6, Erik Bray wrote:
>>
>> How do we feel about large patches full of whitespace cleanup? Lots
>> of Sage modules have stray whitespace, and my editor usually
>> automatically removes it
On Tuesday, February 20, 2018 at 5:04:26 AM UTC-6, Erik Bray wrote:
>
> How do we feel about large patches full of whitespace cleanup? Lots
> of Sage modules have stray whitespace, and my editor usually
> automatically removes it when I open files (this is a personal
> preference that I have
On Tue, Feb 20, 2018 at 1:44 PM, John Cremona wrote:
> Would this help?
> https://stackoverflow.com/questions/9776527/merging-without-whitespace-conflicts
>
> In brief: git merge -Xignore-space-change
>
> There is also a reference there to a commit hook which removes trailing
> whitespace.
+1 F
Would this help?
https://stackoverflow.com/questions/9776527/merging-without-whitespace-conflicts
In brief: git merge -Xignore-space-change
There is also a reference there to a commit hook which removes trailing
whitespace.
On 20 February 2018 at 12:23, Vincent Delecroix <20100.delecr...@gmail
On 20/02/2018 12:45, Erik Bray wrote:
On Tue, Feb 20, 2018 at 12:22 PM, Daniel Krenn wrote:
On 2018-02-20 12:07, Simon King wrote:
Why not doing such cleanup right before releasing a beta version?
Or even better, right before a release, e.g. doing it for a rc0 or rc1.
That was my thinking
On Tue, Feb 20, 2018 at 12:22 PM, Daniel Krenn wrote:
> On 2018-02-20 12:07, Simon King wrote:
>> Why not doing such cleanup right before releasing a beta version?
>
> Or even better, right before a release, e.g. doing it for a rc0 or rc1.
That was my thinking as well--I'm sure Volker and I could
On 2018-02-20 12:07, Simon King wrote:
> Why not doing such cleanup right before releasing a beta version?
Or even better, right before a release, e.g. doing it for a rc0 or rc1.
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from
Why not doing such cleanup right before releasing a beta version?
On 2018-02-20, Erik Bray wrote:
> How do we feel about large patches full of whitespace cleanup? Lots
> of Sage modules have stray whitespace, and my editor usually
> automatically removes it when I open files (this is a personal
14 matches
Mail list logo
