On Wed, Feb 21, 2018 at 12:01 PM, Erik Bray <erik.m.b...@gmail.com> wrote: > On Wed, Feb 21, 2018 at 1:25 AM, Volker Braun <vbraun.n...@gmail.com> wrote: >> IMHO the evils of trailing whitespace are greatly exagerrated. >> >> The eaisest solution is to just fix your editor to not introduce changes >> that you did not make yourself. >> >> If you think fighting the windmills of trailing whitespace is a worthwhile >> use of your time, be my guest. But I want a workflow where I don't have to >> bother with trailing whitespace, so you better have git hooks to auto-fix >> everything on commit etc. > > I feel like I've worked on some projects before that implemented some > pretty strict client-side git commit hooks, where I couldn't even > commit a change unless it passed some linters (it was possible, and > sometimes even desirable, to get around this with `git commit -n` to > disable hooks). > > I've never set up something like that before though. I remember > several years ago you could include some pre-commit hooks in your > repository, but the user still had to *manually* enable them which > almost defeats the purpose (because many people won't bother). But I > think I've committed to some projects before where there were > pre-commit hooks that I never did anything to enable...
Oh, I remember what project I saw this in. It was WolfSSL. Turns out it's nothing fancy though--it just symlinks its pre-commit script to .git/hooks in the autogen.sh script. So technically you could get away with making a commit that doesn't get verified, but if you're doing any real development it stands to reason you would run autogen.sh first thing. I suppose Sage could do something similar... >> On Tuesday, February 20, 2018 at 12:04:26 PM UTC+1, Erik Bray wrote: >>> >>> How do we feel about large patches full of whitespace cleanup? Lots >>> of Sage modules have stray whitespace, and my editor usually >>> automatically removes it when I open files (this is a personal >>> preference that I have to live with though). >>> >>> Usually when preparing patches this means manually removing such >>> distracting whitespace cleanup, though all that means is then removing >>> it again, and again, and again... (or sometimes I will just leave it >>> in a commit if it's just one or two lines). >>> >>> It might be nice to just clean up a whole lot of this at once, but I >>> think that would require some coordination so as to not create too >>> many trivial merge conflicts... >>> >>> Thanks, >>> E >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+unsubscr...@googlegroups.com. >> To post to this group, send email to sage-devel@googlegroups.com. >> Visit this group at https://groups.google.com/group/sage-devel. >> For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
