Re: [sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jeroen Demeyer
On 2011-04-11 16:03, Jason Grout wrote: > Of course, temporarily the script could see if there was a ticket number > already starting the commit message, maybe a regular expression > something like (note: I haven't tested the following; it's likely that > I'm misremembering regexp syntax): > > ^([

[sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jason Grout
On 4/11/11 8:45 AM, Jeroen Demeyer wrote: On 2011-03-29 14:26, Jason Grout wrote: If the script automatically prepended: Trac #: to the start of every commit message, then: Done for sage-4.7.alpha5 Of course you get lots of silly commit messages like Trac #11141: #11141: add PolyGUI an

Re: [sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jeroen Demeyer
On 2011-03-29 14:26, Jason Grout wrote: > If the script automatically prepended: > > Trac #: > > to the start of every commit message, then: Done for sage-4.7.alpha5 Of course you get lots of silly commit messages like Trac #11141: #11141: add PolyGUI and cygdb to SAGE_LOCAL/bin/.hgignore

[sage-devel] Re: Patch submitting procedures

2011-04-04 Thread Keshav Kini
On Apr 4, 1:13 pm, William Stein wrote: > Great idea!  Post a ticket. This is now #11121 and awaits review :) -Keshav -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more option

[sage-devel] Re: Patch submitting procedures

2011-04-03 Thread Keshav Kini
On Apr 4, 3:23 am, William Stein wrote: > Could we change the default to "git = true" as a patch to the version > of hg we distribute with Sage?   Or, alternatively, have a patch that > prints a warning > whenever Sage's hg is used but git = false?   The second option would > be safer, since a use

Re: [sage-devel] Re: Patch submitting procedures

2011-04-03 Thread William Stein
On Sat, Apr 2, 2011 at 5:25 PM, Keshav Kini wrote: > Indeed. Mercurial's workflow is not really supposed to be carried out > by sending patches to people (the encouraged behavior is to use `hg > pull` from other people's repositories), so the default patch / export > format only includes a subset

[sage-devel] Re: Patch submitting procedures

2011-04-02 Thread Keshav Kini
Indeed. Mercurial's workflow is not really supposed to be carried out by sending patches to people (the encouraged behavior is to use `hg pull` from other people's repositories), so the default patch / export format only includes a subset of the total information so that it can be backwards compati

Re: [sage-devel] Re: Patch submitting procedures

2011-03-29 Thread David Roe
If the script automatically prepended: > > Trac #: > > to the start of every commit message, then: > > 1. the ticket number text would be uniform > > 2. if a wrong ticket number was indicated, it would be obvious which was > the correct ticket number, as it's always first in the standard forma

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jason Grout
On 3/29/11 6:58 AM, Jeroen Demeyer wrote: On 2011-03-29 13:15, Jason Grout wrote: On 3/28/11 4:36 AM, Jeroen Demeyer wrote: Also the correct(!) ticket number should appear on the first line of the commit message. Does the patch merging script not automatically do this? This is not the case.

Re: [sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jeroen Demeyer
On 2011-03-29 13:15, Jason Grout wrote: > On 3/28/11 4:36 AM, Jeroen Demeyer wrote: >> Also the correct(!) ticket >> number should appear on the first line of the commit message. > > Does the patch merging script not automatically do this? This is not the case. It would be possible to do this au

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jason Grout
On 3/28/11 4:36 AM, Jeroen Demeyer wrote: Also the correct(!) ticket number should appear on the first line of the commit message. Does the patch merging script not automatically do this? I thought at one time somebody added this. Again, the patch merging script already knows this, and if t

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread slabbe
> 1) When submitting a patch, make sure there is reasonable *commit > message* (use hg qrefresh -e to set the message). or hg qrefresh -m "#: Commit message" to do it from the command line. I think if one does hg qrefresh -e "#: Commit message" it erases the patch and replaces it by t