[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
On Sat, Apr 18, 2009 at 5:24 PM, mabshoff wrote: > > > > On Apr 18, 5:20 pm, William Stein wrote: >> On Sat, Apr 18, 2009 at 5:05 PM, Carl Witty wrote: >> >> > On Sat, Apr 18, 2009 at 2:46 PM, William Stein wrote: >> >> I posted a patch so that >> >> >> (1) doctests are ran in the same order a

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread Rob Beezer
On Apr 18, 5:24 pm, mabshoff wrote: > One thing that would be nice to see is that one should be able to run > the doctest N times with N something like 100 or even 1,000 for > example and each time a random seed would be picked. Then if any > failure occurred the doctesting framework should also

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread mabshoff
On Apr 18, 5:20 pm, William Stein wrote: > On Sat, Apr 18, 2009 at 5:05 PM, Carl Witty wrote: > > > On Sat, Apr 18, 2009 at 2:46 PM, William Stein wrote: > >> I posted a patch so that > > >> (1) doctests are ran in the same order as the file > >> (2) doctests can be run in random order > >> (

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
On Sat, Apr 18, 2009 at 5:19 PM, Rob Beezer wrote: > > On Apr 18, 5:05 pm, Carl Witty wrote: >> OK, what should happen now?  I like the patch (except for the name of >> the command-line argument); but it can't be applied because it makes >> doctests fail. > > I'd suggest the randomized order sho

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
On Sat, Apr 18, 2009 at 5:05 PM, Carl Witty wrote: > > On Sat, Apr 18, 2009 at 2:46 PM, William Stein wrote: >> I posted a patch so that >> >> (1) doctests are ran in the same order as the file >> (2) doctests can be run in random order >> (3) doctests can be run in random order specified by a s

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread Rob Beezer
On Apr 18, 5:05 pm, Carl Witty wrote: > OK, what should happen now?  I like the patch (except for the name of > the command-line argument); but it can't be applied because it makes > doctests fail. I'd suggest the randomized order should be made available as soon as possible. It requires a posi

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread mabshoff
On Apr 18, 5:05 pm, Carl Witty wrote: > On Sat, Apr 18, 2009 at 2:46 PM, William Stein wrote: > > I posted a patch so that > > > (1) doctests are ran in the same order as the file > > (2) doctests can be run in random order > > (3) doctests can be run in random order specified by a seed > > >

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread Carl Witty
On Sat, Apr 18, 2009 at 2:46 PM, William Stein wrote: > I posted a patch so that > > (1) doctests are ran in the same order as the file > (2) doctests can be run in random order > (3) doctests can be run in random order specified by a seed > > Carl, maybe you can referee it: > >  http://trac.sage

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
>> >> Where's the patch? >> >>  John >> > > Oops.  I've posted it now. > > William > It's very interesting to run on the full rc3 tree with a fixed random seed. I think this reveals *numerous* errors and subtle problems: ./sage -tp 20 -long -rand=1 devel/sage/sage/ > testlong-rand1.log& This

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
On Sat, Apr 18, 2009 at 3:27 PM, John H Palmieri wrote: > > On Apr 18, 2:46 pm, William Stein wrote: >> On Sat, Apr 18, 2009 at 2:00 PM, Rob Beezer wrote: >> >> > Hi Carl, >> >> > Thanks for the explanation - good to know just why this was >> > happening.  I'd noticed the tests being run in a d

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread John H Palmieri
On Apr 18, 2:46 pm, William Stein wrote: > On Sat, Apr 18, 2009 at 2:00 PM, Rob Beezer wrote: > > > Hi Carl, > > > Thanks for the explanation - good to know just why this was > > happening.  I'd noticed the tests being run in a different order as I > > tried to debug this, but hadn't dug deep en

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread William Stein
On Sat, Apr 18, 2009 at 2:00 PM, Rob Beezer wrote: > > Hi Carl, > > Thanks for the explanation - good to know just why this was > happening.  I'd noticed the tests being run in a different order as I > tried to debug this, but hadn't dug deep enough to discover the cause. > > In misc/latex.py how

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread Rob Beezer
Hi Carl, Thanks for the explanation - good to know just why this was happening. I'd noticed the tests being run in a different order as I tried to debug this, but hadn't dug deep enough to discover the cause. In misc/latex.py how the latex is created often depends on the value of the boolean EM

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-18 Thread Carl Witty
On Tue, Apr 14, 2009 at 11:57 AM, John H Palmieri wrote: > I figured out how to fix the problem, although I still don't know why > adding a docstring should cause it. > > To fix it: the docstring for "print_or_typeset" contains the lines ... Well, I can tell you why adding a docstring will cause

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-16 Thread John H Palmieri
On Apr 16, 10:00 pm, Rob Beezer wrote: > Hi John, > > Thanks for the fix!  That behavior was driving me crazy.  ;-)  I've > been away for a few days, so I'm sorry I didn't reply to your other > messages as you diagnosed this. > > I'll get back to this soon and I'll keep an eye out for any > expla

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-16 Thread Rob Beezer
Hi John, Thanks for the fix! That behavior was driving me crazy. ;-) I've been away for a few days, so I'm sorry I didn't reply to your other messages as you diagnosed this. I'll get back to this soon and I'll keep an eye out for any explanations, in addition to looking at #5610. I've only w

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-14 Thread John H Palmieri
On Apr 11, 5:57 pm, Rob Beezer wrote: > I've been adding documentation to sage/misc/latex.py and discovered > that if I add a trivial docstring (empty, one-line, other variants of > trivial) to the first function in the file  (which is  "have_dvipng") > then a test run on that file really goes ha

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-12 Thread John H Palmieri
On Apr 12, 8:47 am, John H Palmieri wrote: > On Apr 11, 6:34 pm, Rob Beezer wrote: > > > > > > > On Apr 11, 5:59 pm, William Stein wrote: > > > > You could post your file. > > > Its at  http://buzzard.ups.edu/private/latex.py > > > This is the fubared version of sage/misc/latex.py (which I am i

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-12 Thread John H Palmieri
On Apr 11, 6:34 pm, Rob Beezer wrote: > On Apr 11, 5:59 pm, William Stein wrote: > > > You could post your file. > > Its at  http://buzzard.ups.edu/private/latex.py > > This is the fubared version of sage/misc/latex.py (which I am in the > middle of working on).  It contains one doctest that I'v

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-11 Thread Rob Beezer
On Apr 11, 5:59 pm, William Stein wrote: > You could post your file. Its at http://buzzard.ups.edu/private/latex.py This is the fubared version of sage/misc/latex.py (which I am in the middle of working on). It contains one doctest that I've edited heavily, so some changes seem to be allowed

[sage-devel] Re: Adding a trivial docstring confuses testing

2009-04-11 Thread William Stein
On Sat, Apr 11, 2009 at 5:57 PM, Rob Beezer wrote: > > I've been adding documentation to sage/misc/latex.py and discovered > that if I add a trivial docstring (empty, one-line, other variants of > trivial) to the first function in the file  (which is  "have_dvipng") > then a test run on that file