On Sat, Apr 18, 2009 at 5:24 PM, mabshoff <mabsh...@googlemail.com> wrote: > > > > On Apr 18, 5:20 pm, William Stein <wst...@gmail.com> wrote: >> On Sat, Apr 18, 2009 at 5:05 PM, Carl Witty <carl.wi...@gmail.com> wrote: >> >> > On Sat, Apr 18, 2009 at 2:46 PM, William Stein <wst...@gmail.com> wrote: >> >> I posted a patch so that >> >> >> (1) doctests are ran in the same order as the file >> >> (2) doctests can be run in random order >> >> (3) doctests can be run in random order specified by a seed >> >> >> Carl, maybe you can referee it: >> >> >> http://trac.sagemath.org/sage_trac/ticket/5816 >> >> > OK, what should happen now? I like the patch (except for the name of >> > the command-line argument); but it can't be applied because it makes >> > doctests fail. >> >> > As far as I can tell, there are two options: >> >> > 1) go through and fix all the broken doctests, and add new patches to >> > #5816 for all of them >> >> I found a bug in the patch -- it was always running things in random >> order. We will of course have to do 1) above eventually, since we >> really want all tests to pass in any order. >> >> > 2) leave out the zero-padding from this patch, so that the default >> > doctest order doesn't change. Then once all the broken doctests are >> > eventually fixed, the zero-padding can be reinstated. >> >> I just posted a part 2 to the patch that does exactly that. I think >> this should go in sage-3.4.1, since once it is there, it will be >> trivial for people to run the randomized tests in any order (with any >> seed) once sage-3.4.1 is released, and this will make it much easier >> for people to fix all the bugs mentioned in 1 above. > > Well, if traditional order is restored I for merging it.
I rewrote the patch and restored "traditional order". > > One thing that would be nice to see is that one should be able to run > the doctest N times with N something like 100 or even 1,000 for > example and each time a random seed would be picked. Then if any > failure occurred the doctesting framework should also print the random > see that was used. That way one could flush out issues on a file by > file basis. That's a good idea. William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---