Re: [sage-devel] Re: Adèles and idèles

2021-09-15 Thread Mathe Hertogh
Hi all, Let me give an update on the adèles/idèles project. The project viewed as my Master's thesis project at Leiden University is completely finished: the thesis is final and it (together with the software package) has been given a high grade. As far as I know the software package is also f

Re: [sage-devel] Re: Adèles and idèles

2021-09-15 Thread Mathe Hertogh
Hi all, Let me give an update on the adèles/idèles project. The project viewed as my Master's thesis project at Leiden University is completely finished: the thesis is final and it (together with the software package) has been given a high grade. As far as I know the software package is also f

Re: [sage-devel] Re: Adèles and idèles

2021-09-11 Thread Vincent Delecroix
And also, list it on the page https://wiki.sagemath.org/SageMathExternalPackages Le 27/08/2021 à 04:07, Matthias Koeppe a écrit : I took a quick look at the packaging metadata of your package. It all looks great, but in setup.cfg you will want to make a change to the "install_requires", whic

[sage-devel] Re: Adèles and idèles

2021-09-10 Thread Peter Bruin
Dear Mathé, >From what I've seen, this is very high quality code, and in my opinion Part 1 is certainly useful enough to be included into SageMath. As other people have already mentioned, there are two possibilities: 1) try to get the code for adèles and idèles into SageMath itself; 2) continue

Re: [sage-devel] Re: Adèles and idèles

2021-08-26 Thread Matthias Koeppe
I took a quick look at the packaging metadata of your package. It all looks great, but in setup.cfg you will want to make a change to the "install_requires", which currently say "sage >= 9.2". As of Sage 9.4, there is no longer a distribution package called "sage". Instead we have "sagemath-sta

Re: [sage-devel] Re: Adèles and idèles

2021-08-26 Thread 'Travis Scrimshaw' via sage-devel
One additional point about including it into Sage (as a sort of counterpoint to Nils' point about discoverability). If it is included, then it will be documented within Sage, which means it will be very likely to appear at the top of Google searches for "SageMath adéles" and we do not (currentl

Re: [sage-devel] Re: Adèles and idèles

2021-08-20 Thread Mathe Hertogh
Dear Tomer, Thank you for the tips and advice. I will definitely (try to) do both! Regards, Mathé On Thu, 19 Aug 2021 at 22:06, TB wrote: > Dear Mathé, > > From a quick skim of https://github.com/mathehertogh/adeles it looks very > impressive. I do not know if it is better to incorporate the c

Re: [sage-devel] Re: Adèles and idèles

2021-08-19 Thread TB
Dear Mathé, From a quick skim of https://github.com/mathehertogh/adeles it looks very impressive. I do not know if it is better to incorporate the code into Sage or leave it as a stand-alone package, but in case the code does live in its own reposito

Re: [sage-devel] Re: Adèles and idèles

2021-08-18 Thread Mathe Hertogh
Dear Nils and others, I would put my contribution in category B: creating infrastructure for computing with adèles and idèles. Currently completions of number fields at finite primes are not yet implemented in sagemath and hence the bundling of such computations into an adèle ring is not possible

[sage-devel] Re: Adèles and idèles

2021-08-14 Thread Nils Bruin
Dear Mathé, Congratulations on almost finishing your thesis. I trust it will just take a short stretch of time until you succeed in fully finishing your thesis (code from an unfinished thesis would be a bit of a red flag). I'll give a bit of a general view of what the pros and cons of includin