Dear Mathé, >From what I've seen, this is very high quality code, and in my opinion Part 1 is certainly useful enough to be included into SageMath. As other people have already mentioned, there are two possibilities: 1) try to get the code for adèles and idèles into SageMath itself; 2) continue maintaining it as an individual package and make it as easy as possible to install (which probably means via pip).
The thing that makes it slightly harder to decide which is better is the current effort to "modularise" the SageMath library, see <https://trac.sagemath.org/ticket/29705>. The goal is to break the library up into several (pip-installable) packages, but to keep the existing SageMath source tree. On the one hand, this is no obstacle to including the package (at least for Part 1) in the main SageMath source; on the other hand, if SageMath will become piecewise pip-installable in the future, then presumably people will also become more used to install packages (like yours) via pip. I guess it is up to you, as the author, to choose whether to go for 1) or 2). Best wishes, Peter Op vrijdag 13 augustus 2021 om 12:07:25 UTC+2 schreef m.c.h...@gmail.com: > Hello everyone, > > As a master's mathematics student I (allmost) finished my thesis, for > which I implemented adèles and idèles in SageMath. I have written the code > with the aim of including it into SageMath. It is well documented, > following the SageMath guidelines, and personally I think the package fits > well into SageMath. > > The package can be found at GitHub: https://github.com/mathehertogh/adeles > . > You can find all information on it there (as well as the thesis which it > is based on). > Installing should be easy (if not: let me know!). I invite anyone > interested to do this and discover the functionality by reading the > documentation and experiment with the code in SageMath. > > The README file and documentation index explain the four parts the package > consists of: > Part 1 - Implementation of adèles and idèles > Part 2 - Profinite functions and graphs > Part 3 - Adèlic matrix factorization > Part 4 - Hilbert class field computations > > I would suggest to include Part 1 into SageMath. Moreover I think Part 2 > would be nice to include into SageMath as well. Parts 3 and 4 are very > specialized and probably do not belong into the SageMath standard library > (but if you disagree: let me know). > > My main two questions for you are: > 1. Do you agree on adding Part 1 to SageMath? (assuming the code is good) > 2. Do you think adding Part 2 is a good idea? (assuming the code is good) > > Given at least one affirmative answer, the code should be uploaded to trac > and reviewed. As it is quite some code, my plan would be to create a > separate trac-ticket for each file of Part(s) 1 and/or 2. So one file would > be reviewed per trac-ticket. Do you think this is a good idea? > > This would require (I think) trac-tickets that depend on each other. I see > a "dependencies" field when creating a new trac-ticket, so I guess this is > possible. Any advice, tips or references on this would be appreciated. Also > any suggestions regarding the inclusion of my code into SageMath in general > would be much appreciated: this is my first contribution. > > I am very interested in what you all have to say about this project and > the questions asked above. > > Kind regards, > Mathé Hertogh > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/bd17d897-b45c-491e-b669-31b03d936823n%40googlegroups.com.