2009/3/18 Ryan Hinton :
>
> The is_primitive issues is now described in trac #5561. Owners are welcome!
And I have rebased (and slightly improved) #5140, so reviewers are
welcome there too. [Ryan, we do not bother too much about ownership
of tickets, but reviewers are crucial. I hope to review
The is_primitive issues is now described in trac #5561. Owners are welcome!
John Cremona wrote:
> I hope I did not offend anyone, least of all someone who had provided
> a patch which makes a useful efficiency improvement! But as Martin
> invited all sage-devel to look at that code, I did!
>
>
Very good. Thank you for taking a look at the code -- and no offense
taken: I just didn't know what to do next!
I will leave the is_irreducible() bug/definition for #5140 and create a
new ticket for is_primitive including the comments from John and
C.Witty. I'll leave it unassigned for now.
PS I found that #5140 already addresses related issues, and contains a
patch by me for the is_irreducible() bug. the patch needs review, and
that explains why (1) I remembered already fixing it and (2) why it is
not fixed.
I will rebase that patch to 3.4 and then invite reviewers.
John
2009/3/
I hope I did not offend anyone, least of all someone who had provided
a patch which makes a useful efficiency improvement! But as Martin
invited all sage-devel to look at that code, I did!
I'll be happy to provide a patch for the bug in is_irreducible for
rational polys. (I call it a bug, thoug
Unfortunately, I don't know what on earth is_primitive() is doing there.
I didn't put it there. I wrote the patch to as a performance
enhancement to the _existing_ is_primitive implementation. is_primitive
was there already, so the current ticket is probably not the best place
to discuss
What on earth is that function is_primitive() doing there? If you
asked me to define what it means for a univariate polynomial over a
ring to be primitive then I would say that it means that the
coefficients generate the unit ideal.
The function there seems to be a different concept only relevan
