What on earth is that function is_primitive() doing there?  If you
asked me to define what it means for a univariate polynomial over a
ring to be primitive then I would say that it means that the
coefficients generate the unit ideal.

The function there seems to be a different concept only relevant for
polynomials over finite fields.   So why is it in class Polynomial?

It gets worse:

sage: R.<x> = QQ[]
sage: f=3*x^2-6
sage: f.is_irreducible()
False

This is WRONG.  I thought I fixed that months ago, but here it is
again.  The implementation

    def is_irreducible(self):
        S = PolynomialRing(ZZ, self.variable_name())
        return S(self.denominator()*self).is_irreducible()

would fail any first year undergraduate exam I was responsible for.

John

2009/3/16 Martin Albrecht <m...@informatik.uni-bremen.de>:
>
> Hi there,
>
>  http://trac.sagemath.org/sage_trac/ticket/5535
>
> adds a neat way of shooting yourself in the foot in the name of performance,
> so I wonder if anyone has any hard feelings about that? I suggested to
> include this in Sage (Ryan had a local version for his application), so I
> think it is worth it.
>
> Thoughts?
> Martin
> --
> name: Martin Albrecht
> _pgp: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x8EF0DC99
> _otr: 47F43D1A 5D68C36F 468BAEBA 640E8856 D7951CCF
> _www: http://www.informatik.uni-bremen.de/~malb
> _jab: martinralbre...@jabber.ccc.de
>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---

Reply via email to