See https://github.com/sagemath/sage/pull/35172 – a GH Actions workflow by
Sebastian Oehms
On Saturday, February 25, 2023 at 1:06:04 PM UTC-8 Trevor Karn wrote:
> Ok so my takeaway is that for now at least we treat all PRs that are
> untagged as needs review. Is there a way to set as a default
On Sat, Feb 25, 2023 at 9:06 PM Trevor Karn wrote:
>
> Ok so my takeaway is that for now at least we treat all PRs that are untagged
> as needs review. Is there a way to set as a default or get a bot to
> automatically apply just the needs review label to any new PR?
Any - that is not marked a
Ok so my takeaway is that for now at least we treat all PRs that are
untagged as needs review. Is there a way to set as a default or get a bot
to automatically apply just the needs review label to any new PR?
On Sat, Feb 25, 2023 at 2:20 PM Matthias Koeppe
wrote:
> Re the "needs review" tag, see
Re the "needs review" tag, see earlier discussion
in https://github.com/sagemath/trac-to-github/issues/8#issuecomment-1367744734
On Saturday, February 25, 2023 at 11:48:08 AM UTC-8 Vincent Delecroix wrote:
> I think that the needs_review positive_review tags do not fit well in
> the github work
I think that the needs_review positive_review tags do not fit well in
the github workflow. These have been kept to mimic the trac workflow
but are annoying. I support Edgar suggestion that the "needs review
tag" should be replaced by "not a draft" status. Similarly, the
"positive review tag" would
Most likely not the status quo at the moment, but if a PR is not ready to
be reviewed should be marked as a draft, which the author can do without
any special permissions.
Otherwise, I would assume the PR is ready to be reviewed.
On Fri, Feb 24, 2023 at 9:43 PM Trevor Karn wrote:
> How do new de
I think it is a great idea. Even if the system python is older than one
needed, one can still use e.g. pyenv to get an up to date python, without
the need to build your own.
And pyenv does allow us to drop python3 spkg,
something we should do, too.
Dima
On Sat, 25 Feb 2023, 07:16 Matthias Koeppe
