I think that the needs_review positive_review tags do not fit well in the github workflow. These have been kept to mimic the trac workflow but are annoying. I support Edgar suggestion that the "needs review tag" should be replaced by "not a draft" status. Similarly, the "positive review tag" would better be replaced by something like "approved by a developer".
On Sat, 25 Feb 2023 at 20:38, Edgar Costa <[email protected]> wrote: > > Most likely not the status quo at the moment, but if a PR is not ready to be > reviewed should be marked as a draft, which the author can do without any > special permissions. > Otherwise, I would assume the PR is ready to be reviewed. > > On Fri, Feb 24, 2023 at 9:43 PM Trevor Karn <[email protected]> wrote: >> >> How do new developers tag their PR as "needs review" without having triage >> access? >> >> On Thursday, February 23, 2023 at 1:37:07 AM UTC-6 David Roe wrote: >>> >>> As a first proposal: once you have a PR accepted then you're added to the >>> sagemath organization. I'm not sure exactly what the cutoff should be for >>> being added to triage (which gives the capability of changing labels, >>> closing and assigning issues and PRs, requesting PR reviews, applying >>> milestones and marking as duplicate. I'm fine with giving these >>> permissions to people after their first PR is merged, but some might argue >>> for more of a history with contributors. >>> >>> Julian and I had talked about writing a bot to handle these permissions, >>> but haven't gotten around to it yet. >>> David >>> >>> On Thu, Feb 23, 2023 at 5:33 AM Kwankyu Lee <[email protected]> wrote: >>>> >>>> Hi, >>>> >>>> We are getting PRs from non-member contributors. >>>> >>>> What is the procedure or the condition to be invited for membership? >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "sage-devel" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/sage-devel/9eae5420-6b43-440e-b36d-d30c3b23421bn%40googlegroups.com. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-devel/1ee1ac47-44bb-4c0d-a8df-132fc4cdc86an%40googlegroups.com. > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CA%2BiQ7x7fGhOaaHwy3DEyfC%3DomQYV1c8JWCkanEcCRUdo7bFCHw%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAGEwAAmV%3DSuknLWzjkKTKyihS2exrrd-87vsMKrFChD5N7W4oQ%40mail.gmail.com.
