Re: [sage-devel] tabs in the Sage library

2010-04-15 Thread Minh Nguyen
Hi William, On Thu, Apr 15, 2010 at 10:02 PM, William Stein wrote: > That is another issue. It doesn't cause any trouble in python, so it > doesn't concern me. I have an Emacs keyboard shortcut that removes all trailing white spaces in a file. When I started out with Python programming, I wr

Re: [sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Florent Hivert
Hi there, > I think we should do this once, after a tool is in place to make sure these > things don't get in anymore. > > A big +1 to sage -t failing on files that have tabs, lack newlines, or > whatever else the style guide enforces. I've also thought it would be > useful to have a trac pl

Re: [sage-devel] blocker? ''' vs. """

2010-04-15 Thread William Stein
On Thursday, April 15, 2010, John H Palmieri wrote: > In a patch for the the Sage library (trac #7889), a file used triple > single quotes (''') rather than triple double quotes (""").  As a > result, > >  - sage -coverage reported 0 coverage for that file, and >  - no doctests were run on the exa

[sage-devel] blocker? ''' vs. """

2010-04-15 Thread John H Palmieri
In a patch for the the Sage library (trac #7889), a file used triple single quotes (''') rather than triple double quotes ("""). As a result, - sage -coverage reported 0 coverage for that file, and - no doctests were run on the examples in the docstrings! Our coverage scripts and doctesting sc

[sage-devel] Re: tabs in the Sage library

2010-04-15 Thread John H Palmieri
On Apr 15, 2:48 pm, "Nathan O'Treally" wrote: > I'm not happy with "brute-force" converting *any* tab to space(s), and > it would be better to have a tool that (conditionally) does this > rather than supplying patches to lots of files converted by Emacs. The > same tool could be used just to check

Re: [sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Robert Bradshaw
On Apr 15, 2010, at 2:48 PM, Nathan O'Treally wrote: I'm not happy with "brute-force" converting *any* tab to space(s), and it would be better to have a tool that (conditionally) does this rather than supplying patches to lots of files converted by Emacs. The same tool could be used just to chec

Re: [sage-devel] tabs in the Sage library

2010-04-15 Thread William Stein
On Thursday, April 15, 2010, Nathan O'Treally wrote: > I'm not happy with "brute-force" converting *any* tab to space(s), and Why? Is there a single place in all sage that should use a tab in the source code? Please clarify? > it would be better to have a tool that (conditionally) does this >

[sage-devel] Re: tabs in the Sage library

2010-04-15 Thread Nathan O'Treally
I'm not happy with "brute-force" converting *any* tab to space(s), and it would be better to have a tool that (conditionally) does this rather than supplying patches to lots of files converted by Emacs. The same tool could be used just to check for "illegal" tabs. As I understand this, these are *t

[sage-devel] culling down doctest failure logs

2010-04-15 Thread Jason Grout
Often when a doctest fails, it causes a cascade of failures (with lots of NameErrors), which obscure the true issues. Also, many times the same error is hit repeatedly. Here's a stab at a small parsing script that parses the ptestlong.log file and tries to get unique errors that are not NameE

Re: [sage-devel] Re: Build did not work 4.3.5 Ubuntu 9.10 (atlas-3.8.3.p12)

2010-04-15 Thread Robert Bradshaw
On Apr 15, 2010, at 9:28 AM, Bruce Cohen wrote: I now remember that I did have a 5 hour scp file transfer running that night. It is a brand new machine, so I was bringing over a tar file from an old machine on my network. I will try again tonight. It is disappointing that that the new quad co

Re: [sage-devel] Re: Build did not work 4.3.5 Ubuntu 9.10 (atlas-3.8.3.p12)

2010-04-15 Thread William Stein
On Thu, Apr 15, 2010 at 9:37 AM, John Cremona wrote: > Atlas is supposed to find out what sort of processor your machine has > automatically and then use tuning data for that.  But it is not > perfect at detecting the processor type, so then it goess of to do > this tuning stuff which takes hours.

Re: [sage-devel] Re: Build did not work 4.3.5 Ubuntu 9.10 (atlas-3.8.3.p12)

2010-04-15 Thread John Cremona
Atlas is supposed to find out what sort of processor your machine has automatically and then use tuning data for that. But it is not perfect at detecting the processor type, so then it goess of to do this tuning stuff which takes hours. The same happened to me when I got a new laptop in 2008. Un

[sage-devel] Re: Build did not work 4.3.5 Ubuntu 9.10 (atlas-3.8.3.p12)

2010-04-15 Thread Bruce Cohen
I now remember that I did have a 5 hour scp file transfer running that night. It is a brand new machine, so I was bringing over a tar file from an old machine on my network. I will try again tonight. It is disappointing that that the new quad core i7 (purchased to do Sage work) could not handle

[sage-devel] Re: Build did not work 4.3.5 Ubuntu 9.10 (atlas-3.8.3.p12)

2010-04-15 Thread Bruce Cohen
The job ran overnight and nothing else was going on. Perhaps I should try again tonight. -Bruce On Apr 14, 11:18 pm, Robert Bradshaw wrote: > On Apr 14, 2010, at 11:12 PM, Bruce Cohen wrote: > > > I have a new machine with Ubuntu 9.10 (32 bit).   My first build of > > Sage (4.3.5) did not work

[sage-devel] Re: code review tools

2010-04-15 Thread kcrisman
On Apr 14, 4:21 pm, Jason Grout wrote: > On 04/14/2010 03:04 PM, William Stein wrote: > > > > > On Wed, Apr 14, 2010 at 12:43 PM, John Cremona   > > wrote: > >> I have been strongly encouraging new students starting out with Sage > >> to make small (initially) patches  on their very own ticket,

[sage-devel] Re: Problem with Maxima interface?

2010-04-15 Thread Nathan Dunfield
> I can confirm that the above function eventually desynchronizes Maxima; > I'm using Sage 4.3.5 with Ubuntu 9.10 on a quad-core Core 2 processor. One more date point: I reproduced the problem on my Mac Book, which has a dual-core Core 2. Despite the fact that it's a lot slower than my Mac Pro, i

[sage-devel] Re: code review tools

2010-04-15 Thread slabbe
> Yes.  The main intent of what I'm suggesting is that people who are > contributing a *lot* of code, but not doing any reviewing, will be > very, very strongly encouraged to do more reviewing. If this is the main intent, then I would suggest something different than a system that may lead to misi

[sage-devel] Re: code review tools

2010-04-15 Thread slabbe
> Yes.  The main intent of what I'm suggesting is that people who are > contributing a *lot* of code, but not doing any reviewing, will be > very, very strongly encouraged to do more reviewing. If this is the main intent, then I would suggest something different than a system that may lead to misi