Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2008-01-14 Thread Ming Zhang
Hi Matt No news is good news, so far Q&A and I have never seen crash again. Thanks a lot for the fix! Ming On Mon, 2008-01-14 at 17:12 -0500, Matt McCutchen wrote: > On Fri, 2007-12-14 at 13:34 -0500, Ming Zhang wrote: > > sorry but seems it still crashes somehow. > > > > global dir_count is

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2008-01-14 Thread Ming Zhang
ps, not sure if you saw the half open socket issue i reported last month? will you fix it or leave it there? Ming On Mon, 2008-01-14 at 17:12 -0500, Matt McCutchen wrote: > On Fri, 2007-12-14 at 13:34 -0500, Ming Zhang wrote: > > sorry but seems it still crashes somehow. > > > > global dir_co

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2008-01-14 Thread Matt McCutchen
On Fri, 2007-12-14 at 13:34 -0500, Ming Zhang wrote: > sorry but seems it still crashes somehow. > > global dir_count is 23. > > (gdb) bt > #0 0x0040544a in add_dirs_to_tree (parent_ndx=10, > from_flist=0x57c5d0, dir_cnt=4) at flist.c:1423 > #1 0x004090ef in send_extra_file_list

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2007-12-14 Thread Ming Zhang
sorry but seems it still crashes somehow. global dir_count is 23. (gdb) bt #0 0x0040544a in add_dirs_to_tree (parent_ndx=10, from_flist=0x57c5d0, dir_cnt=4) at flist.c:1423 #1 0x004090ef in send_extra_file_list (f=17, at_least=1000) at flist.c:1729 #2 0x004122f3 in send

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2007-12-14 Thread Ming Zhang
fyi, i check the core dump again, you are 100% right, the global dir_count was 3. Ming On Thu, 2007-12-13 at 07:06 -0800, Wayne Davison wrote: > On Wed, Dec 12, 2007 at 09:44:47PM -0500, Ming Zhang wrote: > > from the mode, it looks that both of them are directories, so S_ISDIR() > > should be 1

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2007-12-13 Thread Ming Zhang
On Thu, 2007-12-13 at 07:06 -0800, Wayne Davison wrote: > On Wed, Dec 12, 2007 at 09:44:47PM -0500, Ming Zhang wrote: > > from the mode, it looks that both of them are directories, so S_ISDIR() > > should be 1 and thus "dir_cnt--" should get executed, but later show > > dir_cnt is still 1. > > I w

Re: rsync 3.00pre6 segfault in add_dirs_to_tree

2007-12-13 Thread Wayne Davison
On Wed, Dec 12, 2007 at 09:44:47PM -0500, Ming Zhang wrote: > from the mode, it looks that both of them are directories, so S_ISDIR() > should be 1 and thus "dir_cnt--" should get executed, but later show > dir_cnt is still 1. I wonder if dir_cnt was 3 when there was only 2 dir entries? I see a w

rsync 3.00pre6 segfault in add_dirs_to_tree

2007-12-12 Thread Ming Zhang
Hi All I run rsync in an automated environment and it sometime will crash and leave a core dump file. from core dump, gdb shows that gdb) bt #0 add_dirs_to_tree (parent_ndx=-1, from_flist=0x56c590, dir_cnt=1) at flist.c:1422 #1 0x00409eab in send_file_list (f=16, argc=-1, argv=0x56c238)