Re: patch: typo's and gcc warnings

2003-03-20 Thread jw schultz
On Wed, Mar 12, 2003 at 02:58:43PM +0100, Paul Slootman wrote: > On Wed 12 Mar 2003, jw schultz wrote: > > > > I've attached a patch that creates a uint64 for INO64_t and > > DEV64_T and it fixes all the signed-unsigned comparison > > warnings. > > Sure, but that went a bit too far for me at this

Re: patch: typo's and gcc warnings

2003-03-12 Thread jw schultz
On Wed, Mar 12, 2003 at 02:58:43PM +0100, Paul Slootman wrote: > On Wed 12 Mar 2003, jw schultz wrote: > > > > I've attached a patch that creates a uint64 for INO64_t and > > DEV64_T and it fixes all the signed-unsigned comparison > > warnings. > > Sure, but that went a bit too far for me at this

Re: patch: typo's and gcc warnings

2003-03-12 Thread Paul Slootman
On Wed 12 Mar 2003, jw schultz wrote: > > I've attached a patch that creates a uint64 for INO64_t and > DEV64_T and it fixes all the signed-unsigned comparison > warnings. Sure, but that went a bit too far for me at this time. Your patch looks fine. > I've also attached a patch for Makefile.in s

Re: patch: typo's and gcc warnings

2003-03-12 Thread jw schultz
On Wed, Mar 12, 2003 at 01:34:58PM +0100, Paul Slootman wrote: > Two patches: > one to correct the spelling of permissions (in comments, but such typos > disturb me as well), and OK. I can't speel but but spelling errors impede clarity. > one to cast inode and dev to unsigned long before compari

patch: typo's and gcc warnings

2003-03-12 Thread Paul Slootman
Two patches: one to correct the spelling of permissions (in comments, but such typos disturb me as well), and one to cast inode and dev to unsigned long before comparing, to prevent gcc giving a warning "comparison between signed and unsigned". Paul Slootman diff -ru orig/rsync-2.5.6/generator.c