Re: Fix for batch mode (was Re: batch mode maintainability)

2002-02-01 Thread Jos Backus
On Fri, Feb 01, 2002 at 02:59:50PM -0600, Dave Dykstra wrote: > I'm not familiar with that area of the code, but I assume it would be > straightforward. Good to hear that :) > Another idea just occurred to me: it would be nice to be able to stream all > the batch files over the network rather t

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-02-01 Thread Dave Dykstra
On Fri, Feb 01, 2002 at 11:23:33AM -0800, Jos Backus wrote: > Thanks Dave for your comments, I have incorporated your feedback in the patch > below. Please review. > > On Fri, Feb 01, 2002 at 09:49:07AM -0600, Dave Dykstra wrote: > > Hmm, I wonder if it would be easy to use rsync's compression l

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-02-01 Thread Jos Backus
Thanks Dave for your comments, I have incorporated your feedback in the patch below. Please review. On Fri, Feb 01, 2002 at 09:49:07AM -0600, Dave Dykstra wrote: > Hmm, I wonder if it would be easy to use rsync's compression library to > compress the whole flist, csum, and delta files on the fly

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-02-01 Thread Dave Dykstra
On Thu, Jan 31, 2002 at 02:42:47PM -0801, Jos Backus wrote: ... > +Batch mode can be used to apply the same set of updates to many identical > +systems\&. Suppose one has a directory tree which is replicated on a number of > +hosts\&. Now suppose some changes have to be made to this source direct

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-31 Thread Jos Backus
Thanks to Alberto Accomazzi and Dave Dykstra for their comments. Please have a look at the updated version below. On Thu, Jan 31, 2002 at 11:28:46AM -0600, Dave Dykstra wrote: > Refer people to the BATCH MODE section for more details. Done. > The opening description should be easily understanda

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-31 Thread Dave Dykstra
On Wed, Jan 30, 2002 at 05:53:04PM -0800, Jos Backus wrote: > On Thu, Jan 24, 2002 at 06:19:56PM -0801, Jos Backus wrote: > > OK, I may need help with the markup part though, so I'll post a rough draft > > here first. > > Here's my first attempt at improving the documentation of the batch mode >

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-30 Thread Jos Backus
On Thu, Jan 24, 2002 at 06:19:56PM -0801, Jos Backus wrote: > OK, I may need help with the markup part though, so I'll post a rough draft > here first. Here's my first attempt at improving the documentation of the batch mode feature. This is the manpage only; I'll attempt to update the yodl file

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-30 Thread Jos Backus
On Wed, Jan 30, 2002 at 02:56:25PM -0600, Dave Dykstra wrote: > It should do more, it should block -z from being used with --write-batch. Or read-batch, for that matter. The second if () handles this situation: Index: options.c ===

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-30 Thread Dave Dykstra
On Wed, Jan 30, 2002 at 10:52:17AM -0800, Jos Backus wrote: > On Wed, Jan 30, 2002 at 09:07:04AM -0600, Dave Dykstra wrote: > > It isn't clear to me that the -z option makes sense for batch mode anyway. > > Perhaps turning the rsync_* files into a gzipped tarball before sending > > them to the rem

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-30 Thread Jos Backus
On Wed, Jan 30, 2002 at 09:07:04AM -0600, Dave Dykstra wrote: > It isn't clear to me that the -z option makes sense for batch mode anyway. > Perhaps turning the rsync_* files into a gzipped tarball before sending > them to the remote machines would have better compression. I guess some > measurem

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-30 Thread Dave Dykstra
I'm sorry, but I don't have any familiarity with that part of rsync code and don't have any ideas for you. It isn't clear to me that the -z option makes sense for batch mode anyway. Perhaps turning the rsync_* files into a gzipped tarball before sending them to the remote machines would have bett

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-29 Thread Jos Backus
On Sat, Jan 26, 2002 at 12:02:31AM -0800, Jos Backus wrote: > However, when I add ``-z'', rsync does fail when using a different target > directory. Sadly, it turns out that my test was flawed. Batch mode doesn't quite work with -z, even when the destination directory is not changed. Not really

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-25 Thread Jos Backus
On Wed, Jan 23, 2002 at 11:05:15AM -0600, Dave Dykstra wrote: > One time I accidentally tried use --read-batch to directory that didn't > match the destination directory that was present when --write-batch created > the files, and then it core dumped at batch.c line 487: I don't see a coredump in

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-24 Thread Jos Backus
On Thu, Jan 24, 2002 at 12:22:58PM -0600, Dave Dykstra wrote: > > Yes, I'll look at doing some documentation. What about a paragraph titled > > ``About batch mode'' with a little explanation how it works, how it differs > > from normal rsync operation and a small example? > > Sounds like a good i

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-24 Thread Dave Dykstra
On Wed, Jan 23, 2002 at 03:41:36PM -0800, Jos Backus wrote: > On Wed, Jan 23, 2002 at 11:05:15AM -0600, Dave Dykstra wrote: > > On Wed, Jan 23, 2002 at 04:37:53PM +1100, Martin Pool wrote: > > > On 17 Jan 2002, Jos Backus <[EMAIL PROTECTED]> wrote: > > > When you get a chance, could you please loo

Re: Fix for batch mode (was Re: batch mode maintainability)

2002-01-23 Thread Jos Backus
Fwiw, I'm currently working on getting rid of the automatically generated filenames --write-batch creates, instead --write-batch should accept a suffix, just like --read-batch. With that working I'll convert the suffix into a prefix, per Dave's excellent suggestion. On Wed, Jan 23, 2002 at 11:05:

Fix for batch mode (was Re: batch mode maintainability)

2002-01-17 Thread Jos Backus
I have found the problem: a missed change from dev_t to DEV64_T. See the last hunk for batch.c in the patch below against today's CVS. It also appends a newline to the argvs file and skips adding the source directory to the command line. Index: batch.c

Re: batch mode maintainability

2002-01-17 Thread Jos Backus
On Wed, Jan 16, 2002 at 06:32:56PM -0801, Jos Backus wrote: > I'll try to investigate; it must be some interaction between the batch code > and some change that has been made in the last month. I have narrowed the changes that break batch mode (even with my patch applied) down to cvs diff -D

Re: batch mode maintainability

2002-01-16 Thread Jos Backus
On Wed, Jan 16, 2002 at 02:52:08PM -0600, Dave Dykstra wrote: > I applied the patch to the current development CVS and it gets further but > still has trouble. Using the above commands, the first --write-batch now > actually copies the files in addition to creating the rsync_* files. > However, w

Re: batch mode maintainability

2002-01-16 Thread Martin Pool
On 15 Jan 2002, Dave Dykstra <[EMAIL PROTECTED]> wrote: > I think Tridge would be in a much better position to judge it's > value vs. the code impact. Actually at the same time I was reconsidering this Tridge also expressed concern off-line at the impact on the code. I've been looking at impr

Re: batch mode maintainability

2002-01-16 Thread Dave Dykstra
On Tue, Jan 15, 2002 at 11:10:55AM -0801, Jos Backus wrote: > On Tue, Jan 15, 2002 at 12:29:05PM -0600, Dave Dykstra wrote: ... > > Here's what I > > tried: > > mkdir s d1 > > echo "rev 1" >f1 > > echo "rev 1" >f2 > > rm -f rsync_*.* > > rsync -av --write-batch s/ d1/ > > r

Re: batch mode maintainability

2002-01-15 Thread Jos Backus
Hi Dave, On Tue, Jan 15, 2002 at 12:29:05PM -0600, Dave Dykstra wrote: > I'm sorry but I really haven't looked at it closely so I can't judge the > impact on the rsync code, and I haven't tried it yet. I think Tridge would > be in a much better position to judge it's value vs. the code impac

Re: batch mode maintainability

2002-01-15 Thread Dave Dykstra
On Tue, Jan 15, 2002 at 08:55:24PM +1100, Martin Pool wrote: > I'm having second thoughts about merging the rsync+ / batch mode patch > into the main rsync release. It adds a lot of extra paths to the > code. I can see it will be useful for a few people, but I'm not sure > it's sufficiently gene

batch mode maintainability

2002-01-15 Thread Martin Pool
I'm having second thoughts about merging the rsync+ / batch mode patch into the main rsync release. It adds a lot of extra paths to the code. I can see it will be useful for a few people, but I'm not sure it's sufficiently general to justify being there. Dave? -- Martin