Re: Inadequate error checking in rsync 2.5.5

2003-09-15 Thread jw schultz
On Mon, Aug 18, 2003 at 01:59:37PM -0700, jw schultz wrote: > On Mon, Aug 18, 2003 at 01:41:51PM -0700, David Norwood wrote: > > > > Okay, with this patch I now get error messages, but it still creates > > null > > > > filled output files. I guess that is what you meant by "the behavior is > > the

Re: Inadequate error checking in rsync 2.5.5

2003-08-18 Thread jw schultz
On Mon, Aug 18, 2003 at 01:41:51PM -0700, David Norwood wrote: > > > Okay, with this patch I now get error messages, but it still creates > null > > > filled output files. I guess that is what you meant by "the behavior is > the > > > same". > > > That is correct. At the point in which we detect

Re: Inadequate error checking in rsync 2.5.5

2003-08-18 Thread David Norwood
> > Okay, with this patch I now get error messages, but it still creates null > > filled output files. I guess that is what you meant by "the behavior is the > > same". > That is correct. At the point in which we detect the > problem there isn't anything we can do to produce > good files. The m

Re: Inadequate error checking in rsync 2.5.5

2003-08-15 Thread jw schultz
On Fri, Aug 15, 2003 at 02:04:50PM -0700, David Norwood wrote: > > I've had a chance to think on it. Attached is a patch that > > allows unmap_file() to report the first read error that > > map_ptr found. The behaviour is the same. I doubt this will > > apply against anything but CVS HEAD as of

Re: Inadequate error checking in rsync 2.5.5

2003-08-15 Thread David Norwood
> I've had a chance to think on it. Attached is a patch that > allows unmap_file() to report the first read error that > map_ptr found. The behaviour is the same. I doubt this will > apply against anything but CVS HEAD as of now. > > This should probably use FERROR instead of FINFO so that a > p

Re: Inadequate error checking in rsync 2.5.5

2003-08-15 Thread jw schultz
On Thu, Aug 14, 2003 at 11:46:51PM -0700, [EMAIL PROTECTED] wrote: > jw schultz writes: > > > I've had a chance to think on it. Attached is a patch that > > allows unmap_file() to report the first read error that > > map_ptr found. The behaviour is the same. I doubt this will > > apply against

Re: Inadequate error checking in rsync 2.5.5

2003-08-14 Thread cbarratt
jw schultz writes: > I've had a chance to think on it. Attached is a patch that > allows unmap_file() to report the first read error that > map_ptr found. The behaviour is the same. I doubt this will > apply against anything but CVS HEAD as of now. > > This should probably use FERROR instead o

Re: Inadequate error checking in rsync 2.5.5

2003-08-14 Thread jw schultz
On Thu, Aug 14, 2003 at 03:08:22PM -0700, jw schultz wrote: > On Thu, Aug 14, 2003 at 12:41:19PM -0700, David Norwood wrote: > [reformatted because someone doesn't know how to compose email] > > I'm using rsync to mirror files from a Windows XP machine > > mounted via smbfs. Apparently I have some

Re: Inadequate error checking in rsync 2.5.5

2003-08-14 Thread jw schultz
On Thu, Aug 14, 2003 at 12:41:19PM -0700, David Norwood wrote: [reformatted because someone doesn't know how to compose email] > I'm using rsync to mirror files from a Windows XP machine > mounted via smbfs. Apparently I have something configured > wrong as I get a "permisson denied" error accessi

Inadequate error checking in rsync 2.5.5

2003-08-14 Thread David Norwood
I'm using rsync to mirror files from a Windows XP machine mounted via smbfs. Apparently I have something configured wrong as I get a "permisson denied" error accessing some of the files on the smbfs mount with cp, od, etc. However, rsync produces no error messages on these files. It happily c