Re: Enabling easier contributions to rsync

2020-05-25 Thread Wayne Davison via rsync
On Mon, May 25, 2020 at 7:09 PM Karl O. Pinc via rsync < rsync@lists.samba.org> wrote: > FWIW, I find sending an email with an attachment a lot easier than having > to login to github, clone, push, and open a pull request. > Patches are still fine by me, so no mandatory pull requests here. ..way

Re: Enabling easier contributions to rsync

2020-05-25 Thread Karl O. Pinc via rsync
On Tue, 26 May 2020 00:43:41 +0200 uxio prego via rsync wrote: > > On 25 May 2020, at 23:55, Wayne Davison via rsync > > wrote: > > > > I've decided to give hosting it on github a try, especially since > > there's been a lot of nice contributions lately. Hopefully this > > will make it easier

Re: Enabling easier contributions to rsync

2020-05-25 Thread uxio prego via rsync
> On 25 May 2020, at 23:55, Wayne Davison via rsync > wrote: > > I've decided to give hosting it on github a try, especially since there's > been a lot of nice contributions lately. Hopefully this will make it easier > for both the people sending patches as well as for me to snag the chang

Re: Enabling easier contributions to rsync

2020-05-25 Thread Filipe Maia via rsync
Hurray! On Tue, 26 May 2020 at 00:07, Wayne Davison via rsync wrote: > I've decided to give hosting it on github a try, especially since there's > been a lot of nice contributions lately. Hopefully this will make it > easier for both the people sending patches as well as for me to snag the > ch

Re: Enabling easier contributions to rsync

2020-05-25 Thread Wayne Davison via rsync
I've decided to give hosting it on github a try, especially since there's been a lot of nice contributions lately. Hopefully this will make it easier for both the people sending patches as well as for me to snag the changes. I'll continue to push changes to the samba git as well. Here's the new

[Bug 14390] Feature request: don't fail if using "-z" transferring to rsync complied with --with-included-zlib=no

2020-05-25 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=14390 --- Comment #4 from Wayne Davison --- Thanks for the gentle prod to remind me about 14338. As things currently stand, the master branch now has support for both zstd & lz4 compression. -- You are receiving this mail because: You are the QA Conta

[Bug 14338] ZSTD support

2020-05-25 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=14338 Wayne Davison changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug 14338] ZSTD support

2020-05-25 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=14338 --- Comment #2 from Wayne Davison --- I'll note that I had to install an upgraded zstd lib to get this to work. I first tried 1.3.8 (since it was mentioned in the configure check) but it didn't have the right exported functions. Then then tried 1.4

[Bug 14338] ZSTD support

2020-05-25 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=14338 Wayne Davison changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Wayne Davison

[PATCH] Make len parameter of do_punch_hole OFF_T

2020-05-25 Thread Yuxuan Shui via rsync
The argument passed to do_punch_hole is a OFF_T to beginning with, and otherwise holes bigger than 2G will cause rsync to fail. --- syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syscall.c b/syscall.c index e1a02a3c..e8ce7d5c 100644 --- a/syscall.c +++ b/syscall.c @

[PATCH] clear sparse_past_write in sparse_end

2020-05-25 Thread Yuxuan Shui via rsync
Otherwise when write_sparse is called for the next file, do_punch_hole will be called with a `pos` that's not actually the current position in file, causing it to fail. --- fileio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fileio.c b/fileio.c index bd2e36ae..32dc62da 100644 --- a/fil

[Bug 14390] Feature request: don't fail if using "-z" transferring to rsync complied with --with-included-zlib=no

2020-05-25 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=14390 --- Comment #3 from Sebastian A. Siewior --- (In reply to Wayne Davison from comment #2) I've sent a zstd patch, what do you want me to do with it (#14338)? -- You are receiving this mail because: You are the QA Contact for the bug. -- Please u

Re: [PATCH] file_checksum() optimization

2020-05-25 Thread Pierre Bernhardt via rsync
Am 25.05.20 um 11:05 schrieb Jorrit Jongma: > No, this patch is for the whole-file checksum, the resulting checksum > is the same regardless of the block size used when feeding the hash > algorithm. Understoof. My fault. Sorry. Cheers, Pierre -- Please use reply-all for most replies to avoid o

Re: [PATCH] file_checksum() optimization

2020-05-25 Thread Jorrit Jongma via rsync
No, this patch is for the whole-file checksum, the resulting checksum is the same regardless of the block size used when feeding the hash algorithm. On Mon, May 25, 2020 at 10:57 AM Pierre Bernhardt via rsync wrote: > Will this not to produce more false negative results? This mean if > comparing

Re: [PATCH] file_checksum() optimization

2020-05-25 Thread Pierre Bernhardt via rsync
Am 25.05.20 um 00:42 schrieb Jorrit Jongma via rsync: > Testing showed the performance improvement to go up quickly going from > 64 to 512 bytes, with diminishing returns above, 4096 was where it > seemed to plateau for me. Re-used CHUNK_SIZE (32 kB) as it already > exists and should be fine to use