Re: [Rpm-maint] [rpm-software-management/rpm] Sort output for test case to avoid race condition (PR #3196)

2024-07-19 Thread Florian Festi
@ffesti pushed 1 commit. 06a7c3bc9b88521eadec77f700cf1df12aeb119e Sort output for test case to avoid race condition -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3196/files/ae4065173b8d3a43ff99c81aafecafa7e35b3a6e..06a7c3bc9b88521eadec77f700cf1df12aeb119e You are re

[Rpm-maint] [rpm-software-management/rpm] Test 12 (testing urlhelper fails) is racy (Issue #3210)

2024-07-19 Thread Florian Festi
There is an empty line / new line moving around. ``` ## -- ## ## Detailed failed tests. ## ## -- ## # -*- compilation -*- 12. rpmgeneral.at:401: testing urlhelper fails ... /rpmgeneral.at:404: runroot rpm --define "_urlhelper /bi

Re: [Rpm-maint] [rpm-software-management/rpm] Sort output for test case to avoid race condition (PR #3196)

2024-07-19 Thread Florian Festi
Ok, I dropped the patch for the url helper test. Let's just fix this and worry about that one later. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3196#issuecomment-2238665788 You are receiving this because you are subscribed to this th

Re: [Rpm-maint] [rpm-software-management/rpm] rpm generators only run when either a magic or path rule is set (Issue #2951)

2024-07-19 Thread Florian Festi
This is both correct. All are optional but nothing will happen unless you have both matching files and a generator for a dependency. A file attribute that does nothing still is legal. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/295

[Rpm-maint] [rpm-software-management/rpm] Make "minimal" file attr more clear (PR #3211)

2024-07-19 Thread Florian Festi
Looks like people were confused by the fact that having a file attr not matching anything was legal. Be more explicit what is expected to make them actuaqlly useful. Resolves: #2951 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/

Re: [Rpm-maint] [rpm-software-management/rpm] sb in lhs and rhs (Issue #3185)

2024-07-19 Thread Florian Festi
OK, turn out we have an older ticket for this also: #1057 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3185#issuecomment-2238832589 You are receiving this because you are subscribed to this thread. Message ID: ___

[Rpm-maint] [rpm-software-management/rpm] Incorrect escaping in some file attribute regexes (Issue #3212)

2024-07-19 Thread Michal Domonkos
Some of the `*.attr` files we bundle with rpm are using incorrect regex escaping of the dot character. Since the macro expansion engine itself recognizes the backslash escape character, it strips its occurrences from the macro body upon expansion. To fix that, every backslash needs to be escaped

Re: [Rpm-maint] [rpm-software-management/rpm] Sort output for test case to avoid race condition (PR #3196)

2024-07-19 Thread Michal Domonkos
Nice! Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3196#issuecomment-2239231768 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing lis

Re: [Rpm-maint] [rpm-software-management/rpm] Sort output for test case to avoid race condition (PR #3196)

2024-07-19 Thread Michal Domonkos
Merged #3196 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3196#event-13574971037 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Test 85 is racy (Issue #3106)

2024-07-19 Thread Michal Domonkos
Closed #3106 as completed via a57eea879d0e47a869f191dc7933fa9b1ad30b83. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3106#event-13574971444 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Make "minimal" file attr more clear (PR #3211)

2024-07-19 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -33,7 +33,7 @@ A file attribute is represented by a macro file in > `%{_fileattrsdir}` (typically %__NAME_protocol ``` -NAME needs to be replaced by the name choosen for the file attribute and needs to be the same as the file name of the macro fi

Re: [Rpm-maint] [rpm-software-management/rpm] rpm generators only run when either a magic or path rule is set (Issue #2951)

2024-07-19 Thread Florian Festi
*sigh* -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2951#issuecomment-2239388234 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Make "minimal" file attr more clear (PR #3211)

2024-07-19 Thread Florian Festi
@ffesti commented on this pull request. > @@ -33,7 +33,7 @@ A file attribute is represented by a macro file in > `%{_fileattrsdir}` (typically %__NAME_protocol ``` -NAME needs to be replaced by the name choosen for the file attribute and needs to be the same as the file name of the macro f

Re: [Rpm-maint] [rpm-software-management/rpm] Make "minimal" file attr more clear (PR #3211)

2024-07-19 Thread Florian Festi
@ffesti pushed 1 commit. 14c4c80ba44af4c4c16cf416bc1cf6b0675219c9 Make "minimal" file attr more clear -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3211/files/4b6503021c10b1539fb016f9fed36acca04cc059..14c4c80ba44af4c4c16cf416bc1cf6b0675219c9 You are receiving this be

Re: [Rpm-maint] [rpm-software-management/rpm] Make "minimal" file attr more clear (PR #3211)

2024-07-19 Thread Michal Domonkos
Merged #3211 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3211#event-13576476179 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] rpm generators only run when either a magic or path rule is set (Issue #2951)

2024-07-19 Thread Michal Domonkos
Closed #2951 as completed via #3211. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2951#event-13576476384 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] rpm generators only run when either a magic or path rule is set (Issue #2951)

2024-07-19 Thread Michal Domonkos
Closed #2951 as completed via 4dc6167465e15f8a0098a55f728f124802a40fbe. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2951#event-13576476438 You are receiving this because you are subscribed to this thread. Message ID: __

[Rpm-maint] [rpm-software-management/rpm] Properly quote REs in file attributes (PR #3213)

2024-07-19 Thread Florian Festi
A literal dot needs to be quoted by two backslashes as the macro parsing already consumes one. This was done quite inconsistently. As a result several regular expressions were more permissive than they should have been. Resolves: #3212 You can view, comment on, or merge this pull request online

Re: [Rpm-maint] [rpm-software-management/rpm] Properly quote REs in file attributes (PR #3213)

2024-07-19 Thread Michal Domonkos
Merged #3213 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3213#event-13576792998 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Incorrect escaping in some file attribute regexes (Issue #3212)

2024-07-19 Thread Michal Domonkos
Closed #3212 as completed via #3213. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3212#event-13576793190 You are receiving this because you are subscribed to this thread. Message ID: ___ R

Re: [Rpm-maint] [rpm-software-management/rpm] Incorrect escaping in some file attribute regexes (Issue #3212)

2024-07-19 Thread Michal Domonkos
Closed #3212 as completed via b19395abc49c9e7d4e990f959c41d3b3b03f277d. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3212#event-13576793218 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Reset recursion depth for error message (PR #3209)

2024-07-19 Thread Michal Domonkos
Please add a test (which should be pretty easy for this one). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3209#issuecomment-2239500603 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [Rpm-maint] [rpm-software-management/rpm] Reset recursion depth for error message (PR #3209)

2024-07-19 Thread Michal Domonkos
I also wonder why the change from the `--` operator to `-= 1`, does it have some effect? I don't suppose that but it does look intentional. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3209#issuecomment-2239507423 You are receiving thi

Re: [Rpm-maint] [rpm-software-management/rpm] Fix sinfoCmp to order signatures correctly (PR #3194)

2024-07-19 Thread Florian Festi
Ok, now the error reporting is better. It probably still should use the most secure hash / signature that is broken but at least it will no longer report "no signature" -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3194#issuecomment-22

Re: [Rpm-maint] [rpm-software-management/rpm] Reset recursion depth for error message (PR #3209)

2024-07-19 Thread Florian Festi
@ffesti pushed 1 commit. 49659b9c268b85591edd659738e96092330593a8 Reset recursion depth for error message -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3209/files/c9d603b500122d4fb4a5c815be24badc2167cf60..49659b9c268b85591edd659738e96092330593a8 You are receiving th