Re: [Rpm-maint] [rpm-software-management/rpm] Stop checking the "signature type" and "rpm package format version" in the Lead structure (Issue #2423)

2023-03-13 Thread Panu Matilainen
It will be handled, in time. The v6 spec is but a very early draft at this point. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2423#issuecomment-1465634375 You are receiving this because you are subscribed to this thread. Message ID

Re: [Rpm-maint] [rpm-software-management/rpm] Reimplement dist and distcheck targets in cmake (Issue #2241)

2023-03-13 Thread Michal Domonkos
Note on the [`dist-hook`](https://github.com/rpm-software-management/rpm/blob/35c62dce0a327600bc0d947a8c01cc649c6e8646/Makefile.am#L289) target in `Makefile.am` which generates the `ChangeLog` file (when we migrate this one to cmake): When checking whether we're in a git checkout, we should use

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
Closed #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8729206542 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
Reopened #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8729323904 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rp

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
Accidentally closed, sorry about that (one of *those* Mondays it seems) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465779717 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
This is a nice example of even the most innocuous looking one-liner needing review... Py_hash_t was only introduced in Python 3.2, which means we need to bump our Python requirement for this. 3.2 is old enough that we can just shrug and bump, but it needs to be documented. > python/header-py.c

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
Closed #2408. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#event-8730224332 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)

2023-03-13 Thread Panu Matilainen
Merged via commit 45103f84764b2a293b068eb0f59456f553ec45d8 with a more elaborate commit message + Python version requirement updated. Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465910141 You

Re: [Rpm-maint] [rpm-software-management/rpm] Allow to specify a default for bcond features in a macro file (PR #2405)

2023-03-13 Thread Panu Matilainen
This is indeed tricky because the desired flow of overrides is different from the usual upstream < distro < host < user override order in rpm. What we have here is something like packager < distro < user - there has to be a way to locally build and override whatever the packager or distro defaul

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Panu Matilainen
@pmatilai approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#pullrequestreview-1336774698 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Catch runaway forked children from Lua scriptlets centrally (PR #2421)

2023-03-13 Thread Florian Festi
Looks good! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2421#issuecomment-1466141491 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Catch runaway forked children from Lua scriptlets centrally (PR #2421)

2023-03-13 Thread Florian Festi
Merged #2421 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2421#event-8731747212 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
@dmnks pushed 79 commits. f4400993780890a37ccad9856340946bb7f9b0c5 Generate Python egg-info from automake builds 6432673bb96761d41905bd741d7028a2d10cba4d Document need to do history research on behavior changes ca4406bd3f6793389de8cb1c9982eefeb4e137c9 Add more on pull requests to CONTRIBUTIN

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
One last fixup: amend upstream commit e31fb5b75898bfa09180dba02475c6d01764d94f so that `Home-page` in the newly added `rpm.egg-info.in` is hardcoded (we don't define `@PACKAGE_URL@` so the field would've been empty). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-s

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
Oh, well... Commit e31fb5b75898bfa09180dba02475c6d01764d94f already was on the `rpm-4.18.x` branch :facepalm: So we need to make the above change a separate commit. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#issuecomment-146623

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.1 bugfix update (PR #2406)

2023-03-13 Thread Michal Domonkos
Merged #2406 into rpm-4.18.x. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2406#event-8732507709 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] Stop checking the "signature type" and "rpm package format version" in the Lead structure (Issue #2423)

2023-03-13 Thread Daniel Alley
Given that the `Lead` has been deprecated for so long, is there any reason to not go ahead and remove the checks now? I can submit a PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2423#issuecomment-1466373719 You are receiving thi

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package format, first public draft for commenting (Discussion #2374)

2023-03-13 Thread Daniel Alley
> crypto modernization:MD5 and SHA1 dropped everywhere I assume this would include changing the default file digest algorithm to something like SHA-256? How about dropping other file digest algos such as MD2, RIPE160, etc? -- Reply to this email directly or view it on GitHub: https://gith