This is a nice example of even the most innocuous looking one-liner needing 
review...

Py_hash_t was only introduced in Python 3.2, which means we need to bump our 
Python requirement for this. 3.2 is old enough that we can just shrug and bump, 
but it needs to be documented.

> python/header-py.c:744:2: error

There aren't that many lines in current header-py.c so must be from compiling 
some other version than git master. It doesn't make the patch any less correct 
but addressing a flaw on a non-existent line would look weird.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1465792947
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2408/c1465792...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to