[Rpm-maint] [rpm-software-management/rpm] Fix Header leak when running rpm2cpio (PR #2304)

2022-11-28 Thread xujing
Header "h" is alloced in rpmReadPackageFile but not freed when running rpm2cpio. Fix it. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2304 -- Commit Summary -- * Fix Header leak when running rpm2cpio -- File Changes --

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive doesn't check command line switches (Issue #2210)

2022-11-28 Thread xujing
Can we add processing similar to rpmkeys: Check whether the option is supported, if not, print related information and exit. I'd be happy to contribute if it's available. ``` [root@localhost ~]# rpmkeys --nosuch rpmkeys: --nosuch: unknown option ``` -- Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
Merged #2302 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2302#event-7902169951 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Remove build artifacts from .gitignore (PR #2303)

2022-11-28 Thread Panu Matilainen
Merged #2303 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2303#event-7902168419 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
@pmatilai pushed 1 commit. 953ba5815f3d44291d4451c69b84aed0534ac6a3 Avoid unnecessary variables for cmake target data, part 4 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2302/files/50704ef84dfcabf3f44341ed54c5e91a90248c3c..953ba5815f3d44291d4451c69b84aed0534ac6a3

[Rpm-maint] [rpm-software-management/rpm] Remove build artifacts from .gitignore (PR #2303)

2022-11-28 Thread Florian Festi
to match the new reality of cmake You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2303 -- Commit Summary -- * Remove build artifacts from .gitignore * Add _build/ to .gitignore -- File Changes -- M .gitignore (65)

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
@pmatilai pushed 1 commit. 50704ef84dfcabf3f44341ed54c5e91a90248c3c Avoid unnecessary variables for cmake target data, part 5 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2302/files/f40d3969c555a32f8cc7dde3b238844d8ac54e6d..50704ef84dfcabf3f44341ed54c5e91a90248c3c

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
@pmatilai pushed 2 commits. de204517cdd4c28dca8e3f1fdd8dfa2ce155afe9 Avoid unnecessary variables for cmake target data, part 3 f40d3969c555a32f8cc7dde3b238844d8ac54e6d Avoid unnecessary variables for cmake target data, part 4 -- View it on GitHub: https://github.com/rpm-software-management/r

Re: [Rpm-maint] [rpm-software-management/rpm] Trouble linking against the sequoia backend when using cmake (Issue #2269)

2022-11-28 Thread Neal H. Walfield
This appears to work for me, now. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2269#issuecomment-1328877534 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
@pmatilai pushed 1 commit. e992fffc5a9f87a0aa24ad454d3905268e37feae fixup! Avoid unnecessary variables for cmake target data, part 2 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2302/files/9655f6aa850d25f9163c069b4fedaf0ab023b8c9..e992fffc5a9f87a0aa24ad454d3905268e

Re: [Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
@pmatilai pushed 2 commits. 83a6d99ff45796bbd878dd04ab0e640831029cec Avoid unnecessary variables for cmake target data, part 1 9655f6aa850d25f9163c069b4fedaf0ab023b8c9 Avoid unnecessary variables for cmake target data, part 2 -- View it on GitHub: https://github.com/rpm-software-management/r

[Rpm-maint] [rpm-software-management/rpm] Avoid using unnecessary variables for cmake target data (PR #2302)

2022-11-28 Thread Panu Matilainen
The foo_SOURCES style isn't really in cmake ethos, and is wholly unnecessary here: target_sources() achieves the same exact thing in a slightly more straightforward way. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2302 --

Re: [Rpm-maint] [rpm-software-management/rpm] Trouble linking against the sequoia backend when using cmake (Issue #2269)

2022-11-28 Thread Panu Matilainen
Closed #2269 as completed via #2301. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2269#event-7900974150 You are receiving this because you are subscribed to this thread. Message ID: ___ Rp

Re: [Rpm-maint] [rpm-software-management/rpm] Use cmake imported targets to let it sort out the compiler flag details (PR #2301)

2022-11-28 Thread Panu Matilainen
Merged #2301 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2301#event-7900973971 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

[Rpm-maint] [rpm-software-management/rpm] Use cmake imported targets to let it sort out the compiler flag details (PR #2301)

2022-11-28 Thread Panu Matilainen
These imported targets passed to target_link_library() are supposed to handle all the pesky compilation, linkage etc details behind the scenes. I was pretty sure I was missing a trick with this, but this sure isn't exactly underlined in the documentation. Unroll the supposedly helpful loop for

Re: [Rpm-maint] [rpm-software-management/rpm] Use multhtreading by default for unpacking zstd-compressed Source0: (Issue #2299)

2022-11-28 Thread Коренберг Марк
Closed #2299 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2299#event-7900676024 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint ma

Re: [Rpm-maint] [rpm-software-management/rpm] Use multhtreading by default for unpacking zstd-compressed Source0: (Issue #2299)

2022-11-28 Thread Коренберг Марк
You are right, I did not read thoroughly. https://github.com/facebook/zstd/issues/2470 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2299#issuecomment-1328737840 You are receiving this because you are subscribed to this thread. Mess

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-28 Thread xujing
@JetXujing pushed 6 commits. 0fcd5d6032cab4e3b124decae76988eeed9af8cf Fix BANames leak in handlePreambleTag c564b1b988f57f481895f3e4cad203dbbe9b4b99 Fix emsg leak in parseRCPOT 05959b6a43a0fd316499d25e12f4a1f31dc09caf Fix prog leak in parseScript 3233e97615bedfa771ee41363330968e71260a1a Fix el

[Rpm-maint] [rpm-software-management/rpm] Add --generate-subpackages to find_lang.sh (PR #2300)

2022-11-28 Thread Florian Festi
Use the new dynamic spec feature to create language sub packages. The is more of a RFC as there are a few things that need more polishing. The code for getting the language description is a bit ad-hoc and may need to switch to another entry in `locale` data. Suggestions welcome. The package dec

Re: [Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-28 Thread xujing
> Didn't look at the patches too closely yet, but: > > * Please capitalize commit messages properly, including the summary line. As > in, start sentences with a capital letter. > * Avoid piling on large number of commits to a single PR, it makes reviewing > harder even if they're just tiny one-l