imvtsl commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r2002169879
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,14 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
/
imvtsl commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r2002169879
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,14 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
/
imvtsl commented on PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#issuecomment-2734966459
Late here, but I wanted to put forth my point:
> the parameter withReplacement in the other cases already contains the
"with" part in the name.
I believe the original nam
grundprinzip commented on PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#issuecomment-2568270079
merging to master, thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
grundprinzip closed pull request #84: Add Sample functionality in DataFrame.
URL: https://github.com/apache/spark-connect-go/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
grundprinzip commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r1835714067
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,14 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
grundprinzip commented on PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#issuecomment-2466764558
@imvtsl Golang does not have the concept of default parameters or method
overloading. The idiomatic way of dealing with this is to provide different
methods. Using an int pointe
grundprinzip commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r1835714005
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,14 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
imvtsl commented on PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#issuecomment-2453114766
> While working on this PR, I noticed that existing functions don't
currently support optional arguments. For instance, in the
[Show](https://github.com/apache/spark-connect-go/blob/a
imvtsl commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r1826759752
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,8 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
//
grundprinzip commented on code in PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r1825931136
##
spark/sql/dataframe.go:
##
@@ -148,6 +148,8 @@ type DataFrame interface {
Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData
imvtsl commented on PR #84:
URL: https://github.com/apache/spark-connect-go/pull/84#issuecomment-2440920523
Hi @grundprinzip
I added functionality for the `Sample` function.
While working on this PR, I noticed that existing functions don't currently
support optional arguments. Fo
12 matches
Mail list logo
