imvtsl commented on code in PR #84: URL: https://github.com/apache/spark-connect-go/pull/84#discussion_r2002169879
########## spark/sql/dataframe.go: ########## @@ -148,6 +148,14 @@ type DataFrame interface { Rollup(ctx context.Context, cols ...column.Convertible) *GroupedData // SameSemantics returns true if the other DataFrame has the same semantics. SameSemantics(ctx context.Context, other DataFrame) (bool, error) + // Sample samples a data frame without replacement and random seed. + Sample(ctx context.Context, fraction float64) (DataFrame, error) + // SampleWithReplacement samples a data frame with random seed and with/without replacement. + SampleWithReplacement(ctx context.Context, withReplacement bool, fraction float64) (DataFrame, error) + // SampleSeed samples a data frame without replacement and given seed. + SampleSeed(ctx context.Context, fraction float64, seed int64) (DataFrame, error) Review Comment: please [refer](https://github.com/apache/spark-connect-go/pull/84#issuecomment-2734966459) below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org