Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-27 Thread via GitHub
cloud-fan closed pull request #50025: [SPARK-51270][SQL] Support UUID type in Variant URL: https://github.com/apache/spark/pull/50025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-27 Thread via GitHub
cloud-fan commented on PR #50025: URL: https://github.com/apache/spark/pull/50025#issuecomment-2689557570 thanks, merging to master/4.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-27 Thread via GitHub
cashmand commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1974435292 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java: ## @@ -240,6 +242,18 @@ public void appendBinary(byte[] binary) { writePos +=

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-27 Thread via GitHub
gene-db commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1974322433 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java: ## @@ -240,6 +242,18 @@ public void appendBinary(byte[] binary) { writePos += b

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-27 Thread via GitHub
cashmand commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1973900282 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java: ## @@ -240,6 +242,19 @@ public void appendBinary(byte[] binary) { writePos +=

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-26 Thread via GitHub
chenhao-db commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1972565165 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java: ## @@ -240,6 +242,19 @@ public void appendBinary(byte[] binary) { writePos +

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-26 Thread via GitHub
cashmand commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1971821381 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantUtil.java: ## @@ -497,6 +508,19 @@ public static String getString(byte[] value, int pos) { t

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-26 Thread via GitHub
cashmand commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1971807592 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantShreddingWriter.java: ## @@ -283,6 +283,11 @@ private static Object tryTypedShred( ret

Re: [PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-25 Thread via GitHub
chenhao-db commented on code in PR #50025: URL: https://github.com/apache/spark/pull/50025#discussion_r1970383080 ## common/variant/src/main/java/org/apache/spark/types/variant/VariantUtil.java: ## @@ -497,6 +508,19 @@ public static String getString(byte[] value, int pos) {

[PR] [SPARK-51270][SQL] Support UUID type in Variant [spark]

2025-02-20 Thread via GitHub
cashmand opened a new pull request, #50025: URL: https://github.com/apache/spark/pull/50025 ### What changes were proposed in this pull request? Four new types were added to the Parquet Variant spec (https://github.com/apache/parquet-format/commit/25f05e73d8cd7f5c83532ce51cb4f