cashmand commented on code in PR #50025:
URL: https://github.com/apache/spark/pull/50025#discussion_r1974435292
##########
common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java:
##########
@@ -240,6 +242,18 @@ public void appendBinary(byte[] binary) {
writePos += binary.length;
}
+ public void appendUuid(UUID uuid) {
Review Comment:
Good catch, I hadn't noticed that this function wasn't tested. I modified
one of the tests I added to use VariantBuilder to construct its UUID, so that
it uses this function. This exposed a bug - when I switched to using
`ByteBuffer.wrap`, I didn't update the indices that I wrote the UUID to, so it
was always writing them at index 0 of the full value array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
