Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

cloud-fan closed pull request #49837: [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule URL: https://github.com/apache/spark/pull/49837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

cloud-fan commented on PR #49837: URL: https://github.com/apache/spark/pull/49837#issuecomment-2652492679 The AQE test failure is unrelated, thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

the-sakthi commented on PR #49837: URL: https://github.com/apache/spark/pull/49837#issuecomment-2651800069 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1950859900 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -51,27 +52,12 @@ object PullOutNondeterministic extends

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

cloud-fan commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1950851713 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -51,27 +52,12 @@ object PullOutNondeterministic extends Rul

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1950496924 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -34,10 +36,14 @@ object PullOutNondeterministic extends

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

cloud-fan commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1950410685 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -34,10 +36,14 @@ object PullOutNondeterministic extends Rul

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

cloud-fan commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1950410321 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -34,10 +36,14 @@ object PullOutNondeterministic extends Rul

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1949484325 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NondeterministicExpressionCollection.scala: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apac

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

vladimirg-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1949191870 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NondeterministicExpressionCollection.scala: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apach

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db commented on PR #49837: URL: https://github.com/apache/spark/pull/49837#issuecomment-2648160532 Hi @MaxGekk could you please review when you have time? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1948804599 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -51,27 +55,39 @@ object PullOutNondeterministic extends

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

vladimirg-db commented on code in PR #49837: URL: https://github.com/apache/spark/pull/49837#discussion_r1945454956 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala: ## @@ -51,27 +55,39 @@ object PullOutNondeterministic extends

Re: [PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

vladimirg-db commented on PR #49837: URL: https://github.com/apache/spark/pull/49837#issuecomment-2641040587 Please specify that this is for single-pass Analyzer in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [SPARK-51114] [SQL] Refactor PullOutNondeterministic rule [spark]

mihailoale-db opened a new pull request, #49837: URL: https://github.com/apache/spark/pull/49837 ### What changes were proposed in this pull request? Refactor `PullOutNondeterministic` rule. ### Why are the changes needed? Better reusability of the `PullOutNondeterministic` rule.