cloud-fan commented on code in PR #49837:
URL: https://github.com/apache/spark/pull/49837#discussion_r1950410685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PullOutNondeterministic.scala:
##########
@@ -34,10 +36,14 @@ object PullOutNondeterministic extends Rule[LogicalPlan] {
case f: Filter => f
case a: Aggregate if a.groupingExpressions.exists(!_.deterministic) =>
- val nondeterToAttr = getNondeterToAttr(a.groupingExpressions)
- val newChild = Project(a.child.output ++ nondeterToAttr.values, a.child)
+ val nondeterToAttr =
+
NondeterministicExpressionCollection.getNondeterministicToAttributes(a.groupingExpressions)
+ val newChild = Project(a.child.output ++
nondeterToAttr.values.asScala.toSeq, a.child)
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
