[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-183623401 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-183623402 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183620749 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183620752 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183620306 **[Test build #51230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51230/consoleFull)** for PR 11190 at commit [`a4bae33`](https://g

[GitHub] spark pull request: [SPARK-13300][Documentation] Added pygments.rb...

2016-02-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11180#issuecomment-183616693 @amitdev just build the documentation. Do you see the code snippets correctly in the page http://spark.apache.org/examples.html in your local build? instead of the pygme

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-12 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-183616365 @cloud-fan Thanks so much for your code review! There is the update for the doc and error cases review.:) --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [Documentation] Added pygments.rb dependancy

2016-02-12 Thread amitdev
Github user amitdev commented on the pull request: https://github.com/apache/spark/pull/11180#issuecomment-183616247 @srowen, it looks related - is there a waay to verify it? I couldn't locate where the spark example code is. Things on the main documentation site is working fine. Anyw

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-12 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52824805 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions { new Mu

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183615182 @rxin Compare to broadcast join, we do execution in prepare(), for uncorrelated scalar subquery, we do optimize and execution in prepare(), I think it's not a big deal.

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183614067 So I think the biggest question is whether we should do all of these planning for subqueries and execution in prepare(), or come up with some other way to run subqueries.

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183613962 I took a look quickly. Looks pretty good overall. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183613871 This patch ended up changing substantially, so I'd like @ScrapCodes to take a quick look at it. In a nutshell: - I modified the `tools` project to re

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r52824499 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -392,9 +399,11 @@ private[hive] class HiveQl(conf: ParserConf) extends SparkQl(c

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183612372 **[Test build #51232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51232/consoleFull)** for PR 10894 at commit [`bd1a53c`](https://gi

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r52824448 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -35,16 +36,15 @@ abstract class Catalog { // Database

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r52824392 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -244,29 +247,41 @@ class InMemoryCatalog extends Catal

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11189#discussion_r52824378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -244,29 +247,41 @@ class InMemoryCatalog extends Catal

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183612031 **[Test build #51231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51231/consoleFull)** for PR 11181 at commit [`913bf1b`](https://gi

[GitHub] spark pull request: [SPARK-12799] Simplify various string output f...

2016-02-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10757#issuecomment-183611585 BTW You might want to resolve this before it goes super stale. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183610661 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183610663 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183610345 **[Test build #51228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51228/consoleFull)** for PR 11178 at commit [`31854eb`](https://g

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183607789 **[Test build #51230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51230/consoleFull)** for PR 11190 at commit [`a4bae33`](https://gi

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183604929 **[Test build #51229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51229/consoleFull)** for PR 11100 at commit [`7631371`](https://gi

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-12 Thread vijaykiran
Github user vijaykiran closed the pull request at: https://github.com/apache/spark/pull/10598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183601453 https://github.com/apache/spark/pull/11171 did a few changes in conversion from logical plan to SQL. I believe this is the cause of build failure. --- If your proj

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11190#discussion_r52824062 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2105,6 +2105,18 @@ class SQLQuerySuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-12 Thread ygcao
Github user ygcao commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r52823895 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -289,24 +301,20 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183588756 **[Test build #51228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51228/consoleFull)** for PR 11178 at commit [`31854eb`](https://gi

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183588737 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183588736 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183588710 **[Test build #51225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51225/consoleFull)** for PR 10894 at commit [`3684b70`](https://g

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183588613 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183588614 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183588588 **[Test build #51223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51223/consoleFull)** for PR 11193 at commit [`c9726c2`](https://g

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183587605 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183587606 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183587604 **[Test build #51227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51227/consoleFull)** for PR 11121 at commit [`c28343f`](https://g

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183587306 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183587308 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183587271 **[Test build #51222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51222/consoleFull)** for PR 11181 at commit [`c268740`](https://g

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183587238 **[Test build #51227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51227/consoleFull)** for PR 11121 at commit [`c28343f`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183582695 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13278][CORE] Launcher fails to start wi...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11160#issuecomment-183581494 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13278][CORE] Launcher fails to start wi...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11160#issuecomment-183581495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183581412 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13278][CORE] Launcher fails to start wi...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11160#issuecomment-183581421 **[Test build #51221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51221/consoleFull)** for PR 11160 at commit [`68159d8`](https://g

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183581411 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...

2016-02-12 Thread BimalTandel
Github user BimalTandel commented on the pull request: https://github.com/apache/spark/pull/11191#issuecomment-183581071 I cant reproduce this on the latest release. I did the current path for the requirement to only display help if it is the only option provided. --- If your project

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183580801 **[Test build #51225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51225/consoleFull)** for PR 10894 at commit [`3684b70`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183580517 I've updated this patch to change `maxRows` into an `Option[Long]` and have added a test to make sure that constant-folding works as expected. --- If your project is

[GitHub] spark pull request: [SPARK-12976][SQL] Add LazilyGenerateOrdering ...

2016-02-12 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183580300 I renamed `LazilyGenerateOrdering` to `LazilyGeneratedOrdering` and modify `TakeOrderedAndProject` to use it. And I found `TakeOrderedAndProjectNode` could use

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183575382 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183575387 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183575329 **[Test build #51224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51224/consoleFull)** for PR 11178 at commit [`9fc0f7a`](https://g

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183570979 **[Test build #51224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51224/consoleFull)** for PR 11178 at commit [`9fc0f7a`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11121#discussion_r52821914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -91,6 +91,14 @@ abstract class LogicalPlan exte

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183569347 **[Test build #51223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51223/consoleFull)** for PR 11193 at commit [`c9726c2`](https://gi

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11193#discussion_r52821641 --- Diff: network/common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java --- @@ -99,6 +122,9 @@ public long transferTo(final Writab

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11193#discussion_r52821604 --- Diff: network/common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-13308] ManagedBuffers passed to OneToOn...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183568010 /cc @zsxwing @nongli @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: 'SPARK-13308

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11193#issuecomment-183567845 Whoops, accidentally hit open too soon. Let me fill in the description now. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: 'SPARK-13308

2016-02-12 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/11193 'SPARK-13308 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JoshRosen/spark add-missing-release-calls-in-network-layer Alternatively you c

[GitHub] spark pull request: [SPARK-13257] [Improvement] Scala naive Bayes ...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11192#issuecomment-183561092 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13257] [Improvement] Scala naive Bayes ...

2016-02-12 Thread movelikeriver
GitHub user movelikeriver opened a pull request: https://github.com/apache/spark/pull/11192 [SPARK-13257] [Improvement] Scala naive Bayes example: check model after loading Refine naive Bayes example by checking model after loading it. This is Java version, to be consistent with

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183560768 **[Test build #51222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51222/consoleFull)** for PR 11181 at commit [`c268740`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11121#discussion_r52820935 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -91,6 +91,14 @@ abstract class LogicalPlan exte

[GitHub] spark pull request: [SPARK-13296][SQL] Move UserDefinedFunction in...

2016-02-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11181#issuecomment-183559582 cc @davies for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-13278][CORE] Launcher fails to start wi...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11160#issuecomment-183559586 **[Test build #51221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51221/consoleFull)** for PR 11160 at commit [`68159d8`](https://gi

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11121#discussion_r52820567 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -91,6 +91,14 @@ abstract class LogicalPlan extends

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11121#discussion_r52820485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -91,6 +91,14 @@ abstract class LogicalPlan exte

[GitHub] spark pull request: [SPARK-13278][CORE] Launcher fails to start wi...

2016-02-12 Thread cl4es
Github user cl4es commented on the pull request: https://github.com/apache/spark/pull/11160#issuecomment-183558848 While not a general rule, testing lexically that `version >= "1.8.0"` like in `UtilsSuite` is actually OK for all current and all possible JEP-223 versions. I fixed `Spar

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11177#issuecomment-183554490 LGTM. Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183554174 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11177#discussion_r52819793 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Expand.scala --- @@ -17,11 +17,15 @@ package org.apache.spark.sql.execution

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183554183 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183554033 **[Test build #51204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51204/consoleFull)** for PR 10705 at commit [`f3fc298`](https://g

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183553275 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183553277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183553163 **[Test build #51220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51220/consoleFull)** for PR 11190 at commit [`016c36c`](https://g

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183552466 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183552468 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183552400 **[Test build #51217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51217/consoleFull)** for PR 11189 at commit [`2b72025`](https://g

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11177#issuecomment-183551779 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11177#issuecomment-183551777 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13293] [SQL] generate Expand

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11177#issuecomment-183551314 **[Test build #51219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51219/consoleFull)** for PR 11177 at commit [`ff2b5a4`](https://g

[GitHub] spark pull request: [SPARK-7367] [Spark Submit] spark-submit CLI -...

2016-02-12 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11191#issuecomment-183549224 See my update to the bug. I don't think the bug exists anymore - and if it does, your fix is probably not correct. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183548251 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183548249 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13080] [SQL] [WIP] Implement new Catalo...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11189#issuecomment-183548157 **[Test build #51216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51216/consoleFull)** for PR 11189 at commit [`8e82f1d`](https://g

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183545194 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183545191 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183545098 **[Test build #51214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51214/consoleFull)** for PR 11178 at commit [`76a365e`](https://g

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11190#discussion_r52816744 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2105,6 +2105,18 @@ class SQLQuerySuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request: [SPARK-13280] [streaming] Use a better logger ...

2016-02-12 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/11165#issuecomment-183539038 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183537578 @zsxwing I dont have a constructor to do object initialization for the FilePhantomReferences class. I am guessing that could also be causing python broadcast to

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183537610 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13306] [SQL] uncorrelated scalar subque...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11190#issuecomment-183537607 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

  1   2   3   4   >