Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r52824448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -35,16 +36,15 @@ abstract class Catalog {
// Databases
//
--------------------------------------------------------------------------
- def createDatabase(dbDefinition: Database, ignoreIfExists: Boolean): Unit
+ def createDatabase(dbDefinition: CatalogDatabase, ignoreIfExists:
Boolean): Unit
def dropDatabase(db: String, ignoreIfNotExists: Boolean, cascade:
Boolean): Unit
- /**
- * Alter an existing database. This operation does not support renaming.
- */
- def alterDatabase(db: String, dbDefinition: Database): Unit
+ def alterDatabase(dbDefinition: CatalogDatabase): Unit
--- End diff --
i'd add some documentation here saying we are picking the database name
from CatalogDatabase, and will update other db metadata based on CatalogDatabase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
