> Did anyone try them with these layers?
Sorry this is probably not the feedback you want, but honestly I think they all
look bad, even option 4 (unless maybe for specific use cases but not in
general) and they should only be available as optional dark styles, and light
tiles should remain the
> One thing was wrong, the filter was applied twice. Yes, no one noticed it in
> 6 months.
That’s funny because hundreds of people complained about it within the first
hour it was live.
It doesn’t matter that it was applied twice, you and every other dev saw it
like that thought it was fine. Y
> Everyone had ~6 months to test the dark mode before it was launched
I use OSM almost daily, from time to time on Discord and forums, I even
contribute to iD occasionally, but I never saw any indication that a dark mode
was in active development and about to be released.
--
Reply to this ema
Closes #5327
See #5328 and
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2482070226
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5340
-- Commit Summary --
* Remove brightness fi
In any case, the current implementation of the dimming filter for all dark mode
users is problematic.
I believe that providing an easy way to switch between light and dark maps
independent of the UI like
[this](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480
The control buttons don't change in dark mode, I think that's good, but the
tooltip shouldn't change then.
current dark mode vs light mode
 in `about:config`
`toolkit.legacyUserProfileCustomizations.stylesheets`, then restart Firefox,
Contrast is a bit too low in the topbar, even in light mode. Chrome shows green
at 4.5 but I think it should be even higher since this text is important.
;` makes panning extremely laggy in
Firefox.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5330#issuecomment-2479700613
You are receiving this because you are subscribed to this thread.
Me
Readability is bad due to poor contrast with blue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2480037520
You are re
@ChrisJoubert2501 I managed to fix my performance issue by disabling and
re-enabling style customization with userChrome.css in `about:config`
`toolkit.legacyUserProfileCustomizations.stylesheets`, restarting Firefox after
each setting change.
However, other users with less powerful machines an
Imo the background around the search box is unnecessary:
maybe replace is by a shadow
--
Reply to this email directly
Can someone merge #5327 ?
It's unacceptable that all users with a dark browser preference are forced to
endure the highly controversial dimming while waiting for a better solution to
be implemented.
Their only options currently are switching all websites to light mode or
install an extension to
What are you waiting to merge this?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2481495761
You are receiving this because you are subscribed to this thread.
Message ID:
__
I see no one is testing for Firefox, option 1 should be used because CSS filter
are not well optimized on Firefox and makes panning very laggy, even on good
computer.
It's not very noticeable in this screen recording because you don't see the
mouse input lag, try it for yourself.
https://githu
The map is like a photo, and any photo-viewing applications display photos the
same way regardless of whether they are in dark or light mode.
As previously said, dark mode is more about contrast, and should actually be
bright if used in a bright environment.
If the user is in dark environment,
That's the question, certainly not the current one with 20% dimming, maybe a
more complex filter can work while waiting for vector tiles or simply keep the
same as light mode for now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/is
> They don't change much between light/dark modes.
They certainly don't decrease.
> Do we need different filters for different layers?
I don't think filters are a good idea, we just need one good dark styl
> Do you mean not showing layers that don't have a version with dark tiles?
No, normal tiles with dark UI looks great, just add a dark style in addition to
the others and make it default for dark mode but easy to change.
--
Reply to this email directly or view it on GitHub:
https://github.com/
@pkrasicki And you can drag the map smoothly? I have a huge increase in input
lag when dragging the dark map.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480624689
You are receiving this because you are su
@AntonKhorev It’s unreasonable for you to expect OSM users to look at all the
pull requests to give feedback before a change as significant as this one gets
implemented.
Many other websites and apps I use started by adding a dark mode toggle in the
settings, staying in light mode by default unti
> so it seems osm needs a 'beta.osm org'
I thought we already had that, but it’s only for iD
(https://ideditor.netlify.app/).
But I don’t think it’s necessary, a simple post on the official OSM social
media announcing that a new dark mode is available for testing in the settings
would have bee
> you can't have a button in the header for every possible setting
Sure, but I think appearance and language are important enough to be quickly
accessible at all times, like on Wikipedia.
Another option to consider would be placing them directly in the drop-down
menu, like on YouTube or Reddit:
Call it what you want, but I think we've collected enough feedback to conclude
that dark maps aren't ready to be the default.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2537238479
You are receiving this be
No because non-logged in users can't set light map.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2537382117
You are receiving this because you are subscribed to this thread.
Message ID:
I found another technical reason to merge this ASAP: the filter is causing a
black and white grid to flicker around tiles borders while zooming on Chrome.
It’s slightly noticeable on desktop but very annoying on mobile.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
Apparently this was decided
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626)
but I don't understand this choice @gravitystorm.
Even for registered users it's bad because they can't set dark on desktop and
light on mobile for example.
--
Reply to
Okay, I don’t have a Mac to test with Safari, but I found an extension to
precisely change zoom levels on Chrome and it looks like _mix-blend-mode:
plus-lighter_ creates problems more often than not, so it should only be
applied to specific pixel ratios where it’s been confirmed to work.
--
Re
@verhovsky How did you set specific zoom values like 85% and 115%?
I found that this white grid can simply be removed with CSS exceptions for
specific pixel ratios (see https://github.com/Leaflet/Leaflet/pull/9560) but I
was only able to test for these values
https://github.com/openstreetmap/iD/
Thank you for your work on this.
I was going to request the addition of Tracestrack Topo, but I realize this is
a bigger problem than it seems. If someone is going to work on it, the effort
would be better spent creating a script to automatically generate the keys from
the map stylesheet, making
> I don't think a map is like a photo at all. It's not satellite images, it's
> just a bunch of data
You only consider labels and lines, but with fill colors and shadows, it’s more
like a digital painting.
Style creators spend a lot of time carefully designing it, and you can’t just
override i
> I'm not aware of any performance issues with CSS filter
Have you tried a more complex filter like `brightness(0.6) invert(1)
contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7)` on Firefox?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
On a grayscale, the default OSM light theme is actually 19% dark, whereas a
typical light page with black text is around 3%.
The dark theme you showed is 90% dark.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecommen
@tomFlowee Only maintainers can merge this, there are three: one is in favor,
another is the one who added the filter, and the last one doesn't want to do
anything related to dark mode. It's ridiculous.
You can install the Stylus extension
([Firefox](https://addons.mozilla.org/en-US/firefox/add
41 matches
Mail list logo
