@hlfan commented on this pull request.
> +<% if Settings.key?(:maptiler_key) %>
+ MAPTILER_KEY: <%= Settings.maptiler_key.to_json %>,
+<% end %>
This should be with the other keys in the embedded Settings json
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
@hlfan commented on this pull request.
> @@ -76,5 +76,10 @@ document.addEventListener("DOMContentLoaded", function () {
const data = parent.OSM.mapParams();
goToLocation(data);
});
+
+const projectTitle = parent.document.title;
+new MutationObserver(() =>
+ parent
@hlfan pushed 1 commit.
7a8bc77219d111cc9f78cff0e32ee787b03aea20 Propagate iD title to parent
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5865/files/e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5..7a8bc77219d111cc9f78cff0e32ee787b03aea20
You are receiving this be
@AntonKhorev commented on this pull request.
> @@ -76,5 +76,10 @@ document.addEventListener("DOMContentLoaded", function () {
const data = parent.OSM.mapParams();
goToLocation(data);
});
+
+const projectTitle = parent.document.title;
+new MutationObserver(() =>
+
@hlfan pushed 1 commit.
dd4068c8c7638beeb8e39181ded99dfc82dec90f Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/2d9a37a61e1dabf65bed726f0a9f7df62877be91..dd4068c8c7638beeb8e39181ded99dfc82dec90f
You are receiving this because
@hlfan pushed 1 commit.
0f7b954def5bf58c24dba964d8825a3bb08c7e04 Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/dd4068c8c7638beeb8e39181ded99dfc82dec90f..0f7b954def5bf58c24dba964d8825a3bb08c7e04
You are receiving this because
### Description
The way the directions icons are currently drawn, the diagonal arrows are a
fair bit smaller than the arrows in cardinal directions. The size stays
consistent when the arrows are instead drawn with a marker.
Compare the icons in this chart, where the old icon is red, the new one g
@hlfan pushed 1 commit.
e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5 Propagate iD title to parent
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5865/files/5ff2d6a204f136158aabdb1bce3434e2145511df..e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5
You are receiving this be
@hlfan commented on this pull request.
> +const params = new URLSearchParams;
+for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon",
"maxlat"]) {
+ const paramValue = this.elements[paramName].value;
+ if (paramValue) {
+params.set(paramName, paramValu
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5866)
You want horizontal and vertical shape boundaries to go exactly over pixel
boundaries, otherwise shapes may look more blurry and smaller.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
hlfan left a comment (openstreetmap/openstreetmap-website#5670)
I've been thinking about if more granular control about which errors get
reported in which way could help. (maybe issue at
[coverallsapp/github-action](https://github.com/coverallsapp/github-action)?)
--
Reply to this email direct
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
> we can always change this temporarily if there is a problem with coveralls
> that we need to work around.
This is not really true though as once it starts happening changing the
workflow won't have any effect on existing PRs
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
> I've been thinking about if more granular control about which errors get
> reported in which way could help. (maybe issue at
> [coverallsapp/github-action](https://github.com/coverallsapp/github-action)?)
I was just looking a
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5857#pullrequestreview-2727853929
You are receiving this because you are subscribed to this thread.
Message ID:
__
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5849)
> Alternative after ... #5670
this pr had nothing to do with Coveralls
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5849#issuecomment-2764630283
You are rec
@hlfan pushed 1 commit.
2d9a37a61e1dabf65bed726f0a9f7df62877be91 Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/0f7b954def5bf58c24dba964d8825a3bb08c7e04..2d9a37a61e1dabf65bed726f0a9f7df62877be91
You are receiving this because
@tomhughes approved this pull request.
Thanks for the fix. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5857#pullrequestreview-2727906151
You are receiving this because you are subscribed to this
Merged #5866 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5866#event-17047999638
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5849)
Alternative after:
#5670
--
Reply to this email directly or view it on GitHub:
@AntonKhorev commented on this pull request.
> @@ -76,5 +76,13 @@ document.addEventListener("DOMContentLoaded", function () {
const data = parent.OSM.mapParams();
goToLocation(data);
});
+
+const firstParentTitle = parent.document.title;
+new MutationObserver(function
@AntonKhorev commented on this pull request.
> + if (!mutations.some(mutation => mutation.target.tagName === "TITLE"))
> return;
+ const newTitle = `${document.title} | ${firstParentTitle}`;
+ if (parent.document.title === newTitle) return;
+ parent.document.title = newTitle
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
This is the current coveralls status, and the end time has already been
extended at least once:
Coveralls posts it's results separately i
@AntonKhorev commented on this pull request.
> @@ -76,5 +76,13 @@ document.addEventListener("DOMContentLoaded", function () {
const data = parent.OSM.mapParams();
goToLocation(data);
});
+
+const firstParentTitle = parent.document.title;
+new MutationObserver(function
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
I really think we need to revisit this - having every PR show as erroneous
because coveralls is down for maintenance for long periods is a massive pain
for maintainers trying to work out what can be reviewed.
--
Reply to this
tomhughes left a comment (openstreetmap/openstreetmap-website#5867)
Sorry yes I just realised I merged this by accident - it wasn't what I intended
to merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5867#issuecomment-27646
Merged #5857 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5857#event-17048553887
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5866)
Sorry @hlfan I merged this accidentally and have now reverted it but there
doesn't seem to be any way to reopen the PR so if you want to pursue it can you
reopen but you might want to read @AntonKhorev's comments in #5867 first.
Merged #5867 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5867#event-17048553883
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
28 matches
Mail list logo
