@hlfan commented on this pull request.
> + const params = new URLSearchParams;
+ for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon",
"maxlat"]) {
+ const paramValue = this.elements[paramName].value;
+ if (paramValue) {
+ params.set(paramName, paramValue);
+ }
+ }
+ const search = params.get("query") ? `/search?${params}` : "/";
Do you really want to expose all these parameters in the URL?
The bbox params don't even update the map hash that's also there
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5868#pullrequestreview-2728284278
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5868/review/2728284...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
