Re: [openstreetmap/openstreetmap-website] Bump qs from 6.13.1 to 6.14.0 (PR #5501)
Merged #5501 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5501#event-15939081965 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Adds description and author_id methods to Note (PR #5494)
@nenad-vujicic commented on this pull request. > @@ -36,6 +36,26 @@ class NoteComment < ApplicationRecord validates :event, :inclusion => %w[opened closed reopened commented hidden] validates :body, :length => { :maximum => 2000 }, :characters => true + # Return the note's description f
Re: [openstreetmap/openstreetmap-website] Remove old browse redirects (PR #5463)
There were more links in the translations of that page. I've updated all of the translations today. However, I've just found more pages, e.g. https://wiki.openstreetmap.org/wiki/Ko:Beginners_Guide_1.2.2 that link to either `create-account.html` or `forgot-password.html`. My personal feeling is
Re: [openstreetmap/openstreetmap-website] Make preferences page editable without clicking 'Edit Preferences' (PR #5449)
Since there's no other comments here, I'm happy to merge. We can always revisit this if we find a different approach. Thanks @AntonKhorev -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2592768380 You are recei
Re: [openstreetmap/openstreetmap-website] Resourceful routes for users api (PR #5433)
Merged #5433 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5433#event-15940655180 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Override bootstrap's box-shadow effect on search field & sidebar buttons (PR #4176)
@kimberlymarkley Thank you for your PR! I agree with @tomhughes, that the shadow is part of the accessibility needs for keyboard navigation. And additionally, if we did decide to remove the shadow, we would do so using the class approach, rather than custom CSS. So I'm going to decline this PR,
Re: [openstreetmap/openstreetmap-website] Yatharths11/issue5258 (PR #5361)
Closed #5361. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5361#event-15940890391 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Make preferences page editable without clicking 'Edit Preferences' (PR #5449)
Merged #5449 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5449#event-15940564235 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Resourceful routes for users api (PR #5433)
Looks good to me. Merged, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5433#issuecomment-2592788092 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Override bootstrap's box-shadow effect on search field & sidebar buttons (PR #4176)
Closed #4176. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4176#event-15940846844 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Yatharths11/issue5258 (PR #5361)
Thank you @Yatharths11 for making your pull request to this project! Unfortunately, as @hlfan has pointed out, it doesn't quite resolve the problem. You need to change your code, as he describes. Please feel free to either reopen this PR when you have made the fix, or you could open a new PR in
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc commented on this pull request. > + if accumulated_length >= max_length +node.remove unless !last_child.nil? && last_child.ancestors.include?(node) +next + end + + next unless node.children.empty? + + accumulated_length += node.text? ? node.text.length
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
PR was updated. Truncation logic was moved to `RichText::Base` and now `.to_html` can take truncation length as an argument (if not provided, full content will be displayed). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5121#i
Re: [openstreetmap/openstreetmap-website] Adds description and author_id methods to Note (PR #5494)
@nenad-vujicic pushed 2 commits. 2c19c2143ec51e507d19b41fb6c89454b3d83dfc Changed note's first comment body to description 11e0444f363a08a08b730a169f56617cd9885315 Added unit tests for new Note methods -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5494/file
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. 12fee32c04e44aebca2ea778c48b6bf6270f9816 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/f10083a9c6263ff5b475e212b
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. f10083a9c6263ff5b475e212ba4746e192e7b844 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/ad9dcfe1f5fa59b88aaf2af1c
Re: [openstreetmap/openstreetmap-website] Removed unused translations in preferences.show (PR #5503)
Merged #5503 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5503#event-15949878265 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Removed unused translations in preferences.show (PR #5503)
Thanks, these translations are in activerecord attributes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5503#issuecomment-2594245775 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Use resourceful route for user status (PR #5437)
Moved user soft destroy to `put user_status_path(user, :event => "soft_destroy")`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5437#issuecomment-2594143767 You are receiving this because you are subscribed to this thread. Mes
[openstreetmap/openstreetmap-website] Fixes translation key in TermsController (PR #5504)
PR updates translation key which holds URL for redirecting in TermsController. Probably forgotten to update in 606b5c1 where translation keys were changed. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5504 -- Commit
[openstreetmap/openstreetmap-website] Removed unused translations in preferences.show (PR #5503)
After merging 967e6d4 preferences.show.{preferred_editor, preferred_languages} are not used anymore. PR removes these translation keys. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5503 -- Commit Summary -- * Rem
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@AntonKhorev requested changes on this pull request. > @@ -116,6 +116,7 @@ L.OSM.Map = L.Map.extend({ } else { this.removeLayer(this.baseLayers[i]); } + this.fire("baselayerchange", { layer: this.baseLayers[i] }); This fires the event for every possible base layer. I
Re: [openstreetmap/openstreetmap-website] Fixes translation key in TermsController (PR #5504)
Is this branch reachable now? We don't show the terms page to unregistered users after the signup redesign, therefore `current_user` should be set. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5504#issuecomment-2594258074 You a
Re: [openstreetmap/openstreetmap-website] Home Location page (PR #4926)
@AntonKhorev pushed 4 commits. d83a9a941c2d20b58e50548cc5fbec7538d755c4 Add empty account home page 27e7be4ea5032618e50d37376f7d4ecb6d2c061d Show/hide marker in account home js controller 4e764cfcc167478f05016a09126701793af500bb Add "Go to Home Location" to every page, link it to account home
Re: [openstreetmap/openstreetmap-website] Home Location page (PR #4926)
@AntonKhorev pushed 2 commits. 20ee51b894e603d5d98a2dbc5b48a180e45ea5e1 Add "Go to Home Location" to every page, link it to account home page db48062ce112386ed7a6bfcedede2e397e78db7b Show alert on account home page if home location is not set -- View it on GitHub: https://github.com/openstre
[openstreetmap/openstreetmap-website] Bump osm-community-index from 5.9.0 to 5.9.1 (PR #5502)
Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.9.0 to 5.9.1.Release notes
Sourced from osm-community-index's releases.
v5.9.1
Re: [openstreetmap/openstreetmap-website] Queries and keys controllers in features namespace (PR #5024)
@AntonKhorev pushed 2 commits. 4af2db85c40df9e09862b32ebae362427df84aac Rename browse controller to features/queries controller fd029a6f3fd54c418a3c32a591031364e292b489 Move map key to features/keys controller -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/
Re: [openstreetmap/openstreetmap-website] Use resourceful route for user status (PR #5437)
@AntonKhorev pushed 1 commit. 8db2ff289f2bd0927fdcdc5bcb6ec33126d27faa Use resourceful route for user status -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5437/files/250b032b947f80385de2e96ce7eb3e682e6a16db..8db2ff289f2bd0927fdcdc5bcb6ec33126d27faa You are re
Re: [openstreetmap/openstreetmap-website] Show changeset element counts using badges (PR #4872)
@AntonKhorev pushed 2 commits. ce19596da3f7ba2a1b7bcbbc36a8e78c340c454d Remove type_and_paginated_count helper 31f93077f96c9f5d04f2c9ff17ab4a4a662f2579 Show changeset element counts using badges -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4872/files/ad5fa
Re: [openstreetmap/openstreetmap-website] Sticky close button (PR #4825)
@AntonKhorev pushed 2 commits. af3397df25bcd5c51599ac678d6413d5a00357cc Make left sidebar close button sticky fce22582a94f2fdd7776b9084db8c9c48153238d Make right sidebar close button sticky -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4825/files/e4498d7c656
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman commented on this pull request. > @@ -116,6 +116,7 @@ L.OSM.Map = L.Map.extend({ } else { this.removeLayer(this.baseLayers[i]); } + this.fire("baselayerchange", { layer: this.baseLayers[i] }); Implemented a check that there is already a layer on the map. B
[openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)
A cleaner, class-based variant of #5426, enabling moving more logic out of `layeradd` into `initialize`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5505 -- Commit Summary -- * Add class based dark map mode logi
Re: [openstreetmap/openstreetmap-website] Use resourceful route for user status (PR #5437)
> what if we do `@user.soft_destroy!` inside `update` too? OK, that sounds like a good compromise to me! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5437#issuecomment-2593753133 You are receiving this because you are subscribe
Re: [openstreetmap/openstreetmap-website] Use map tiles dark mode from leaflet-osm plugin (PR #5426)
Yes, however, I can already hear the question "why are you adding a no-dark-filter class to the cyclemap that only sets filter:none instead of inheriting filter:none?" coming up in the new PR, as this doesn't need half of the changes here. -- Reply to this email directly or view it on GitHub:
Re: [openstreetmap/openstreetmap-website] Bump allowed ECMAScript version to 2022 (ES13) (PR #5421)
> Looks like there is one feature in 2022 that is an issue for Safari 15 and > the Chrome 87/92 outliers are also a bit more limited but of the rest is OK I > think? That's how I'm reading it too. I'm not sure why some people might be on those old versions, my guess is that upgrades are blocked
Re: [openstreetmap/openstreetmap-website] Discard jobs when then encounter a deserialization error (PR #4323)
I'm just coming back to this one, and perhaps there might be a way forward. The [API docs show](https://edgeapi.rubyonrails.org/classes/ActiveJob/Exceptions/ClassMethods.html#method-i-discard_on) that `discard_on` can take a block, which allows us to access both the error and the job. So could
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
Okay, I added the `baselayerchange` firing. So, when changing D/N/G, the update does not work now, so firing `overlaylayerchange` is better done in a separate PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc pushed 1 commit. 09f4fb63448798f0698efa82052576005ab6a533 Provide a truncated view of recent diaries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/f5a5cfc94be4aa89137401a308a7716effa640f5..09f4fb63448798f0698efa82052576005ab6a533 You are re
Re: [openstreetmap/openstreetmap-website] Use map tiles dark mode from leaflet-osm plugin (PR #5426)
> As it stands this only works correctly for the transport layer that has a > dark variant - for all other layers it disables the filtering when in dark > mode. I think it's important here to note that we decided in #5328 that only filters approved by the cartographers should be applied. Since
Re: [openstreetmap/openstreetmap-website] Bump allowed ECMAScript version to 2022 (ES13) (PR #5421)
> I note that ECMAScript 2021 seems to be fully supported across all the > mentioned browser versions. So should we target that version instead? All is better the the current state :) Should not rule out many useful APIs. -- Reply to this email directly or view it on GitHub: https://github.com
