Merged #5457 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5457#event-15801427611
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Creates a nested `reply` resource for messages.
Changes reply path from `/messages/:id/reply` to `/messages/:id/reply/new`
because it's a new reply.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5458
-- Commit Summ
@AntonKhorev pushed 1 commit.
4bd95493b169dadfcebe45364ecbf156a76f9a9e Use resourceful route for message
reply
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5458/files/1c3605d78f0ee0a6cfba650fb5cf5c82c0fcafed..4bd95493b169dadfcebe45364ecbf156a76f9a9e
You are
@AntonKhorev commented on this pull request.
> + scope "/user/:display_name" do
+resource :follow, :only => [:create, :destroy, :edit], :path => "follow"
+ end
Still no redirects. Old `make_friend` urls in emails are going to be broken.
--
Reply to this email directly or view it on GitH
Merged #5456 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5456#event-15801427603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5455 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5455#event-15801427614
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
This mostly looks good but it turns out it fails when applied on top of #5457
as the reply route no longer works properly when combined with the change to
new.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
@AntonKhorev commented on this pull request.
> + before_action :check_database_writable, :only => [:create, :destroy, :edit]
+ before_action :lookup_friend, :only => [:create, :destroy, :edit]
Do you need `:only` here? It lists all of the actions.
--
Reply to this email directly or view it
@AntonKhorev commented on this pull request.
> + belongs_to :befriender, :class_name => "User", :foreign_key => :user_id,
> :inverse_of => :follows
+ belongs_to :befriendee, :class_name => "User", :foreign_key =>
:friend_user_id, :inverse_of => :follows
We probably want to keep the existing
I suspect that's some ancient history... Look good to me anyway, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5455#issuecomment-2568212668
You are receiving this because you are subscribed to this thread.
Message ID:
_
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5456#issuecomment-2568217016
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5457#issuecomment-2568218960
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes commented on this pull request.
> @@ -27,14 +27,10 @@ def block_status(block)
def block_short_status(block)
if block.active?
- if block.needs_view?
-if block.ends_at > Time.now.utc
- t("user_blocks.helper.short.active_unread")
-else
- t
13 matches
Mail list logo
