@AntonKhorev commented on this pull request.


> +  belongs_to :befriender, :class_name => "User", :foreign_key => :user_id, 
> :inverse_of => :follows
+  belongs_to :befriendee, :class_name => "User", :foreign_key => 
:friend_user_id, :inverse_of => :follows

We probably want to keep the existing db column names like `friend_user` for 
now, but what about `:befriender` and `:befriendee`? Currently you have code 
like this, mixing "follow" and "friend" terminology:

```ruby
Follow.find_by(:befriender => user, :befriendee => follow)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2527347738
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5261/review/2527347...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to