@AntonKhorev pushed 1 commit.
1723730a9efbe80c5e3dc94cd758726bf4ff3e52 Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/cc319be3414e2d2b94cb10c871cc66b541d87a08..1723730a9efbe80c5e3dc94cd758726bf4ff3e52
You are receiving this
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
@AntonKhorev pushed 1 commit.
cc319be3414e2d2b94cb10c871cc66b541d87a08 Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/45bbc3bbc6c615cb2509e08e36de018fabf987fe..cc319be3414e2d2b94cb10c871cc66b541d87a08
You are receiving this
> These are good reasons why the paginator doesn't have to be cursor-based, but
> they aren't reasons why it can't be cursor-based. So I think the
> simplification of only having one type of pagination is worthwhile.
Those were reasons for why this place is different, why it might be feasible
n
@AntonKhorev pushed 1 commit.
45bbc3bbc6c615cb2509e08e36de018fabf987fe Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/1c414a44d49d43389b814e9ed1b3de4dab9f8135..45bbc3bbc6c615cb2509e08e36de018fabf987fe
You are receiving this
No.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205#issuecomment-2391499574
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
Do you also propose to remove the ability to see how many elements of each type
were changed?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205#issuecomment-2391412344
You are receiving this because you are subscribed to this t
> Do you propose to remove the ability to go to page N?
Sure, I don't see a strong need for that. Particularly if the order hasn't been
defined before.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205#issuecomment-2391257307
> These are good reasons why the paginator doesn't have to be cursor-based, but
> they aren't reasons why it can't be cursor-based. So I think the
> simplification of only having one type of pagination is worthwhile.
Do you propose to remove the ability to go to page N?
--
Reply to this email
> Shouldn't we just be converting changesets to use the same pagination logic
> as everything else, rather than copying parts of classic pagination into the
> controller just so we can pretend we got rid of it?
I agree.
> * Changesets have an upper bound on the number of elements. There can be
@AntonKhorev pushed 1 commit.
1c414a44d49d43389b814e9ed1b3de4dab9f8135 Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/8acfc36fcb94abec9bcbce4152b830f63943a0be..1c414a44d49d43389b814e9ed1b3de4dab9f8135
You are receiving this
> Shouldn't we just be converting changesets to use the same pagination logic
> as everything else
That depends on how significant are the differences between changeset elements
and everything else. The differences are:
- Changesets have an upper bound on the number of elements. There can be a
@AntonKhorev pushed 1 commit.
8acfc36fcb94abec9bcbce4152b830f63943a0be Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/2637e79ddbdd4f4e9e04e7b6175c3ff16f2e9ca6..8acfc36fcb94abec9bcbce4152b830f63943a0be
You are receiving this
13 matches
Mail list logo
