Re: [openstreetmap/openstreetmap-website] I have created workflow to generate .IMG of OSM maps for Garmin eTrex devices. (Issue #6296)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6296) What does any of that have to do with this repository though? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6296#issuecomment-3156870581 You are receiving thi

Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#2799) So I now have the necessary keys to test things out locally and there's a bit of a hickup... Apple insist on using `response_mode=form_post` in the OAuth 2 exchange if you want to ask for the `name` or `email` scopes but that me

Re: [openstreetmap/openstreetmap-website] Use as Bootstrap modal title (PR #6293)

2025-08-05 Thread Tom Hughes via rails-dev
Merged #6293 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6293#event-18996645597 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use as Bootstrap modal title (PR #6293)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6293) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6293#issuecomment-3156000288 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Replace javascript alerts with bootstrap modals (PR #6268)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6268) The unconfigured iD one might as well be modal, or just a message embedded in the page, given we can't launch it. The failed geocoding one could probably be done better in some other way I agree. -- Reply to this email direct

Re: [openstreetmap/openstreetmap-website] Instantiate js controllers only in router (PR #6291)

2025-08-05 Thread Tom Hughes via rails-dev
Merged #6291 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6291#event-18996460235 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Instantiate js controllers only in router (PR #6291)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6291) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6291#issuecomment-3155905201 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Test logout after using turbo pagination (PR #6292)

2025-08-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6292) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6292#issuecomment-3155893581 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (2) (PR #6286)

2025-08-04 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6286) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6286#issuecomment-3151843207 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (2) (PR #6286)

2025-08-04 Thread Tom Hughes via rails-dev
Merged #6286 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6286#event-18975941044 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix the build by adding Arpitan as UI language (PR #6288)

2025-08-04 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6288) Thanks for working on this @pablobm but on this occasion I'm going to take #6289 as it preserves the correct ordering. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website

Re: [openstreetmap/openstreetmap-website] Add Arpitan to ui languages list (PR #6289)

2025-08-04 Thread Tom Hughes via rails-dev
Merged #6289 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6289#event-18975917284 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix the build by adding Arpitan as UI language (PR #6288)

2025-08-04 Thread Tom Hughes via rails-dev
Closed #6288. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6288#event-18975910956 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add Arpitan to ui languages list (PR #6289)

2025-08-04 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6289) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6289#issuecomment-3151836853 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Revert addition of past usernames to profile pages (Issue #6290)

2025-08-04 Thread Tom Hughes via rails-dev
Closed #6290 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6290#event-18975851049 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Revert addition of past usernames to profile pages (Issue #6290)

2025-08-04 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6290) As @AntonKhorev says we don't actually know what previous usernames a user has used as we don't store them, so this is nothing to do with us. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Flatten DownloadUtil (PR #6285)

2025-08-03 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6285) > I have to say that I'm a bit surprised to see the Promise pipelines sneaking > in again, after we've been discussing the point in #6192. I probably never even read that discussion between you and @hlfan so it's not surprising

Re: [openstreetmap/openstreetmap-website] Replace javascript alerts with bootstrap modals (PR #6268)

2025-08-03 Thread Tom Hughes via rails-dev
@tomhughes pushed 5 commits. ece2b0d93bb38460d5c3e85283cbf8d557157bd7 Move showAlert function out of download utilities 6628d8a57b1395dbb92b1f65741268f1024cc9ff Move export failed message to the title of the alert 1e074c410b1da39b6a7930db04c5d0b575877718 Use modal alert when remote editing f

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (Issue #6093)

2025-08-03 Thread Tom Hughes via rails-dev
Closed #6093 as completed via #6111. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6093#event-18958770756 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Flatten DownloadUtil (PR #6285)

2025-08-03 Thread Tom Hughes via rails-dev
Merged #6285 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6285#event-18958770687 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Flatten DownloadUtil (PR #6285)

2025-08-03 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6285) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6285#issuecomment-3148602734 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)

2025-08-03 Thread Tom Hughes via rails-dev
Merged #6111 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6111#event-18958770689 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)

2025-08-03 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6111) Thanks for all the fixes... I think this is probably good to merge now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6111#issuecomment-3148599082 You are recei

Re: [openstreetmap/openstreetmap-website] Handle html error message for map xml export (PR #6284)

2025-08-03 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. >} OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler; + OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler; I was thinking much the same things when I looked at this, namely why are we defining things in a private clas

Re: [openstreetmap/openstreetmap-website] Use more form helpers (PR #6280)

2025-08-02 Thread Tom Hughes via rails-dev
Merged #6280 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6280#event-18950439365 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Rework map element click handling (PR #6281)

2025-08-02 Thread Tom Hughes via rails-dev
Merged #6281 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6281#event-18950439339 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] History: Dragging selects changeset (Issue #6264)

2025-08-02 Thread Tom Hughes via rails-dev
Closed #6264 as completed via #6281. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6264#event-18950439566 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Rework map element click handling (PR #6281)

2025-08-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6281) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6281#issuecomment-3146436735 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Use more form helpers (PR #6280)

2025-08-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6280) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6280#issuecomment-3146434887 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Fix typo in importer role icon tooltip. (PR #6279)

2025-08-01 Thread Tom Hughes via rails-dev
Merged #6279 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6279#event-18945778188 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix typo in importer role icon tooltip. (PR #6279)

2025-08-01 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6279) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6279#issuecomment-3145565723 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Update community forum icon (PR #6278)

2025-08-01 Thread Tom Hughes via rails-dev
Merged #6278 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6278#event-18943413901 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Update community forum icon (PR #6278)

2025-08-01 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6278) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6278#issuecomment-3145174890 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Bump osm-community-index from 5.9.2 to 5.9.3 (PR #6277)

2025-08-01 Thread Tom Hughes via rails-dev
Merged #6277 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6277#event-18943413928 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Support interactive debugger with docker-compose (PR #5851)

2025-07-31 Thread Tom Hughes via rails-dev
Merged #5851 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5851#event-18924914010 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)

2025-07-31 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > - * 'Upload GPS traces' - * 'Modify notes' -* On the next page, copy the "Client ID" -* Edit config/settings.local.yml in your rails tree -* Add the "id_application" configuration with the "Client ID" as the value -* Restart your rails server - -An

Re: [openstreetmap/openstreetmap-website] Restrict marker scaling to search results (PR #6270)

2025-07-31 Thread Tom Hughes via rails-dev
Merged #6270 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6270#event-18924328806 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Support interactive debugger with docker-compose (PR #5851)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5851) As I don't use docker and I've never used the interactive debugger it's hard for me to comment on this, and would need a lot of work for me to even test it so I think I'm going to rely on @nenad-vujicic having tested it and the

Re: [openstreetmap/openstreetmap-website] Restrict marker scaling to search results (PR #6270)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6270) It's still there for the search results, which is the only place we intended to have it. My original thought when it happening elsewhere was raised yesterday was that it probably does make sense for notes as well but @hlfan has

Re: [openstreetmap/openstreetmap-website] Add display:block to the editor iframe (PR #6274)

2025-07-31 Thread Tom Hughes via rails-dev
Merged #6274 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6274#event-18924328808 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Move more styling from CSS to Bootstrap (PR #6271)

2025-07-31 Thread Tom Hughes via rails-dev
Merged #6271 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6271#event-18924328785 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add display:block to the editor iframe (PR #6274)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6274) I don't know how to reproduce the original problem so I'll have to take your word for it that this is a fix - certainly it doesn't cause any issues I can see. -- Reply to this email directly or view it on GitHub: https://githu

Re: [openstreetmap/openstreetmap-website] Add funding.json and .well-known/funding-manifest-urls (PR #6275)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6275) Thinking about it this will probably have to be done via https://github.com/openstreetmap/chef/ and not here as we don't want other people running this code to be publishing this without realising. Frankly the whole thing of pu

Re: [openstreetmap/openstreetmap-website] Add funding.json and .well-known/funding-manifest-urls (PR #6275)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6275) Who has verified/signed off on all this exactly? Financial details have presumably been checked with the treasurer? Have MWG checked the details of the membership tiers? Note sure how @Firefishy will feel about continuing to pr

Re: [openstreetmap/openstreetmap-website] Move more styling from CSS to Bootstrap (PR #6271)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6271) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6271#issuecomment-3140814413 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Restrict marker scaling to search results (PR #6270)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6270) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6270#issuecomment-3140807707 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Add interactive debugging support for docker-compose (Issue #6273)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6273) Opening issues that duplicate PRs just creates more work for maintainers who have to close them, or more likely will forget leaving a stale issue lying open. That's especially true when the issue is opened after the PR so that P

Re: [openstreetmap/openstreetmap-website] Add interactive debugging support for docker-compose (Issue #6273)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6273) Why are you opening an issue that duplicates an existing PR? There's no need for both. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6273#issuecomment-313961

Re: [openstreetmap/openstreetmap-website] Add interactive debugging support for docker-compose (Issue #6273)

2025-07-31 Thread Tom Hughes via rails-dev
Closed #6273 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6273#event-18917565671 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Documenting database structure (Issue #6272)

2025-07-31 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6272) There's a massive comment at the top of each model already that documents it? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6272#issuecomment-3139511296 You a

Re: [openstreetmap/openstreetmap-website] Fix message reuse on account terms page (PR #6269)

2025-07-30 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6269) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6269#issuecomment-3137884754 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Fix message reuse on account terms page (PR #6269)

2025-07-30 Thread Tom Hughes via rails-dev
Merged #6269 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6269#event-18907917007 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] Replace javascript alerts with bootstrap modals (PR #6268)

2025-07-30 Thread Tom Hughes via rails-dev
This builds on the work from #6263 by replacing all other uses of `alert` with bootstrap modals. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6268 -- Commit Summary -- * Move showAlert function out of download ut

Re: [openstreetmap/openstreetmap-website] Retire jquery-simulate (2) (PR #6267)

2025-07-30 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6267) The downside of the approach here is that it has to make assumptions about what modifiers do which may not be true in all browsers... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openst

Re: [openstreetmap/openstreetmap-website] Retire jquery-simulate (2) (PR #6267)

2025-07-30 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6267) The title is a bit misleading really because jquery-simulate has already been retired - this is really an alternate way to replace it to avoid the issues with dragging the map reported in #6264. -- Reply to this email directly

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

2025-07-29 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6236) @petr-hajek well as far as I'm concerned it's ready but as I wrote it I prefer not to merge it myself. I've just simplified it in fact now my upstream fix for sticky attributions is deployed. -- Reply to this email directly o

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

2025-07-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 1 commit. 8e8b07447f41e8804b93b8d1f479c24db922b9f4 Use our custom attribution string for vector layers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6236/files/587b91b7ce7de423c3ade6538f8d53b5a0fec888..8e8b07447f41e8804b93b8d1f479c24db922b9

Re: [openstreetmap/openstreetmap-website] Zooming out all the way on vector layer causes glitches (Issue #6233)

2025-07-29 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6233) Yes I deployed it - it looked better for me though possibly still not perfect. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6233#issuecomment-3133597522 You

Re: [openstreetmap/openstreetmap-website] Zooming out all the way on vector layer causes glitches (Issue #6233)

2025-07-29 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6233) I've updated that now... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6233#issuecomment-3133574331 You are receiving this because you are subscribed to this

Re: [openstreetmap/openstreetmap-website] Fix vector tile attribution issues (PR #6236)

2025-07-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 1 commit. 587b91b7ce7de423c3ade6538f8d53b5a0fec888 Fix vector layer attribution issues -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6236/files/7a2513e613fc6c0ca076f8034e892c4d05882f75..587b91b7ce7de423c3ade6538f8d53b5a0fec888 You are receiv

Re: [openstreetmap/openstreetmap-website] Element history: Add last edited button to tags list (Issue #6266)

2025-07-29 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6266) What's all the nonsense about "placeholder issue" here? Are you using some sort of tool to open issues that has added that text? The problem with this suggestion is that it's very expensive because it requires us to process the

Re: [openstreetmap/openstreetmap-website] Bootstrap modal instead of alert() (PR #6263)

2025-07-28 Thread Tom Hughes via rails-dev
Merged #6263 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6263#event-18863156008 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Invert icons in dark mode with common class (PR #6052)

2025-07-28 Thread Tom Hughes via rails-dev
Closed #6052 via #6262. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6052#event-18863156361 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-de

Re: [openstreetmap/openstreetmap-website] Remove hard-coded stuff in header (PR #6262)

2025-07-28 Thread Tom Hughes via rails-dev
Merged #6262 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6262#event-18863156067 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bootstrap modal instead of alert() (PR #6263)

2025-07-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6263) Oh sure I wasn't going to make them autohide but you're right there's probably not much difference between a non-autohide toast and a modal. This looks good to me I think. -- Reply to this email directly or view it on GitHub:

Re: [openstreetmap/openstreetmap-website] Remove hard-coded stuff in header (PR #6262)

2025-07-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6262) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6262#issuecomment-3128799787 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

2025-07-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6234) Unfortunately matomo doesn't give us any numbers for WebGL versions, just WebGL as a whole. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3

Re: [openstreetmap/openstreetmap-website] Bootstrap modal instead of alert() (PR #6263)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6263) I was considering this myself but I was looking at toasts for this... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6263#issuecomment-3124688707 You are receivi

Re: [openstreetmap/openstreetmap-website] Always show marker shadows (PR #6261)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6261 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6261#event-18840480205 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6235 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6235#event-18840480210 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Make handler able to handle SVG links (PR #6260)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6260 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6260#event-18840480197 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Always show marker shadows (PR #6261)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6261) Yes I'm not sure there was any good reason why some markers has shadows and some didn't, so this looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6235) I fear we might get some complaints that this is a bit garish but lets give it a go and see what happens... Thanks for all the work on it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/o

Re: [openstreetmap/openstreetmap-website] Make handler able to handle SVG links (PR #6260)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6260) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6260#issuecomment-3124465729 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Lower max allowed blank line count (PR #6258)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6258 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6258#event-18840346079 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6235) Maybe the markers should get larger when you mouse over them, to match what happens when you mouse over the list entries? It would help make it obvious which marker you were over when several are close together? -- Reply to th

Re: [openstreetmap/openstreetmap-website] Lower max allowed blank line count (PR #6258)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6258) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6258#issuecomment-3124445668 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] "Known passwords" text appearing when zooming out in central Berlin (Issue #6259)

2025-07-27 Thread Tom Hughes via rails-dev
Closed #6259 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6259#event-18840119560 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] "Known passwords" text appearing when zooming out in central Berlin (Issue #6259)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6259) This is not a software issue that is appropriate for this tracker. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6259#issuecomment-3124404988 You are receivin

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6255) Thanks... I think this looks good then. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6255#issuecomment-3124301416 You are receiving this because you are subscr

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6255 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6255#event-18839575014 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

2025-07-27 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > + try { +detailMessage = event?.detail?.error?.message; +if (!detailMessage) { + const responseText = await event.detail.fetchResponse.responseText; + const parser = new DOMParser(); + const doc = parser

Re: [openstreetmap/openstreetmap-website] Make search show multiple markers (PR #6235)

2025-07-27 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. >} function showSearchResult() { -let marker = $(this).data("marker"); - -if (!marker) { - const data = $(this).find("a.set_position").data(); - - marker = L.marker([data.lat, data.lon], { icon: OSM.getMarker({}) }); - -

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6197 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6197#event-18839263448 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Support Panoramax in feature links (browse tags helper) (Issue #5200)

2025-07-27 Thread Tom Hughes via rails-dev
Closed #5200 as completed via #6197. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5200#event-18839263576 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Display a link for mapillary keys (#986)

2025-07-27 Thread Tom Hughes via rails-dev
Closed #986 as completed via #6197. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/986#event-18839263524 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] link ref:IE:smr value (Issue #3920)

2025-07-27 Thread Tom Hughes via rails-dev
Closed #3920 as completed via #6197. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3920#event-18839263561 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Link to openplaques (#2405)

2025-07-27 Thread Tom Hughes via rails-dev
Closed #2405 as completed via #6197. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2405#event-18839263544 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

2025-07-27 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. This looks good to me now. Thanks for working on it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6197#pullrequestreview-3059426301 You are receiving this because you are subscribed to t

Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.31.0 to 9.32.0 (PR #6253)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6253 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6253#event-18839176176 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add native links to HistoryChangesetsLayer (PR #6254)

2025-07-27 Thread Tom Hughes via rails-dev
Merged #6254 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6254#event-18839176169 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)

2025-07-27 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > + try { +detailMessage = event?.detail?.error?.message; +if (!detailMessage) { + const responseText = await event.detail.fetchResponse.responseText; + const parser = new DOMParser(); + const doc = parser

Re: [openstreetmap/openstreetmap-website] Retire jquery-simulate (PR #6252)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6252) I just tried it again and neither shift-click or ctrl-click seems to work for my in firefox or chrome on linux. I agree that #6254 is a better solution anyway so I don't think we need to investigate further. -- Reply to this

Re: [openstreetmap/openstreetmap-website] Add native links to HistoryChangesetsLayer (PR #6254)

2025-07-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6254) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6254#issuecomment-3124239091 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Muted users can still communicate via Notes (Issue #6257)

2025-07-26 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6257) Well there is a general wish to integrate notifications with messaging, which would probably fix this, but it needs quite a bit of work. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/ope

Re: [openstreetmap/openstreetmap-website] Muted users can still communicate via Notes (Issue #6257)

2025-07-26 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6257) Well muting is a feature of user-user messaging and notifications of note/changeset/diary comments have nothing to do with user-user messaging. Nobody ever claimed that muting would stop you being notified of comments on other

Re: [openstreetmap/openstreetmap-website] Use SVG marker in embed (PR #6251)

2025-07-25 Thread Tom Hughes via rails-dev
Merged #6251 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6251#event-18822312768 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use SVG marker in embed (PR #6251)

2025-07-25 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6251) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6251#issuecomment-3120472059 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Overwrite marker shadow interactability (PR #6250)

2025-07-25 Thread Tom Hughes via rails-dev
Merged #6250 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6250#event-18822312744 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Overwrite marker shadow interactability (PR #6250)

2025-07-25 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6250) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6250#issuecomment-3120465926 You are receiving this because you are subscribed to this t

  1   2   3   4   5   6   7   8   9   10   >