Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb with layers.yml (PR #5571)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > <% end %> }; var map = L.map("map"); map.attributionControl.setPrefix(""); map.removeControl(map.attributionControl); - if (args.layer === "cyclosm") { -new L.OSM.CyclOSM().addTo(map); - } else if (args.layer === "cyclemap" || a

Re: [openstreetmap/openstreetmap-website] Don't remove-readd standard layer with visible overlays (PR #5573)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5573 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5573#event-16112442645 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. 358417ee2aa7313178ec906c9985dfb7a6b92756 Update eslint to prefer let/const over var 4e28e7f5fd4b5f1037f25528b1f0f7909ba836d9 Replace uses of var with let or const as appropriate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/555

Re: [openstreetmap/openstreetmap-website] Abort loading when data layer is removed (PR #5575)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5575 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5575#event-16112528023 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-29 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. f52db008232c71a23d3f7990b8168d36af952576 Update eslint to prefer let/const over var 728d9910a1bdb88b46514536985262de716931d5 Replace uses of var with let or const as appropriate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/555

Re: [openstreetmap/openstreetmap-website] Remove unnecessary wrapper divs from data layer error message (PR #5574)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5574 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5574#event-16112442642 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Abort loading when note layer is removed (PR #5577)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5577 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5577#event-16112442640 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Show only description as a marker tooltip in note layer (PR #5576)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5576 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5576#event-16112442654 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Select user ids from reports using pluck (PR #5578)

2025-01-29 Thread Tom Hughes via rails-dev
Merged #5578 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5578#event-16112442646 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Select user ids from reports using pluck (PR #5578)

2025-01-29 Thread Tom Hughes via rails-dev
It should also mean that the `uniq` becomes part of the database query I think. Looks good to me in any case! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5578#issuecomment-2622523134 You are receiving this because you are subs

Re: [openstreetmap/openstreetmap-website] Abort loading when note layer is removed (PR #5577)

2025-01-29 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5577#issuecomment-2622520423 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Show only description as a marker tooltip in note layer (PR #5576)

2025-01-29 Thread Tom Hughes via rails-dev
Hopefully this will stop being a problem once the notes schema migration is complete but this looks fine as a temporary fix. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5576#issuecomment-2622517773 You are receiving this becau

Re: [openstreetmap/openstreetmap-website] Remove unnecessary wrapper divs from data layer error message (PR #5574)

2025-01-29 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5574#issuecomment-2622514227 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Don't remove-readd standard layer with visible overlays (PR #5573)

2025-01-29 Thread Tom Hughes via rails-dev
I can't reproduce the blink in Firefox, but the code looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5573#issuecomment-2622512125 You are receiving this because you are subscribed to this thread. Message

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

2025-01-29 Thread Tom Hughes via rails-dev
The phrase "reporting user" as in the title of this PR makes more sense than "reporter user" that is actually used... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2622097897 You are receiving this because you

Re: [openstreetmap/openstreetmap-website] Repo: editor help to find eslint config file (Issue #5572)

2025-01-29 Thread Tom Hughes via rails-dev
> Other than that, what I find useful many times is the amazing [just command > runner](https://github.com/casey/just) that is multi-platform. If you often > find yourself executing the same command in the terminal, this might be > useful such that everybody can do something like `just lint js`.

Re: [openstreetmap/openstreetmap-website] Repo: editor help to find eslint config file (Issue #5572)

2025-01-29 Thread Tom Hughes via rails-dev
My vote would be for `.vscode/settings.json` because a hidden file doesn't really pollute the root folder in a meaningful way. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976179 You are receiving this b

Re: [openstreetmap/openstreetmap-website] Replace info message with clearer version (PR #5569)

2025-01-28 Thread Tom Hughes via rails-dev
Closed #5569. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5569#event-16100820377 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Replace info message with clearer version (PR #5569)

2025-01-28 Thread Tom Hughes via rails-dev
Changes to iD need to be filed at https://github.com/openstreetmap/iD. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5569#issuecomment-2620302652 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] DataLayer to consume JSON format responses (PR #5563)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5563 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5563#event-16098071837 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-28 Thread Tom Hughes via rails-dev
Does that vscode config file work automatically? It seems like an unlikely location for it to be found? I thought `.vscode/settings.json` was the location for workspace setting to be picked up automatically... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] DataLayer to consume JSON format responses (PR #5563)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5563#issuecomment-2619803933 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-01-28 Thread Tom Hughes via rails-dev
@tomhughes pushed 5 commits. df227ee2742e454f6c20a5025c6324e40eb27662 Drop support for ruby 3.1 a38e5a9584748a8465dc3084eaba00b4d9829627 Update to rails 8.0.1 bf682f34acb6ab4b82829f39b66f7654a97447e8 Avoid parsing of XML requests with ; in the body d09621c354d381c8a380a8c97444f21532205a33 Use

Re: [openstreetmap/openstreetmap-website] Remove layersAdded variable from map.updateLayers() (PR #5560)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5560 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5560#event-16097798961 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove IE conditional compilation that limited max features (PR #5565)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5565 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5565#event-16097798975 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove unused max_features parameter from feature warning (PR #5566)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5566 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5566#event-16097798944 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Removes author_{id, ip} methods from Note model (PR #5568)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5568 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5568#event-16097798945 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.5 to 2.3.6 (PR #5564)

2025-01-28 Thread Tom Hughes via rails-dev
Merged #5564 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5564#event-16097798955 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Removes author_{id, ip} methods from Note model (PR #5568)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5568#issuecomment-2619769695 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove IE conditional compilation that limited max features (PR #5565)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5565#issuecomment-2619749568 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove layersAdded variable from map.updateLayers() (PR #5560)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5560#issuecomment-2619761711 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove unused max_features parameter from feature warning (PR #5566)

2025-01-28 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5566#issuecomment-2619752956 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove jquery-simulate (PR #5567)

2025-01-28 Thread Tom Hughes via rails-dev
Is that replacement something new that didn't exist when `simulate` was created? or does it have limitations compared to `simulate` that we were trying to avoid? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5567#issuecomment-2

Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)

2025-01-27 Thread Tom Hughes via rails-dev
Merged #5561 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#event-1608300 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)

2025-01-27 Thread Tom Hughes via rails-dev
Merged #5562 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#event-1608301 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Increase the limit when a warning about a large number of objects is displayed (PR #5562)

2025-01-27 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5562#issuecomment-2616706362 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Close button for loading error alert (PR #5561)

2025-01-27 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5561#issuecomment-2616704016 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-27 Thread Tom Hughes via rails-dev
Can we keep this on topic please... I have no idea what holes you are referring to in any case - we made the decision to allow newer JS features and knew full well that might affect a very small number of people using old browsers but in any case this is not the place to discuss it. Until @maro

Re: [openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. 776459a0a092f06fbab170db456292236c9e8de9 Drop ES6 polyfill 22b00228639e58c7a9ad2991d3d4993a5fff101f Drop IE specific favicon support -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5556/files/ac1b98acae13ffd1e7680e30833be80c0c0ad81

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-26 Thread Tom Hughes via rails-dev
Shouldn't this update `yarn.lock` as well as `package.json`? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2614555995 You are receiving this because you are subscribed to this thread. Message ID: _

[openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

2025-01-26 Thread Tom Hughes via rails-dev
This updates the eslint config to prohibit use of `var` and to prefer `const` over `let` and then fixes all uses of `var` to respect that. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5558 -- Commit Summary -- *

[openstreetmap/openstreetmap-website] Drop some legacy browser support code (PR #5556)

2025-01-26 Thread Tom Hughes via rails-dev
This drops the ES6 polyfill which is a bit pointless since #5421 allows ES2021 code now. It also drops an IE specific legacy favicon tag, which allows us to drop the dependency on the browser gem. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap

Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. This looks pretty good - just a couple of minor suggestions that I've made inline. > @@ -15,14 +15,7 @@ I18n.default_locale = <%= I18n.default_locale.to_json %>; I18n.fallbacks = true; window.onload = function () { - var query = (window.location.se

Re: [openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5536 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5536#event-16069473420 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Initialize I18n and OSM as soon as application.js loads (PR #5538)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5538 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5538#event-16069473426 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.18.0 to 9.19.0 (PR #5552)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5552 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5552#event-16069473427 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.4 to 2.3.5 (PR #5553)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5553 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5553#event-16069473415 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Added error handling for data layer (PR #5551)

2025-01-26 Thread Tom Hughes via rails-dev
Merged #5551 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5551#event-16069473422 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Added error handling for data layer (PR #5551)

2025-01-26 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5551#issuecomment-2614314619 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Initialize I18n and OSM as soon as application.js loads (PR #5538)

2025-01-26 Thread Tom Hughes via rails-dev
I thought I had merged this one the other day but apparently not... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5538#issuecomment-2614313656 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-01-26 Thread Tom Hughes via rails-dev
> I'm working on resolving this CSP violations. Right now I'm trying to > generate nonce for the .js file and use that to validate and transpass the > CSP violation. I'm not sure if it is the right approach for this since I > never had experience dealing with similar stuff before. If there is a

Re: [openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)

2025-01-26 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. Thanks - this all looks good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5536#pullrequestreview-2574191440 You are receiving this because you are subscribed to this thread. Messag

Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-25 Thread Tom Hughes via rails-dev
There haven't been any deployments for days so this is not related to #1155 at all - that was an operational issue relating to the production deployment and was something triggered by doing new deployments I believe. Nobody else has reported any problems so it seems this must be something speci

Re: [openstreetmap/openstreetmap-website] Modernize eslint config (Issue #5554)

2025-01-25 Thread Tom Hughes via rails-dev
Can you explain what this has to do with keeping the current config? Are you saying that the current config is invoking some style rules that are no longer having any effect? We'd still want to keep the other rules though? We wouldn't want to just dump the whole thing... -- Reply to this email

Re: [openstreetmap/openstreetmap-website] Create api map resource (PR #5545)

2025-01-24 Thread Tom Hughes via rails-dev
Merged #5545 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5545#event-16060343355 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Simplify write_notes scope check in api notes controller (PR #5544)

2025-01-24 Thread Tom Hughes via rails-dev
Merged #5544 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5544#event-16060343366 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Create api map resource (PR #5545)

2025-01-24 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5545#issuecomment-2612760562 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Simplify write_notes scope check in api notes controller (PR #5544)

2025-01-24 Thread Tom Hughes via rails-dev
Yes it's probably a hangover from when we had other ways to authenticate to the API that would set `current_user` but it's redundant now as you say. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5544#issuecomment-2612754242 You

Re: [openstreetmap/openstreetmap-website] Move scope_enabled? to ApiController (PR #5543)

2025-01-24 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5543#issuecomment-2612738797 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Remove doorkeeper_token branch from web deny_access (PR #5542)

2025-01-24 Thread Tom Hughes via rails-dev
Merged #5542 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5542#event-16059949993 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove doorkeeper_token branch from web deny_access (PR #5542)

2025-01-24 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5542#issuecomment-2612737801 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Move scope_enabled? to ApiController (PR #5543)

2025-01-24 Thread Tom Hughes via rails-dev
Merged #5543 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5543#event-16059950010 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix some eslint errors (quotes spacing and parseInt radix) on .js.erb files (PR #5548)

2025-01-24 Thread Tom Hughes via rails-dev
Merged #5548 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5548#event-16059932268 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix some eslint errors (quotes spacing and parseInt radix) on .js.erb files (PR #5548)

2025-01-24 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5548#issuecomment-2612735489 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Trace data resource (PR #5537)

2025-01-23 Thread Tom Hughes via rails-dev
Merged #5537 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5537#event-16048015190 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add user transient attribute to oauth factories (PR #5541)

2025-01-23 Thread Tom Hughes via rails-dev
Merged #5541 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5541#event-16048015164 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Trace data resource (PR #5537)

2025-01-23 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5537#issuecomment-2610621188 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)

2025-01-23 Thread Tom Hughes via rails-dev
@tomhughes requested changes on this pull request. > @@ -43,7 +43,7 @@ def initialize(user) can :update, DiaryEntry, :user => user can [:create], DiaryComment can [:show, :create, :destroy], Follow -can [:read, :create, :mark, :unmute, :destroy], Message +

Re: [openstreetmap/openstreetmap-website] Add user transient attribute to oauth factories (PR #5541)

2025-01-23 Thread Tom Hughes via rails-dev
I think I did it the way I did to make it consistent with the non-test code, where there is no user/resource_owner association on the access token model that doorkeeper provides, but this does make the tests a lot nicer. -- Reply to this email directly or view it on GitHub: https://github.com/o

Re: [openstreetmap/openstreetmap-website] Initialize I18n and OSM as soon as application.js loads (PR #5538)

2025-01-23 Thread Tom Hughes via rails-dev
I generally try to avoid doing anything before `ready` fires as it's hard to know what's safe but I guess this OK as `head` must have loaded in order for the javascript to load. I do wonder what #5402 is doing that it needs this before the page is ready though... -- Reply to this email directl

Re: [openstreetmap/openstreetmap-website] Set needs_view by default for new blocks (PR #5532)

2025-01-22 Thread Tom Hughes via rails-dev
Merged #5532 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5532#event-16033065459 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use flash.now for messages to be shown during this request (PR #5534)

2025-01-22 Thread Tom Hughes via rails-dev
Merged #5534 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5534#event-16033065473 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use a custom cop to check controller action names (PR #5533)

2025-01-22 Thread Tom Hughes via rails-dev
Merged #5533 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5533#event-16033065464 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Consistent usage of layer information in _osm_location cookie (PR #5529)

2025-01-22 Thread Tom Hughes via rails-dev
Merged #5529 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5529#event-16033065500 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Create changeset subscription resource (PR #5535)

2025-01-22 Thread Tom Hughes via rails-dev
Merged #5535 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5535#event-16033065440 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use a custom cop to check controller action names (PR #5533)

2025-01-22 Thread Tom Hughes via rails-dev
I don't really like bundling third party code like this, but the upstream PR doesn't seem to be going anywhere :disappointed: -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5533#issuecomment-2607933573 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] Create changeset subscription resource (PR #5535)

2025-01-22 Thread Tom Hughes via rails-dev
This looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5535#issuecomment-2607926067 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Create changeset subscription resource (PR #5535)

2025-01-22 Thread Tom Hughes via rails-dev
They were added so that we could fill in the `List-Unsubscribe` header in emails as Google had made that a requirement for gmail. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5535#issuecomment-2607920028 You are receiving this

Re: [openstreetmap/openstreetmap-website] Consistent usage of layer information in _osm_location cookie (PR #5529)

2025-01-22 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5529#issuecomment-2607909864 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Use flash.now for messages to be shown during this request (PR #5534)

2025-01-22 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5534#issuecomment-2607891586 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Set needs_view by default for new blocks (PR #5532)

2025-01-22 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5532#issuecomment-2607899405 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Add indexes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
Those indexes are all pretty tiny currently so I guess keeping them doesn't hurt. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5531#issuecomment-2605864060 You are receiving this because you are subscribed to this thread. Mess

Re: [openstreetmap/openstreetmap-website] Add indexes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
Well then you'd ideally want an index on author+date+id though we have to think about how much space we want o use on indexes at some point - is here really a need for filtering by date? How often do you know that you need to look at comments from a particular date? -- Reply to this email dire

Re: [openstreetmap/openstreetmap-website] Add indes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
@tomhughes pushed 1 commit. 0100c2c8b148f2a8d3c2d9181c4454c6d3691ae3 Add indes on user+id to changeset and diary comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5531/files/3ebe31d65cea0442111afd70e29aca4bce153bb7..0100c2c8b148f2a8d3c2d9181c4454c6d3691

[openstreetmap/openstreetmap-website] Add indes on user+id to changeset and diary comments (PR #5531)

2025-01-21 Thread Tom Hughes via rails-dev
This adds indexes on `user+id` to diary and changeset comments to make comment views more efficient. Once this is merged we can switch the `diary_comments` association on users to sort by id instead of creation date and then drop the creation date indexes. You can view, comment on, or merge this

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
Merged #5518 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5518#event-16019015784 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

2025-01-21 Thread Tom Hughes via rails-dev
Superseded by #5518. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4248#issuecomment-2605528199 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

[openstreetmap/openstreetmap-website] Preload parent objects for user comments (PR #5530)

2025-01-21 Thread Tom Hughes via rails-dev
I noticed that the comment views were loading objects one by one and this should make it more efficient. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5530 -- Commit Summary -- * Preload parent objects for user co

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

2025-01-21 Thread Tom Hughes via rails-dev
Closed #4248. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4248#event-16019021545 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Test fallback locale on embed page (PR #5528)

2025-01-21 Thread Tom Hughes via rails-dev
Merged #5528 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5528#event-16019015774 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] List of user's changeset comments (PR #5518)

2025-01-21 Thread Tom Hughes via rails-dev
This all looks great to me, thanks. We probably want to think about indexes because changeset comments don't have an index on author+id (neither do diary comments but some people have 80k changeset comments vs a few hundred diary comments) but I don't think that's a blocker based on some quick

Re: [openstreetmap/openstreetmap-website] Test fallback locale on embed page (PR #5528)

2025-01-21 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5528#issuecomment-2605459918 You are receiving this because you are subscribed to this thread. Message ID: ___

[openstreetmap/openstreetmap-website] Enable I18n fallback for the embed page (PR #5527)

2025-01-20 Thread Tom Hughes via rails-dev
Enable I18n fallback for the embed page to fix #5526. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5527 -- Commit Summary -- * Enable I18n fallback for the embed page -- File Changes -- M app/assets/javascri

Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)

2025-01-20 Thread Tom Hughes via rails-dev
Desktop firefox doesn't even offer `cs-CZ` as an option , just plain `cs` but I can reproduce the problem using a country specific version of arabic with the client side I18n failing to fall back to generic arabic. -- Reply to this email directly or view it on GitHub: https://github.com/openstr

Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)

2025-01-20 Thread Tom Hughes via rails-dev
I very much doubt that "only mobile browsers are affected" here - it's much more likely that what matters is what `Accept-Language` header the browser sends and that the mobile browsers you have tested are doing configured differently. -- Reply to this email directly or view it on GitHub: http

Re: [openstreetmap/openstreetmap-website] Use turbo for the settings page to stop the URL changing (PR #5453)

2025-01-19 Thread Tom Hughes via rails-dev
@tomhughes pushed 3 commits. bf3983562b0c6ca265882005eb62492a0e62ae5a Use turbo for the settings page to stop the URL changing d223270779fc28a84d2227fbf63aab0f92d012c2 Replace count.zero? with empty? 368ea6589769e8eb9ccfb1a50f9fa611039c17fb Move errors from email to new_email properly -- Vi

Re: [openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)

2025-01-19 Thread Tom Hughes via rails-dev
Firstly I didn't say it wasn't wanted, I said it is better to keep it in a separate commit to make reviewing easier. Secondly what "same linting as usual" is this? As far as I know it was already passing our eslint rules so is this some additional linting of your own? -- Reply to this email di

Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

2025-01-19 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. >def description -comments.first.body +if user_ip.nil? && user_id.nil? + comments.first.body +else + RichText.new("text", self[:description]) +end end I don't think I've said that as such. What I have said is that we n

Re: [openstreetmap/openstreetmap-website] Replace lookup_friend with lookup_user in FollowsController (PR #5515)

2025-01-19 Thread Tom Hughes via rails-dev
Merged #5515 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5515#event-15989108358 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use resourceful routes for api tracepoints (PR #5516)

2025-01-19 Thread Tom Hughes via rails-dev
Merged #5516 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5516#event-15989108341 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

  1   2   3   4   5   6   >