I removed the eslint config part of the PR.
So we can merge this PR and discuss the needed place to reference eslint config
in the referenced item.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2624265562
You
@HolgerJeromin pushed 1 commit.
267183501e1bc9df671b3452d363389d19ccf5a1 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/4126ef0716ad50e416f174685fe1483180fd3304..267183501e1bc9df671b3452d363389d19ccf
I would like to do a poll which editors are used by the main developers.
😄: Visual Studio Code
🚀: Visual Studio
🎉: emacs
❤️: vim
🚀: jetbrains
😕: other
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976393
Y
In #5557 I added a visual studio code workspace file in the `config` folder.
This file can contain settings but also other stuff.
We have different possibilities:
## move `config/eslint.js` to root folder `eslint.config.cjs`
pro: works with every editor (?) without config
con: pollutes root folde
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5565#pullrequestreview-2577989574
You are receiving this because you are subscribed to this thread.
Message ID:
__
> Shouldn't this update yarn.lock as well as package.json?
added.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2618757934
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
4126ef0716ad50e416f174685fe1483180fd3304 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/896729fcc2cbfa076d1d688bc42072fb304b11af..4126ef0716ad50e416f174685fe1483180fd3
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#pullrequestreview-2577410086
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
On package.json:
The eslint plugin should be added to devDependency?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#pullrequestreview-2576756889
You are receiving this becaus
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5556#pullrequestreview-2575527413
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2575002097
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> -new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
-new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
-new L.OSM.HOT().addTo(map);
- } else
As a first step I migrated the deprecated rules.
After that I want to check which rules are already included in
`js.configs.recommended`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5554#issuecomment-2614532166
You are receiv
### Description
I moved all deprecated eslint to the https://eslint.style/ plugin.
To have easy editor support I added a workspace file for visual studio code.
Right now this only has a link to eslint config file.
I can remove that commit if you do not want editor config files.
### How has this
Sorry, I am not an native speaker. I dod not want to remove the config, but
change its content.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5554#issuecomment-2614426343
You are receiving this because you are subscribed to th
@HolgerJeromin commented on this pull request.
> -new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
-new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
-new L.OSM.HOT().addTo(map);
- } else
Can you show us the js code with the syntax error?
Should be reachable via click on the syntaxError in the console
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/#issuecomment-2614232212
You are receiving this because you ar
We could discuss if we want to keep the current [eslint
config](https://github.com/openstreetmap/openstreetmap-website/blob/master/config/eslint.js).
Most stylistic rules are now removed from eslint because most use a formatter
like prettier.io
But the style rules are moved to [another repo](htt
> Maybe create a new issue for this topic.
> https://github.com/prettier/plugin-ruby could be starting point.
I am not sure if this only formats ruby code.
I am an JS/TS expert so I focus on (native and embedded) js code.
--
Reply to this email directly or view it on GitHub:
https://github.com
We should discuss if we want to keep the current eslint config.
Most stylistic rules are now removed from eslint because most use a formatter
like prettier.io
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-261
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5550#pullrequestreview-2573998167
You are receiving this because you are subscribed to this thread.
Message ID:
__
Duplicate of #5109 and your #3383
Do you have dark mode active?
If yes, this is more visible because the dark background has a bigger contrast
than the light background.
The linked issues are still open:
https://github.com/Leaflet/Leaflet/issues/3575
https://github.com/Leaflet/Leaflet/issues/93
> but I guess this OK as head must have loaded in order for the javascript to
> load.
Yes.
FYI:
`document.body` is not ready sync (if your `
@HolgerJeromin commented on this pull request.
> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
-var parts = pairs[i].split('=');
-
@HolgerJeromin commented on this pull request.
> @@ -37,17 +36,17 @@ window.onload = function () {
map.attributionControl.setPrefix('');
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclem
@HolgerJeromin commented on this pull request.
> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
-var parts = pairs[i].split('=');
-
@HolgerJeromin commented on this pull request.
> +gutter: 4
+ },
+ date: {
+start: startDate
+ },
+ range: 13,
+ data: {
+source: heatmapData,
+type: "json",
+x: "date",
+y: "total_changes"
+ },
+ scale: {
+
Duplicate of #4946
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5525#issuecomment-2602397513
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
@HolgerJeromin commented on this pull request.
> @@ -9,7 +9,7 @@
body {
font-size: $typeheight;
- --dark-mode-map-filter: brightness(.8);
+ --dark-mode-map-filter: none;
Is this needed?
```suggestion
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
> I note that ECMAScript 2021 seems to be fully supported across all the
> mentioned browser versions. So should we target that version instead?
All is better the the current state :)
Should not rule out many useful APIs.
--
Reply to this email directly or view it on GitHub:
https://github.com
@hlfan This deprecates `addListener` (old IE invention) not `addEventListener`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2589971885
You are receiving this because you are subscribed to this thread.
Message
@HolgerJeromin commented on this pull request.
> +function getThemeFromColorScheme(colorScheme) {
+ if (colorScheme === "auto") {
+return window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark"
: "light";
+ }
+ return colorScheme; // Return "light" or "dark" directly if specif
Jquery uses `JSON.parse` for parsing of `ajax()` result.
In a next step switching to `fetch" would allow using
https://developer.mozilla.org/en-US/docs/Web/API/Response/json
Where the parsing is done without blocking the main thread.
--
Reply to this email directly or view it on GitHub:
https://
Yeah, both are different.
As we have no direct connection of the fingers compared to the position on the
map (opposed to pinch gesture on screen) this will be always subjective.
IMO google maps zooms too slow.
But this is a feature from
[leaflet](https://github.com/Leaflet/Leaflet/issues/), so
@HolgerJeromin commented on this pull request.
> @@ -162,6 +172,9 @@ OSM.NewNote = function (map) {
newNoteMarker.dragging.disable();
createNote(location, text, (feature) => {
+if (typeof OSM.user === "undefined") {
+ localStorage.setItem("anonymousNotesCount", a
@HolgerJeromin commented on this pull request.
> @@ -152,6 +152,16 @@ OSM.NewNote = function (map) {
.on("input", updateControls)
.focus();
+var anonymousNotesCount =
Number(localStorage.getItem("anonymousNotesCount"));
```suggestion
var anonymousNotesCount =
Number(lo
@HolgerJeromin commented on this pull request.
> @@ -162,6 +172,9 @@ OSM.NewNote = function (map) {
newNoteMarker.dragging.disable();
createNote(location, text, (feature) => {
+if (typeof OSM.user === "undefined") {
+ localStorage.setItem("anonymousNotesCount", a
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421#pullrequestreview-2526939816
You are receiving this because you are subscribed to this thread.
Message ID:
__
missing 2023 in firefox
https://caniuse.com/mdn-javascript_builtins_weakmap_symbol_as_keys
Is a quite esotheric feature. But really needed stuff was not added in 2023. So
fine with going with 2022.
> I'm assuming that there's going to a be a proportion of people using browsers
> that don't supp
@HolgerJeromin commented on this pull request.
> @@ -411,34 +416,20 @@ L.OSM.share = function (options) {
$("#mapnik_image_width").text(mapWidth);
$("#mapnik_image_height").text(mapHeight);
- const layerId = map.getMapBaseLayerId();
- const layerKeys = new Map([
-
> Maybe we should just remove the references to database maintenance in favour
> of this solution with a URL to an explanatory notice?
Perhaps this is generic enough:
```
The OpenStreetMap database is currently in read-only mode while essential
maintenance work is carried out.
--
Reply to this
Oh, I forgot about this.
But the user can now set his "Preferred Website Color Scheme" which should be
the basis of the theme not the browser setting.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2548889858
Y
@HolgerJeromin commented on this pull request.
> + const heatmapElement = document.querySelector("#cal-heatmap");
+
+ if (!heatmapElement) {
+console.warn("Heatmap element not found in the DOM.");
+return;
+ }
+
+
+ const heatmapData = heatmapElement.dataset.heatmap ?
JSON.parse(hea
@HolgerJeromin commented on this pull request.
> + [CalendarLabel, {
+position: "left",
+key: "left",
+text: () => weekdays,
+textAlign: "end",
+width: 30,
+padding: [23, 10, 0, 0]
+ }],
+ [Tooltip, {
+text: (date, value) =>
It is an known issue that not-logged-in users have no settings to change that.
So this is a duplicate to one of the open issues
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5407#issuecomment-2547576757
You are receiving this b
> Does anyone know how long this maintenance work will last?
https://community.openstreetmap.org/t/openstreetmap-org-currently-offline-operations-team-are-working-to-restore-15-december-2024/122930
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5376#pullrequestreview-2478052628
You are receiving this because you are subscribed to this thread.
Message ID:
__
This would result in having the projects name "never" visible for small
screens... not sure this is good
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5370#issuecomment-2513791593
You are receiving this because you are subscribe
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5371#pullrequestreview-2474831612
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5366#pullrequestreview-2472240325
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5365#pullrequestreview-2472234124
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5364#pullrequestreview-2472233213
You are receiving this because you are subscribed to this thread.
Message ID:
__
How does this help mappers?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5343#issuecomment-2485696176
You are receiving this because you are subscribed to this thread.
Message ID:
The [osm element highlight
color](https://www.openstreetmap.org/way/24240315#map=18/52.516070/13.379459)
is quite saturated. This depends on the monitor setting and for sure the color
of the rendered map.
I
Not all projects work with assignments. Especially to new contributors. This
can result in [cookie licking](https://www.redhat.com/en/blog/dont-lick-cookie).
Go ahead, get familiar to the code base and work on this if you like.
If you solve this. Hurray!
--
Reply to this email directly or view
I get a redirect from
https://azimutt.app/create?sql=https://raw.githubusercontent.com/openstreetmap/openstreetmap-website/refs/heads/master/db/structure.sql&name=OpenStreetMap
to
https://azimutt.app/----/----
which is not helpful..
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5273#pullrequestreview-2380462466
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #4361.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4361#event-14727982128
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
58 matches
Mail list logo
