@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2895610001
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2892221348
You are receiving this because you are subscribed to this thread.
Message ID:
__
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6057)
> So I'm wondering if there is any type of caching or multi-threading happening
> on the public website but not happening on my version.
The main performance boost is that the public website does not run this code at
all :-
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6048)
> Should be resolved with
> https://github.com/openstreetmap/openstreetmap-website/commit/dfbf072b887a5cc63860ae21e82c2f5fe85ec5c4
Yeah. Now he gets localized text he can not edit...
--
Reply to this email directly or vie
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6048)
I think we should try to find why Maro does not see the map.
Do you have a special plugin in your browser?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6
@HolgerJeromin requested changes on this pull request.
should be closed
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6032#pullrequestreview-2853409350
You are receiving this because you are subscribed to this thread.
Message
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6032)
This checks internally for support of
https://developer.mozilla.org/en-US/docs/Web/API/DeviceOrientationEvent/alpha
or
https://developer.apple.com/documentation/webkitjs/deviceorientationevent/1804777-webkitcompassheading
Wh
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5998)
Nice. 🥳
Can you add a screenshot when ready?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998#issuecomment-2869157839
You are receiving this because you a
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5906)
I also do not like the amount of code.
But having 0-30 "wrong" day icons is ugly, too.
Perhaps this could be added upstream as an option...
On the other hand: the calendar lib has no updates since a long time... :-(
--
Repl
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5956)
This looks like a different info for each engine.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#issuecomment-2833142795
You are receiving this because
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5954)
https://github.com/openstreetmap/operations is the right place for this report
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5954#issuecomment-2832271181
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#2882)
> And maybe a bit off topic, but it might be worth having different types of
> icons for different "types" of Notes.
ref for tags on notes #5294
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5906)
We could move to es modules.
There every file has its own scope.
But I have no idea how ruby works with that :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5402)
I created #5905 for tracking that. Perhaps found which could resolve that...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2785429692
You
HolgerJeromin created an issue (openstreetmap/openstreetmap-website#5905)
### Problem
Probably solvable:
https://github.com/wa0x6e/cal-heatmap/issues/513
### Description
_No response_
### Screenshots
_No
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5402)
> You need to hide days that haven't happened, like GitHub. Every time you open
> it, it looks like the user stopped contributing a few weeks ago.
Would be nice.
But I also did not found a way to do that with the used libra
@HolgerJeromin commented on this pull request.
> @@ -59,9 +60,10 @@ document.addEventListener("DOMContentLoaded", () => {
},
scale: {
color: {
- type: "threshold",
+ type: "linear",
Changed to `sqrt` as this got good votes in referenced item.
--
Reply
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5816)
Huh.
I think I did not waited long enough for populating this...
Thanks for testing!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5816#issuecomment-273205
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5873#pullrequestreview-2734889672
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -59,9 +60,10 @@ document.addEventListener("DOMContentLoaded", () => {
},
scale: {
color: {
- type: "threshold",
- range: currentTheme === "dark" ? rangeColors :
Array.from(rangeColors).reverse(),
-
@HolgerJeromin commented on this pull request.
> + domain: [0, heatmapData.reduce((max, item) => {
+return item.total_changes > max ? item.total_changes : max;
+ }, 0)]
Faster for 365 entries? I am not sure.
Definitely not worth the [ugly
readability](https://medi
@HolgerJeromin pushed 1 commit.
38839731cc0c570d3f4f69b38b051063ed5c899e Change heatmap color to linear from 0
to max changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/eb93355677444060e8cda2a53468110cfb1390c1..38839731cc0c570d3f4f69b38b051063e
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5882#pullrequestreview-2740240635
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
85076bd6f336e25140b97f84bbd59350ca4322c5 Change heatmap color to linear from 0
to max changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/b40020b11101d6ee3fb5f546c6e9e0deb7c1f61c..85076bd6f336e25140b97f84bbd59350c
@HolgerJeromin commented on this pull request.
> + <%= t "notes.guide.title" %>
+ <%= t "notes.guide.para_1" %>
+ <%= t "notes.guide.para_2", :note_icon => tag.a(:href => new_note_path,
:class => "icon note bg-dark rounded-1") %>
> but where did the red outline come from?
I would guess fr
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5885#pullrequestreview-2742011665
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#pullrequestreview-2724721311
You are receiving this because you are subscribed to this thread.
Message ID:
__
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5780)
both are working here
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2760421869
You are receiving this because you are subscribed to
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5852)
> Looks food to me, thanks.
you can use "saved replies" here at github...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5852#issuecomment-2760410126
You ar
### Description
Changed heatmap colors
That changes the map to be not comparable from one user to another, but better
shows the day to day changes of one user.
### How has this been tested?
Runtime change
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5831)
It flatens the peaks a bit.
I am not sure if this is better or not. With the linear one we see the
deviation more...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-webs
@HolgerJeromin commented on this pull request.
> + domain: [0, heatmapData.reduce((max, item) => {
+return item.total_changes > max ? item.total_changes : max;
+ }, 0)]
I was not was not awake enough to fiddle myself something and trusted copilot
to find something
@HolgerJeromin pushed 1 commit.
413fcf7ac38231f09d636b7a4f47c06efec9b847 Change heatmap color to sqrt from 0
to max changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/882b060a92d977d9920fb7361ec2fd3c6b88e47d..413fcf7ac38231f09d636b7a4f47c06efec
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5834#pullrequestreview-2706118132
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
882b060a92d977d9920fb7361ec2fd3c6b88e47d Change heatmap color to linear from 0
to max changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/85076bd6f336e25140b97f84bbd59350ca4322c5..882b060a92d977d9920fb7361ec2fd3c6
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5831)
> Is there any benefit to use one of the log types rather than linear, to
> better capture variation at the low end for people that occasionally do large
> edits?
Perhaps my experiments were not correct, but using `pow` did
@HolgerJeromin pushed 1 commit.
eb93355677444060e8cda2a53468110cfb1390c1 Change heatmap color to linear from 0
to max changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/053b77af54dba55c5941f0f2b685dbed30eb7711..eb93355677444060e8cda2a53468110cf
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5831)
We can change die type to `linear` and fill the domain array with the min + max:
```ts
options.scale.color.type = 'linear';
options.scale.color.domain = [0, options.data.source.reduce((max, item) => {
return item.total_cha
Closed #5816.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5816#event-16824624397
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Add intellisense for calHeatmap
The type annotations of the cal-heatmap file is not very good, but still useful:
You can view, comment on, or merge this pull request online at:
https://github.com/openstr
@HolgerJeromin commented on this pull request.
> +$(L.SVG.create("svg"))
+ .append(
+$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112
1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738
1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5596)
> Fixed by https://github.com/openstreetmap/openstreetmap-website/pull/4789
How? This added a link only
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/559
@HolgerJeromin commented on this pull request.
> +$(L.SVG.create("svg"))
+ .append(
+$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112
1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738
1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2661720002
You are receiving this because you are subscribed to this thread.
Message ID:
__
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#4789)
@hlfan
Would be nice if we could reuse the color of the text or link.
Easiest would be to use
[`currentColor`](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentcolor_keyword):
```html
http://www.w3.org/20
@HolgerJeromin approved this pull request.
But I did not tested this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2653141690
You are receiving this because you are subscribed to this thread.
Message I
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5734#pullrequestreview-2651664369
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2650507505
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> +.then(html => $section.html(html))
+.then(update);
Right now `update` will get the html from the `.html(html)` [jquery
call](https://api.jquery.com/html/#html2).
This would prevent "leaking" the data into the next promise chain:
@HolgerJeromin commented on this pull request.
> +.then(html => $section.html(html))
+.then(update);
Same in app/assets/javascripts/user.js file
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#discussion_r1
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#1645)
Very offtopic here. And you know it!
The reason for that is clear linked from that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1645#issuecomment-26760
@HolgerJeromin commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+
@HolgerJeromin commented on this pull request.
> +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)}
+ }.freeze
+
+ NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze
+
+ def parsed
+URL_PATTERNS.each do |platform, pattern|
+ names = url.match(patt
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5707)
> Is this actually working?
yes:
> If you go with
> https://eslint.style/guide/migration#approach-1-migrate-to-single-plugin and
> i
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5707)
I could have kept the name in the end, but having the standard `.mjs` module
extension feels not too bad.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/570
@HolgerJeromin pushed 1 commit.
0f767263926ef8d3e8bd01aee7dce3e34c6cad94 Migrate eslint config to esmodules
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5707/files/e867f1783f2eecf8ad09afe08db6bb8ecd5b4731..0f767263926ef8d3e8bd01aee7dce3e34c6cad94
You are rec
And upgrade `@stylistic/eslint-plugin-js` to `4.0.x`
closes #5704
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5707
-- Commit Summary --
* Migrate eslint config to esmodules
-- File Changes --
M .overcommi
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5704)
I am working on migrating to clean esmodules for this config.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5704#issuecomment-2667914850
You are receiving t
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5704)
fails with
> Error [ERR_REQUIRE_ESM]: require() of ES Module
> /home/runner/work/openstreetmap-website/openstreetmap-website/node_modules/@stylistic/eslint-plugin-js/dist/index.js
> from
> /home/runner/work/openstreetmap-we
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5699)
> So just installing those packages (even though we don't use them) somehow
> changes vscode's behaviour?
Yes.
The editor searches known files in `node_modules/@types`.
In the past you needed include comments, but this is (
@HolgerJeromin commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"]
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2620792037
You are receiving this because you are subscribed to this thread.
Message ID:
__
At least vscode (derivates) provide first class intellisense support out of the
box with that.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreet
@HolgerJeromin commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"]
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5692)
That is good:
> Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and
> will be fully unsupported by 2025-04-01
https://github.com/actions/runner-images/issues/11101
--
Reply to this email directly or
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2619602000
You are receiving this because you are subscribed to this thread.
Message ID:
__
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5558)
Can we merge this please?
At least I hesitate to do small things which only creates conflicts with this
PR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#pullrequestreview-2617098758
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
@HolgerJeromin commented on this pull request.
>.appendTo($ul);
- }
-}));
+ });
Thanks.
Will now result in a bit to feed the garbage collector (potentially the whole
fetch tree with data).
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
@HolgerJeromin commented on this pull request.
>.appendTo($ul);
- }
-}));
+ });
Missing controller cleanup?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5662#pullrequestreview-2613338410
You are rec
@HolgerJeromin commented on this pull request.
>} else if (id.data("lat") && id.data("lon")) {
-params.set("map", "16/" + id.data("lat") + "/" + id.data("lon"));
+map = [null, id.data("lat"), id.data("lon")];
We have again both 16 and 17 default zoom level in this PR.
--
Reply to
@HolgerJeromin commented on this pull request.
>engines:
-fossgis_osrm_bike: "Bicycle (OSRM)"
-fossgis_osrm_car: "Car (OSRM)"
-fossgis_osrm_foot: "Foot (OSRM)"
-graphhopper_bicycle: "Bicycle (GraphHopper)"
-graphhopper_car: "Car (GraphHopper)"
-
> I still don't know what I need to change in the testing stub
I would guess:
```ruby
def stub_straight_routing(start_instruction: "Start here",
finish_instruction: "Finish there")
stub_routing <<~CALLBACK
const distance = points[0].distanceTo(points[1]);
const time = distance
### Description
A file comment combined with a config section is a bit confusing.
ref #5651
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5653
-- Commit Summary --
* eslint: Move file config to eslint section
--
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
Yeah, activate for this file in config and disable in most other parts is a bit
cumbersome:
```
/* eslint-disable sort-keys */
... start of th
@HolgerJeromin commented on this pull request.
> @@ -9,6 +13,35 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+
maplibregl.setRTLTextPlugin("https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
true);
I am pretty sure t
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
Ah, I see. We can [ignore some rules in some
lines](https://eslint.org/docs/latest/use/configure/rules#disabling-rules) with
eslint. But not
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
If you are willing to sort everything (not sure if this is good to read) this
should be done here:
```
rules: {eslint sort-keys: ["error"]}
-
@HolgerJeromin commented on this pull request.
> @@ -3,7 +3,8 @@
//= require_tree ./directions
OSM.Directions = function (map) {
- var routeRequest = null; // jqXHR object of an ongoing route request or null
+ let awaitingRoute = false; // true if a route request is in progress
Do we real
@HolgerJeromin commented on this pull request.
> @@ -212,6 +202,13 @@ OSM.Directions = function (map) {
map.setSidebarOverlaid(true);
// TODO: collapse width of sidebar back to previous
});
+}).catch(function () {
+ map.removeLayer(polyline);
+ if (reportEr
@HolgerJeromin commented on this pull request.
> -routeRequest = chosenEngine.getRoute(points, function (err, route) {
- routeRequest = null;
-
- if (err) {
-map.removeLayer(polyline);
-
-if (reportErrors) {
- $("#sidebar_content").html("" +
I18n.t("javasc
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2604970286
You are receiving this because you are subscribed to this thread.
Message ID:
__
This pushes json parsing off the js main thread. Hurray
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#issuecomment-2647180475
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
-};
-return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: functio
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632#pullrequestreview-2604130700
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5631#pullrequestreview-2603997470
You are receiving this because you are subscribed to this thread.
Message ID:
__
We do [not work with
assigns](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues).
Just go ahead! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5540#issuecomment-2642729245
This needs rebasing and some adjustment after merge of my #5613
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621#issuecomment-2640783441
You are receiving this because you are subscribed to this thread.
Message ID:
__
@Satya900 We do [not work with
assigns](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues).
Just go ahead! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-
@HolgerJeromin pushed 2 commits.
a4e6934d599e92d755ab1ff949ed468eea1a9bf0 Fix all no-implicit-globals eslint
errors
49b65a09dd83764ee7c0bb2ab5661775cceeefab Change eslint no-implicit-globals
rule to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613/
@HolgerJeromin pushed 2 commits.
c855d86bf8ca9e1c240e6f0fa803deb3f69e5e6c Mark valid usecases for alert
eee793f5e6e534442793c88f06caca2ccb5c12d1 change eslint rule no-alert to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614/files/b189286288238fe5615
Oh, yes. Will fix the pr tomorrow
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#issuecomment-2637828616
You are receiving this because you are subscribed to this thread.
Message ID:
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
> You don't need to touch every single line via indenting if you write the
> globals as
> const DemoEngine = function (...) { ... };
Then we would have `DemoEngine` poluting the global scope...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
1 - 100 of 178 matches
Mail list logo
