@HolgerJeromin commented on this pull request.
> + .then(html => $section.html(html))
+ .then(update);
Right now `update` will get the html from the `.html(html)` [jquery
call](https://api.jquery.com/html/#html2).
This would prevent "leaking" the data into the next promise chain:
```suggestion
.then(html => {
$section.html(html)
return;
})
.then(update);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2649992818
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5731/review/2649992...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
