You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6081
-- Commit Summary --
* Fix template rendered on profile update failure
-- File Changes --
M app/controllers/profiles_controller.rb (2)
M test/controller
@AntonKhorev commented on this pull request.
> + gl: Galician
+ gsw: Alemannic (specifically Swiss German, Alsatian)
+ gu: Gujarati
+ he: Hebrew
+ hi: Hindi
+ hr: Croatian
+ hsb: Sorbian, Upper
+ hu: Hungarian
+ ia: Interlingua
+ id: Indonesian
+
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065)
> Should the osm.town Mastodon also get osm-related treatment?
Maybe.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2931238593
You are rece
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065)
> > no "iki" in microscopic font size
>
> which makes the icon barely different from the Wikipedia icon, sans serif W
> vs. serif W
That's why two icons for osm subdomains.
> > two icons for osm for osm subdomains
>
> Not e
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
can be resolved with
https://github.com/openstreetmap/openstreetmap-
@AntonKhorev commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065)
How about this:
- no "iki" in microscopic font size (#6072 still wants it)
- two icons for osm for osm subdomains, like this: (forum icon).(osm logo)
- similarly two icons for ohm and ogf subdomains
--
Reply to this email dir
It was necessary for tests relying on old French message before getting an
update from Translatewiki.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6080
-- Commit Summary --
* Remove "preferences updated" flash fa
#6076 as it currently is will fail this test.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6078
-- Commit Summary --
* Test sorting multiple enclosing features across antimeridian
-- File Changes --
M test/s
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6076)
What do you think `.wrap()` on `L.LatLngBounds` does? See
https://github.com/openstreetmap/openstreetmap-website/pull/5473#issue-2770179737.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
Merged #6077 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6077#event-17919472698
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6077)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6077#issuecomment-2928116090
You are receiving this because you are subscribed to this thread.
Closed #6075 as completed via d9b758267c169f29560c824dee81f8ace77de11d.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6075#event-17919472645
You are receiving this because you are subscribed to this thread.
Message ID:
__
#6072 tried to change the color of the ogf icon to match the colors of other
social icons. Except that wouldn't work as intended because the lines in
the ogf icon are narrower than 1px. It already looks bleak, and with that color
change it's going to be bleaker. There's not much to be done about
@AntonKhorev pushed 3 commits.
acfadceb6d0686e809f914485a3cfa450fc56542 Fix overpass query feature areas for
bounds including antimeridian
0495960282330c697609494c19c7fd2a34f498f6 Remove unnecessary consts in overpass
query js controller
740b5720317208fd72e9f450bedda1ffebf993a2 Test overpass
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6072)
Let's start with a change that shouldn't be in this PR. "Use bs light mode bg
secondary color consistently". Are you taking line width into account? (no)
--
Reply to this email directly or view it on GitHub:
https://github.co
#6010 added truncated diary entries to profile pages. The truncation procedure
is different from from others already in use. It gets html, strips tags and
does the standard rails truncation to 150 chars:
```ruby
truncate(strip_tags(entry.body.to_html), :length => 150)
```
So it's truncate to pl
@AntonKhorev pushed 13 commits.
c392285cafddeca88af93e287eaf1df0f9823792 Move change preferences path to
preferences/basic
9533d26595fac3e651947a9f07d005dd3d852100 Update basic preferences path helpers
f15f8aad1eb088f2553e096b584778f56d9778f6 Move basic preferences controller to
preferences m
@AntonKhorev pushed 1 commit.
56aab6d6dd0dc13c0925e9929721f5063adfef93 Add show_hidden parameter for note
queries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3934/files/2309791e367a69da241b6f383f1c885a75d9c634..56aab6d6dd0dc13c0925e9929721f5063adfef93
You
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6070
-- Commit Summary --
* Shift-click Zoom Out in notes layer tooltip test
* Fix intended asserts in notes layer tooltip test
* Don't use
@AntonKhorev pushed 3 commits.
de99ffeb355c96dca4b36c172b9d1a288fb9071a Fix overpass query feature areas for
bounds including antimeridian
65a01be5d5d2f3f275f956e9f0c929d94162d6c9 Remove unnecessary consts in overpass
query js controller
b6e44b4928ac5a2c913407c7e2af3c6524d2e37a Test overpass
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6069
-- Commit Summary --
* Shift-click Zoom Out in notes layer tooltip test
* Fix intended asserts in notes layer tooltip test
* Don't use
Merged #6066 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6066#event-17883471461
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Replace `Object.keys().map()` with `Object.values()` which wasn't widely
supported when the code was written.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6067
-- Commit Summary --
* Use Object.values in overpass
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6037)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6037#issuecomment-2922239548
You are receiving this because you are subscribed to this thread.
Closed #3447 as completed via #6037.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3447#event-17884542051
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6037 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6037#event-17884541628
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6066)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6066#issuecomment-2922003430
You are receiving this because you are subscribed to this thread.
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5956)
Merged, thanks.
If we also need that "Routing services allow checking..." disclaimer, we can
put it for example on the bottom of the directions panel, somewhere here:
![image](https://github.com/user-attachments/assets/b42f7fd
Merged #5956 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#event-17871075625
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
The icon currently has "Wiki" inside the magnifying glass. I
don't think anyone can read "iki" there without zooming in really
far. "iki" also takes away space that can be used to make
"W" more readable.
This PR removes "iki" and makes "W" larger.
Before:
After in Firefox:
You can view, comment on, or merge this pull request online at:
https://githu
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6062)
> Is the `javascripts.social_links.remove` translation still used somewhere
> else? Otherwise it should be removed since it's already a duplicate.
It's not used. That's why it was already removed.
--
Reply to this email dire
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6062)
> The only real use I could think of was accessibility but the actual links
> aren't numbered once they're filled in so it doesn't seem like it helps with
> relating them to the remove buttons.
Placeholders are announced by s
@AntonKhorev pushed 5 commits.
5c5364bcce7f63f4561deaf4b47cf8bbef93afff Remove unnecessary
event.preventDefault() from "Add Social Link"
3ac83941881536743ef8eb1b999fca1bf33abbe2 Remove unused ids from social link
inputs
5ee22cd407d836e195e3ea0d897dd015fd2f208e Add social link controls using h
@AntonKhorev pushed 3 commits.
73a8cdcd9af692e6bc032b3fc60d2693a41131af Add social link controls using html
template
79c51e5472f32ab9cba8b0ac4bbe92015ef3ac2d Add placeholders/titles to social
link controls
01d077693637ec628642029ca015b86ab9c63581 Make remove social link buttons
always actual
@AntonKhorev pushed 3 commits.
0f667a94f3ce46ea4a9111474b7f3205a1df3385 Add social link controls using html
template
88018e61505dd08c035e36d11cbfcf48963d3a31 Add placeholders/titles to social
link controls
37927d8f8366fd769dc51c2475583dac437b5e75 Make remove social link buttons
always actual
Fixes
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2904227124
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6062
-- Commit Summary --
* Remove unnecessary event.preventDefault() fr
Change the class name to ConfirmationsControllerTest to match the filename and
the tested controller.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6061
-- Commit Summary --
* Rename confirmations controller test
@AntonKhorev pushed 1 commit.
c7aa86f5be2730359cad1d2b701e5f74261b743d Remove /edit from profile form path
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6060/files/ad7aaba3b6c3c024315afc220a7fd6fd3b887ba6..c7aa86f5be2730359cad1d2b701e5f74261b743d
You are rece
Changes `/profile/edit` path to `/profile`.
This makes it similar to account and preferences paths that also don't have
`/edit`. Getting `/profile` is now allowed, making it possible to reload the
profile edit form page.
You can view, comment on, or merge this pull request online at:
https:/
@AntonKhorev pushed 3 commits.
c8fa8ebbed185c77e912b297924751b770004fe3 Allow to revisit terms page if
already agreed
db1ab99c6d52137eb2a55d9fdf01a02974ac379f Allow to agree to new terms if
already agreed to old terms
1c1753819257faefbf694ba5edb715c9fc9f9d19 Show terms acceptance dates and li
@AntonKhorev commented on this pull request.
> @@ -112,7 +116,10 @@ OSM.History = function (map) {
function toggleChangesetHighlight(id, state) {
changesetsLayer.toggleChangesetHighlight(id, state);
-$("#changeset_" + id).toggleClass("selected", state);
+$("#sidebar_content .ch
@AntonKhorev pushed 1 commit.
8708d91e9620b461a9ef48a03f8de495d35700af Avoid highlighting multiple
changesets in history sidebar
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6059/files/b65eed6189d216c0741d01805c21d0bfd6726482..8708d91e9620b461a9ef48a03f8de4
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6053)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6053#issuecomment-2912496948
You are receiving this because you are subscribed to this thread.
@AntonKhorev pushed 1 commit.
b65eed6189d216c0741d01805c21d0bfd6726482 Avoid highlighting multiple
changesets in history sidebar
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6059/files/ada39e959d4b58047f6c44b80e612cf498760ec8..b65eed6189d216c0741d01805c21d0
@AntonKhorev pushed 4 commits.
79b9d32a2feccb50325108cff00805eb5f59afe0 Add "Scroll to changeset" context
menu item to history pages
cb2bd176d1b38a59e96defef6625f29524416b18 Remove nested .changesets from lists
on history pages
efc52b4af3976a85b86cba2684605600e26db991 Use within_sidebar inste
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6059
-- Commit Summary --
* Add "Scroll to changeset" context menu item to history pages
* Remove nested .changesets from lists on history pages
* Use within_sideb
Merged #6053 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6053#event-17830558116
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> +preferred_languages.expand.each do |locale|
+ key = "name:#{locale}"
+ return tags[key] if tags[key]
+
+ key = "name:#{locale.to_s.split('-').first}"
+ return tags[key] if tags[key]
+end
`expand` adds candidate language
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880)
> **@‌AntonKhorev** seems to have quite a preference for mixing multiple
> languages and concerns within a single file. Take a look at this
> https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-249593
@AntonKhorev commented on this pull request.
> @@ -1,6 +1,7 @@
class TracesController < ApplicationController
include UserMethods
include PaginationMethods
+ include ActionView::Helpers::TagHelper
Is this include still needed after the fix
https://github.com/openstreetmap/openstreetmap
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6052)
The answer is going to be something like
https://github.com/openstreetmap/openstreetmap-website/pull/5964#discussion_r2068774443.
For example, `#menu-icon` is not going to exist once it's replaced by the
[Bootstrap navbar](ht
AntonKhorev left a comment (openstreetmap/openstreetmap-website#3123)
For touch devices `title` is not the best choice. `optgroup` looks like this if
you tap the select:
--
Reply to this email directly or
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6050
-- Commit Summary --
* Rename "social share buttons" to "share buttons"
* Remove social-share-buttons css class
* Rename share button icons directory
-- File
Fixes #6043.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6049
-- Commit Summary --
* Invert social link icons in dark mo
Merged #6039 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6039#event-17800336943
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6039)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6039#issuecomment-2906844141
You are receiving this because you are subscribed to this thread.
Merged #6047 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6047#event-17800217894
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5956)
Let's suppose I don't know anything about osm. I open the site, I see the
button with two arrows, there's a tooltip on it that says "Find directions...".
I click it and I see on the top a car, a bicycle and a person walking, t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6047)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6047#issuecomment-2906824686
You are receiving this because you are subscribed to this thread.
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6046)
> The cells resize to fit into the container without scrolling
You get both scrolling and small cells on a phone.
> the current min width of 10 px can easily be increased
To what? Increase it to 14px and no *responsive* resiz
@AntonKhorev pushed 1 commit.
3109ca690a93d689a900db21a59575bbdcc238a1 Show heatmap only to logged in users
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829/files/251599ba6c2592504afd8ef747af8e8f5d110d6b..3109ca690a93d689a900db21a59575bbdcc238a1
You are rec
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6046)
> > if it would be possible to reserve a fixed space up front for the frame to
> > fill
>
> The old SVG version had a fixed height, but now with it being responsive it's
> more complicated, but with min-height, max-height and
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5956)
Weren't we trying to remove unnecessary controls like the *Go* button?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#issuecomment-2904947211
You are rece
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6046
-- Commit Summary --
* Test if max_id is present in heatmap data
* Split heatmap rendering test
* Move heatmap to Turbo frame
* Move heatmaps controller tes
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6042)
Autofocus attribute on page load doesn't cause the keyboard to pop up,
javascript focus does.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6042#issuecomment
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5439)
This got too clever with *label of hidden checkbox styled as a button* with
consequences for keyboard navigation.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6040)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6040#issuecomment-2904160015
You are receiving this because you are subscribed to this thread.
Merged #6040 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6040#event-17788584726
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6042)
Do you want more virual keyboard issues on phones?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6042#issuecomment-2904051761
You are receiving this because y
@AntonKhorev commented on this pull request.
> - return tags["addr:housenumber"] + " " + tags["addr:street"];
+ return OSM.i18n.t(
+"javascripts.query.address",
+{ housenumber: tags["addr:housenumber"], street: tags["addr:street"] }
+ );
Should an addres at an arb
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4194)
> > blocking users from manually setting their username to user_NNN type
> > usernames, to avoid collisions,
> > giving the user "name" in the browse pages. We are already publishing the
> > uid and generated username in the X
@AntonKhorev pushed 1 commit.
f0bc5d01e887f8b7295c6fa3987085dc41236d9d Use dir="auto" for comments on
element browse pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6033/files/33fbf7028252587f66793abc8949b9e98baf54ae..f0bc5d01e887f8b7295c6fa3987085dc4123
Not part of #3429.
Fixes the first wrong image from
https://github.com/openstreetmap/openstreetmap-website/pull/3429#issuecomment-2828944354.
Before:
After:
assert_not_nil heatmap_data
assert_predicate heatmap_data[:data], :any?
# The data should be in the right format
-assert(
@AntonKhorev pushed 3 commits.
997831c904b20f1c4b527f1b7fc652c8214ed76e Test if max_id is present in heatmap
data
f071e03efc4743541d9f41d74fc4753c1d25df1f Split heatmap rendering test
251599ba6c2592504afd8ef747af8e8f5d110d6b Show heatmap only to logged in users
--
View it on GitHub:
https://
@AntonKhorev pushed 6 commits.
aa14f2577426575b1028f74bc5a21e35ae94d743 Add dir=auto to user generated content
85759a3250397b2570100ba9b409b2f3b5a33df9 Add dir=auto to usernames
ea601a6e65db9c0efc1dc277aaf106c62f9fde49 Merge remote-tracking branch
'upstream/pull/3429'
d9011934097e3177635073957
@AntonKhorev commented on this pull request.
> @@ -33,7 +34,7 @@ def index
elsif current_user && current_user == target_user
t ".my_gps_traces"
else
- t ".public_traces_from", :user => target_user.display_name
+ t ".public_t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#1735)
> The user can already
>
>* (a list of completely different things)
...and the solutions proposed here are *let's do another completely different
thing like a popup menu*.
If we don't want to introduce *another completel
@AntonKhorev pushed 1 commit.
6dd8dcd4319467cf8c70fd4fc2d9f7c09c3a5463 Show heatmap only to logged in users
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829/files/c65a529009d77c0af14210ca9317032a04d1f948..6dd8dcd4319467cf8c70fd4fc2d9f7c09c3a5463
You are rec
@AntonKhorev pushed 3 commits.
1ed00e36177de2da9dd36b20a75e6290ea748762 Test if max_id is present in heatmap
data
d4be383971f9c10f119637c5698f16352561cd93 Split heatmap rendering test
c65a529009d77c0af14210ca9317032a04d1f948 Show heatmap only to logged in users
--
View it on GitHub:
https://
Replaces
```
user_path(user.display_name)
```
and likes with
```
user_path(user)
```
They mostly were replaced already but heatmap and friends-follows brought some
back.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6027
-- Commit Summary --
* Use css properties of heatmap cells for everything except colors
* Use spans instead of divs in all heatmap cells
* Restore the origina
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6022)
My guess is that the user show action is too slow because it needs to compute
the heatmap.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#issuecomment-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6022)
It fails while still on *Edit Profile* page. You can see that from the text
output.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#issuecomment-2889036
@AntonKhorev commented on this pull request.
> +
+ {
+:code => code,
+:native_name => native_name
+ }
+end
+
+AVAILABLE_LANGUAGES.sort_by! do |entry|
+ # https://stackoverflow.com/a/74029319
+ diactrics = [*0x1DC0..0x1DFF, *0x0300..0x036F, *0xFE20..0xFE2F].pack("U*")
+ entry[:native
@AntonKhorev pushed 1 commit.
4bfe88ba6a86240fec6f447d3539d9b16a01c7d5 Adapt basic language select to update
multiple language values
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6024/files/ca2db20f9a2a2aa6e736d82496e778934aadbd34..4bfe88ba6a86240fec6f447d3
@AntonKhorev pushed 4 commits.
a1824f0f0c95e2176ee1504ec44319d14fea0afe List available ui languages
797e27c46c4f1517be4a70e968dad5a18120f986 Replace text input with select for
basic language preference
32406fd93ee573646ba23e0130722ca4b3595a3a Adapt basic language select to update
single langu
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6017)
Anyway, looks like we're doing it for other things already and TranslateWiki
has no issues with it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6017#issuec
Merged #6017 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6017#event-17703059662
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> +
+ {
+:code => code,
+:native_name => native_name
+ }
+end
+
+AVAILABLE_LANGUAGES.sort_by! do |entry|
+ # https://stackoverflow.com/a/74029319
+ diactrics = [*0x1DC0..0x1DFF, *0x0300..0x036F, *0xFE20..0xFE2F].pack("U*")
+ entry[:native
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6017)
Before:
After - this is not how you write dates in Russian (and probably many other
languages):
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-web
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5992)
The only thing that could be significantly improved here were km/mi buttons
code. I didn't do this because I haven't finished with them. There were
supposed to be tooltips and I also wanted to try miles-yards, in which case th
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5992)
What was an improvement here?
Especially given this [let's move unit conversions out of
formatters](https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2039306783),
which I did, followed by [let's mov
1 - 100 of 1419 matches
Mail list logo
