AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880)

> **@‌AntonKhorev** seems to have quite a preference for mixing multiple 
> languages and concerns within a single file. Take a look at this 
> https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-2495930790
>  from @tomhughes on another PR of his:

Also take a look at my answer and asset pipeline dependencies.

> > ... a massive multi-line block of Ruby embedded in a JS file is definitely 
> > not the answer to my mind at least.
> 
> Swap out the languages, and we land at this issue here:
> 
> > ... a massive multi-line block of SVG embedded in an ERB file is definitely 
> > not the answer ...
> 

"massive multi-line block" is an exaggeration in both cases.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-2910081927
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/5880/2910081...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to