Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-21 Thread Tom Hughes via rails-dev
Closed #6035 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6035#event-1776263 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-21 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035) https://wiki.openstreetmap.org/wiki/Anonymous_edits has some more background. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6035#issuecomment-2899942196 You are

[openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-21 Thread Andres Gomez Casanova via rails-dev
angoca created an issue (openstreetmap/openstreetmap-website#6035) ### Problem I am translating and reviewing the website into Spanish. I found this: "Osm:Site.not public flash.not public/" - "You have not set your edits to be public." However, I am unsure if the translation is correct. Is the

Re: [openstreetmap/openstreetmap-website] User profile page: number delimiter if large number of contributions (PR #6034)

2025-05-21 Thread mtmail via rails-dev
Closed #6034. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6034#event-17762820193 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] User profile page: number delimiter if large number of contributions (PR #6034)

2025-05-21 Thread mtmail via rails-dev
I noticed large numbers on the user profile page are formatted (thousand separator) but not the number of contributions yet. ### Description ![image](https://github.com/user-attachments/assets/f33b5821-8e34-4c2b-8889-7eaf5ade3cca) ### How has this been tested? Github CI. The `test/controllers/us

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-21 Thread Marwin Hochfelsner via rails-dev
@hlfan requested changes on this pull request. Thanks for the update, it's coming together! I still found a few nitpicks. > @@ -0,0 +1,31 @@ +<% if diary_entries.present? %> + <%= t(".latest_diaries") %> + +<% diary_entries.each do |entry| %> + + + + +

Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)

2025-05-21 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6028) > Here's some other people reporting it on the community forums: https://community.openstreetmap.org/t/actual-problems-with-id-editor/130320/2 At least some users mentioned in https://community.openstreetmap.org/t/current-problems

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-21 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#6010) > I wonder if this should go underneath the heatmap rather than above it? It > pretty much pushes the heatmap below the fold on a laptop... Repositioned as suggested and resolved conflicts. Let me know if some additional changes are

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-21 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 5132e7ffa718005a0b9f85a6ce063b5eb8f6c085 Add profile diaries partial to profile -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/e00aecba8ffaaf1c596903ce8061cd04edb33202..5132e7ffa718005a0b9f85a6ce063b5eb8f6c085 You are receivin

Re: [openstreetmap/openstreetmap-website] Optimize user creation illustrations by reusing elements (PR #5894)

2025-05-21 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5894) @AntonKhorev should I only remove the file splitting or more? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5894#issuecomment-2898776701 You are receiving this beca

Re: [openstreetmap/openstreetmap-website] Remove changeset icon redefinitions (PR #5884)

2025-05-21 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5884) I've mostly been ignoring the SVG PRs as I don't really know much about SVG and there was a lot of debate between you, @AntonKhorev and @gravitystorm about what was the best approach. -- Reply to this email directly or view it

Re: [openstreetmap/openstreetmap-website] Remove changeset icon redefinitions (PR #5884)

2025-05-21 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5884) Anything blocking this @tomhughes? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5884#issuecomment-2898768036 You are receiving this because you are subscribed to t

Re: [openstreetmap/openstreetmap-website] Use for comments in changeset history lists (PR #6033)

2025-05-21 Thread Tom Hughes via rails-dev
Merged #6033 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6033#event-17757534140 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use for comments in changeset history lists (PR #6033)

2025-05-21 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6033) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6033#issuecomment-2898601536 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] After self-deletion of a user, make the username random but still clickable (Issue #4194)

2025-05-21 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4194) > > blocking users from manually setting their username to user_NNN type > > usernames, to avoid collisions, > > giving the user "name" in the browse pages. We are already publishing the > > uid and generated username in the X

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-21 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -153,6 +153,14 @@ <%= @user.home_location_name %> <% end %> +<% if @user.company&.strip.present? %> + +http://www.w3.org/2000/svg"; width="16" height="16" fill="curr

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-21 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -153,6 +153,14 @@ <%= @user.home_location_name %> <% end %> +<% if @user.company&.strip.present? %> + +http://www.w3.org/2000/svg"; width="16" height="16" fill="curr

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-21 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5987) Thank you for the reviews. PR was updated according to the comments. @tomhughes icon was changed from the `suitcase` to the `building`. @mmd-osm length of the `company field` was changed (I'll create a separate small PR for `home_lo

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-21 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 6bc4fab7bc1427966d4615afe42bc5e31ec244bc Company Name on Profile Page -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/be64551ad822cb20d7e29022e4f57fb40a76f8a2..6bc4fab7bc1427966d4615afe42bc5e31ec244bc You are receiving this be