@hlfan requested changes on this pull request.
Thanks for the update, it's coming together! I still found a few nitpicks.
> @@ -0,0 +1,31 @@
+<% if diary_entries.present? %>
+ <h2 class="text-body-secondary fs-5 mt-4"><%= t(".latest_diaries") %></h2>
+ <div class="row row-cols-1 row-cols-md-2 g-4">
+ <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round" aria-label="Note"><path d="M2
6h4" /><path d="M2 10h4" /><path d="M2 14h4" /><path d="M2 18h4" /><rect
width="16" height="20" x="4" y="2" rx="2" /><path d="M9.5 8h5" /><path d="M9.5
12H16" /><path d="M9.5 16H14" /></svg>
"Note" doesn't seem like the right label here, maybe _Diary Entry_?
> + <h2 class="text-body-secondary fs-5 mt-4"><%= t(".latest_diaries") %></h2>
+ <div class="row row-cols-1 row-cols-md-2 g-4">
+ <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round" aria-label="Note"><path d="M2
6h4" /><path d="M2 10h4" /><path d="M2 14h4" /><path d="M2 18h4" /><rect
width="16" height="20" x="4" y="2" rx="2" /><path d="M9.5 8h5" /><path d="M9.5
12H16" /><path d="M9.5 16H14" /></svg>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+ </p>
+ <p class="card-text flex-grow-1"><%=
truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
+
+ <div class="card-text d-flex justify-content-between
align-items-center mt-auto">
+ <small class="text-body-secondary d-flex align-items-center">
+ <svg xmlns="http://www.w3.org/2000/svg"; width="20" height="20"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round" class="me-1"
aria-label="Comments"><path d="M7.9 20A9 9 0 1 0 4 16.1L2 22Z" /></svg>
+ <%= link_to "#{diary_entry_path(@user, entry)}#comments",
:class => "text-body-secondary" do %>
The anchor could be passed to the path.
```suggestion
<%= link_to diary_entry_path(@user, entry, :anchor =>
"comments"), :class => "text-body-secondary" do %>
```
> + <div class="row row-cols-1 row-cols-md-2 g-4">
+ <% diary_entries.each do |entry| %>
+ <div class="col profile-diary-card">
+ <div class="card h-100">
+ <div class="card-body d-flex flex-column">
+ <p class="card-title">
+ <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round" aria-label="Note"><path d="M2
6h4" /><path d="M2 10h4" /><path d="M2 14h4" /><path d="M2 18h4" /><rect
width="16" height="20" x="4" y="2" rx="2" /><path d="M9.5 8h5" /><path d="M9.5
12H16" /><path d="M9.5 16H14" /></svg>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+ </p>
+ <p class="card-text flex-grow-1"><%=
truncate(strip_tags(entry.body.to_html), :length => 150) %></p>
+
+ <div class="card-text d-flex justify-content-between
align-items-center mt-auto">
+ <small class="text-body-secondary d-flex align-items-center">
+ <svg xmlns="http://www.w3.org/2000/svg"; width="20" height="20"
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round" class="me-1"
aria-label="Comments"><path d="M7.9 20A9 9 0 1 0 4 16.1L2 22Z" /></svg>
+ <%= link_to "#{diary_entry_path(@user, entry)}#comments",
:class => "text-body-secondary" do %>
+ <span><%= entry.comments.size %> <%=
"comment".pluralize(entry.comments.size) %></span>
Shouldn't this be translated?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010#pullrequestreview-2859004911
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6010/review/2859004...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
